Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035806Openbravo ERPA. Platformpublic2017-03-30 16:222017-04-24 13:46
ReporterJONHM 
Assigned Toinigosanchez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR17Q1.1Fixed in Version3.0PR17Q1.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-02-11
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/670d9903e7053700dad4cd2321b3df166571e122 [^]
Triggers an Emergency PackNo
Summary0035806: Fields redraws in grid view when a numeric field is referenced by a read only logic
DescriptionWhen editing a numeric field in grid view which is referenced by read only logic by some other field of the same table, it redraws and format its value automatically
Steps To ReproduceAs System Administrator:
1) Open 'Tables and columns' window
2) Select C_OrderLine table and PriceActual field
3) Edit its Read Only Logic adding the reference to the PriceList column:
 @Processed@='Y' | @GROSSPRICE@='Y' & @PriceList@!0
4) Then, make the same step with the PriceList field, referencing the PriceActual column:
 @Processed@='Y' & @PriceActual@!0

As 'F&B International Group Admin':
4) Open Sales Order window and create a new record
5) Create a new record in grid view into [Lines] subtab also change its 'Net Unit Price'
--> The net unit price will be redrawed inmediately
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0035658 closed inigosanchez Fields redraws in grid view when a numeric field is referenced by a read only logic 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-04-20 10:57inigosanchezTypedefect => backport
2017-04-20 10:57inigosanchezTarget Version => 3.0PR17Q1.1
2017-04-21 13:29inigosanchezReview Assigned To => caristu
2017-04-21 13:31hgbotCheckin
2017-04-21 13:31hgbotNote Added: 0096101
2017-04-21 13:31hgbotStatusscheduled => resolved
2017-04-21 13:31hgbotResolutionopen => fixed
2017-04-21 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/35fe280e4dfc2f21f817b8b2907ed9dcb14f9327 [^]
2017-04-24 12:02hgbotCheckin
2017-04-24 12:04hgbotNote Added: 0096119
2017-04-24 13:46caristuNote Added: 0096134
2017-04-24 13:46caristuStatusresolved => closed
2017-04-24 13:46caristuFixed in Version => 3.0PR17Q1.1

Notes
(0096101)
hgbot   
2017-04-21 13:31   
Repository: erp/backports/3.0PR17Q1.1
Changeset: 35fe280e4dfc2f21f817b8b2907ed9dcb14f9327
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Apr 21 13:30:38 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/35fe280e4dfc2f21f817b8b2907ed9dcb14f9327 [^]

Fixed issue 35806: Fields redraw instantly in grid under some circumstances

The problem was that numeric fields redraws instantly in grid view when a numeric field
was referenced by a read only logic. This reported problem was caused by the partial fix
of 0032202 regression.

The fix of 0032202 was partial because the added condition did not taken into account the
grid view properly. This problem has been resolved by take into account form and grid view.

Besides another problem was found and resolved with this fix. Since this regression was
introduced, the 0023136 issue was broken too. This problem has been resolved too with this
solution.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0096119)
hgbot   
2017-04-24 12:02   
Repository: erp/backports/3.0PR17Q1.1
Changeset: 3ccd9e68434335495a99c7d047f8684f777c545d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Apr 24 12:01:09 2017 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1.1/rev/3ccd9e68434335495a99c7d047f8684f777c545d [^]

Related with issue 35806: Codereview take into account all the cases

Now it is take into account when a parameter window with grid is opened from the menu.
Rest of the cases sucha as grid, form and parameter window from a button is working as
expected too.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0096134)
caristu   
2017-04-24 13:46   
Code reviewed + tested OK.