Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032399Openbravo ERPB. User interfacepublic2016-03-03 14:022016-03-08 10:00
ReporterJONHM 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR15Q3
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032399: cannot filter grid when it is grouped by a column
DescriptionWe cannot filter results after grouping by date in Multiphase Project view. We got some error on Chrome's debugging window:
"Uncaught TypeError: this.data.willFetchData is not a function"
"isc.OBViewGrid.addProperties.handleFilterEditorSubmit"
Steps To Reproduce1) Enter some data with dates in "Multiphase Project" view
2) Group by date column
3) Filter by some column (for example, name)

The filter doesn't work

This is reproducible for any window
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00323963.0PR16Q2 closed inigosanchez cannot filter grid when it is grouped by a column 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-03-03 17:24alostaleTypedefect => backport
2016-03-03 17:24alostaleTarget Version3.0PR16Q2 => 3.0PR16Q1
2016-03-07 15:45inigosanchezIssue Monitored: alostale
2016-03-07 15:48hgbotCheckin
2016-03-07 15:48hgbotNote Added: 0084781
2016-03-07 15:48hgbotStatusscheduled => resolved
2016-03-07 15:48hgbotResolutionopen => fixed
2016-03-07 15:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/e7f592a043260ec5da1fe3ea28e66865d1e210c1 [^]
2016-03-07 15:48inigosanchezReview Assigned To => alostale
2016-03-08 09:53alostaleAssigned Toplatform => inigosanchez
2016-03-08 10:00alostaleNote Added: 0084809
2016-03-08 10:00alostaleStatusresolved => closed
2016-03-08 10:00alostaleFixed in Version => 3.0PR16Q1

Notes
(0084781)
hgbot   
2016-03-07 15:48   
Repository: erp/backports/3.0PR16Q1
Changeset: e7f592a043260ec5da1fe3ea28e66865d1e210c1
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Mar 07 15:46:50 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/e7f592a043260ec5da1fe3ea28e66865d1e210c1 [^]

Fixes issue 32399: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not possible to apply it.
A js error was thrown: Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in "if (..... || (this.data.willFetchData(this.convertCriteria(criteria)))"
statement which incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0084809)
alostale   
2016-03-08 10:00   
code reviewed

tested:
* grouping by different fields (date, numeric, FK) filters work in grouped column as well as in other ones
* related issues (0029896 and 0031187) are still not reproducible