Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0032396Openbravo ERPB. User interfacepublic2016-03-03 14:022016-03-17 10:56
JONHM 
inigosanchez 
immediateminoralways
closedfixed 
5
 
3.0PR16Q23.0PR16Q2 
alostale
Core
Production - Confirmed Stable
2015-05-18
3.0PR15Q3
https://code.openbravo.com/erp/devel/pi/rev/2d6b8e5005b29bbca7ae4fd977ba6e18d8ac5201 [^]
No
0032396: cannot filter grid when it is grouped by a column
We cannot filter results after grouping by date in Multiphase Project view. We got some error on Chrome's debugging window:
"Uncaught TypeError: this.data.willFetchData is not a function"
"isc.OBViewGrid.addProperties.handleFilterEditorSubmit"
1) Enter some data with dates in "Multiphase Project" view
2) Group by date column
3) Filter by some column (for example, name)

The filter doesn't work

This is reproducible for any window
No tags attached.
depends on backport 00323993.0PR16Q1 closed inigosanchez cannot filter grid when it is grouped by a column 
depends on backport 00324003.0PR15Q4.5 closed inigosanchez cannot filter grid when it is grouped by a column 
depends on backport 00324013.0PR15Q3.7 closed platform cannot filter grid when it is grouped by a column 
caused by defect 0029896 closed AugustoMauch double grid request when filtering grid after scrolling to 2nd page 
Issue History
2016-03-03 14:02JONHMNew Issue
2016-03-03 14:02JONHMAssigned To => platform
2016-03-03 14:02JONHMModules => Core
2016-03-03 14:02JONHMTriggers an Emergency Pack => No
2016-03-03 17:20alostaleNote Added: 0084694
2016-03-03 17:20alostaleSeveritymajor => minor
2016-03-03 17:20alostaleStatusnew => acknowledged
2016-03-03 17:21alostaleSummaryError filtering on "Multiphase Project" view while grouping by date => cannot filter grid when it is grouped by a column
2016-03-03 17:21alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11341#r11341
2016-03-03 17:22alostaleRegression level => Production - Confirmed Stable
2016-03-03 17:22alostaleRegression introduced in release => 3.0PR15Q3
2016-03-03 17:22alostalePriorityurgent => immediate
2016-03-03 17:24alostaleStatusacknowledged => scheduled
2016-03-03 17:25alostaleAssigned Toplatform => inigosanchez
2016-03-04 08:38inigosanchezRegression date => 2015-05-18
2016-03-04 08:38inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/2d6b8e5005b29bbca7ae4fd977ba6e18d8ac5201 [^]
2016-03-04 10:52alostaleRelationship addedcaused by 0029896
2016-03-07 15:42inigosanchezIssue Monitored: alostale
2016-03-07 15:43hgbotCheckin
2016-03-07 15:43hgbotNote Added: 0084779
2016-03-07 15:43hgbotStatusscheduled => resolved
2016-03-07 15:43hgbotResolutionopen => fixed
2016-03-07 15:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/97035bb00ab31cb0d520dbb5edbe330450f5d69d [^]
2016-03-07 15:44inigosanchezNote Added: 0084780
2016-03-07 15:44inigosanchezReview Assigned To => alostale
2016-03-08 10:00alostaleNote Added: 0084808
2016-03-08 10:00alostaleStatusresolved => closed
2016-03-08 10:00alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085186

Notes
(0084694)
alostale   
2016-03-03 17:20   
Severity downgraded to minor accordingly to Reporting Guidelines [1]

[1] http://wiki.openbravo.com/wiki/QA_Processes/Defects_Severity_Priority [^]
(0084779)
hgbot   
2016-03-07 15:43   
Repository: erp/devel/pi
Changeset: 97035bb00ab31cb0d520dbb5edbe330450f5d69d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Mar 07 11:31:44 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/97035bb00ab31cb0d520dbb5edbe330450f5d69d [^]

Fixes issue 32396: cannot filter grid when it is grouped by a column.

Having a column grouped, if a filter was applied in a grid, it was not
possible to apply it.A js error was thrown:
Uncaught TypeError: this.data.willFetchData is not a function.

The problem was in:"this.data.willFetchData(....))" statement which
incorrectly assumed this.data to be an object and willFetchData a function
within it. This is not true when in this situation where this.data is a
Tree class.

It has been fixed by taking into account this case by checking that "this.data" defines the
function.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0084780)
inigosanchez   
2016-03-07 15:44   
Test case created in TestLink > Platform > Summary, Grouping and Filter > Filter > Test: Filtering does not work when a column is grouped.

See https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10005 [^]
(0084808)
alostale   
2016-03-08 10:00   
code reviewed

tested:
* grouping by different fields (date, numeric, FK) filters work in grouped column as well as in other ones
* related issues (0029896 and 0031187) are still not reproducible
(0085186)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test