Project:
View Revisions: Issue #54485 | [ Back to Issue ] | ||
Summary | 0054485: printProductLabel action is implemented with a non pure function | ||
Revision | 2024-01-29 10:51 by caristu | ||
Description | The printProductLabel action of org.openbravo.pos2.product.label.printing module is implemented with a non pure function, because the function causes side effects: it is registering a template if it is not registered yet. See here[1]. As stated in the documentation[2], actions must be implemented as pure functions. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/blame/master/web-jspack/org.openbravo.pos2.product.label.printing/src/model/messages/actions/PrintProductLabel.js#L28 [^] [2] http://wiki.openbravo.com/wiki/StateController#Design_principles_of_the_StateController [^] |
||
Revision | 2024-01-29 10:50 by caristu | ||
Description | The printProductLabel action of org.openbravo.pos2.product.label.printing module is using a non pure function, because it causes side effects: it is registering a template if it is not registered yet. See here[1]. As stated in the documentation[2], actions must be implemented as pure functions. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/blame/master/web-jspack/org.openbravo.pos2.product.label.printing/src/model/messages/actions/PrintProductLabel.js#L28 [^] [2] http://wiki.openbravo.com/wiki/StateController#Design_principles_of_the_StateController [^] |
||
Revision | 2024-01-29 10:50 by caristu | ||
Description | The printProductLabel action of org.openbravo.pos2.product.label.printing is using a non pure function, because it causes side effects: it is registering a template if it is not registered yet. See here[1]. As stated in the documentation[2], actions must be implemented as pure functions. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/blame/master/web-jspack/org.openbravo.pos2.product.label.printing/src/model/messages/actions/PrintProductLabel.js#L28 [^] [2] http://wiki.openbravo.com/wiki/StateController#Design_principles_of_the_StateController [^] |
Copyright © 2000 - 2009 MantisBT Group |