Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
| ID | ||||||||||||
| 0054485 | ||||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| defect | [POS2] POS | minor | have not tried | 2024-01-29 10:50 | 2024-01-31 11:35 | |||||||
| Reporter | caristu | View Status | public | |||||||||
| Assigned To | Retail | |||||||||||
| Priority | high | Resolution | open | Fixed in Version | ||||||||
| Status | new | Fix in branch | Fixed in SCM revision | |||||||||
| Projection | none | ETA | none | Target Version | ||||||||
| OS | Any | Database | Any | Java version | ||||||||
| OS Version | Database version | Ant version | ||||||||||
| Product Version | SCM revision | |||||||||||
| Review Assigned To | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0054485: printProductLabel action is implemented with a non pure function | |||||||||||
| Description | The printProductLabel action of org.openbravo.pos2.product.label.printing module is implemented with a non pure function, because the function causes side effects: it is registering a template if it is not registered yet. See here[1]. As stated in the documentation[2], actions must be implemented as pure functions. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/blame/master/web-jspack/org.openbravo.pos2.product.label.printing/src/model/messages/actions/PrintProductLabel.js#L28 [^] [2] http://wiki.openbravo.com/wiki/StateController#Design_principles_of_the_StateController [^] | |||||||||||
| Steps To Reproduce | . | |||||||||||
| Proposed Solution | Move the template existence and registration part to an action preparation | |||||||||||
| Tags | No tags attached. | |||||||||||
| Attached Files | ||||||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
| There are no notes attached to this issue. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-01-29 10:50 | caristu | New Issue | |
| 2024-01-29 10:50 | caristu | Assigned To | => Retail |
| 2024-01-29 10:50 | caristu | Triggers an Emergency Pack | => No |
| 2024-01-29 10:50 | caristu | Description Updated | View Revisions |
| 2024-01-29 10:51 | caristu | Summary | printProductLabel action is using a non pure function => printProductLabel action is implemented with a non pure function |
| 2024-01-29 10:51 | caristu | Description Updated | View Revisions |
| 2024-01-31 11:23 | caristu | Proposed Solution updated | |
| 2024-01-31 11:35 | caristu | Issue cloned | 0054519 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |