Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057260 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2024-11-22 13:29 | 2024-12-12 06:59 | |||
| Reporter | javietxe | View Status | public | |||||
| Assigned To | radhakrishnan | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057260: Contribution Module - cancel and replace | |||||||
| Description | When performing the cancel and replace, the contribution line is replaced by a new line (a copy of the original), BUT the related line field (line.relatedLines.orderLineId) continues pointing to the product line of the original ticket. This happens because the cancel and replace action (OBPOS2_CreateReplaceTicket) checks, before re-linking the services, whether the ticket has a check called "hasServices." With this check, several things happen (and the implemented solutions are in parentheses): -It is not set in the original ticket (we add it as a hook when adding a line with contributions). -It is not saved in the back office (nothing). - It is not retrieved when loading the remote ticket (we validate that there is a contribution line, and if there is, we load the check. This happens in a posthook of the load remote ticket action, OBPOS2_LoadRemoteTicket). The validation is: !ticket.hasServices || !line.relatedLines. If that || were a &&, it would work perfectly, but I don't know if the intention of the || is actually something else, for purposes other than contributions. It is also possible that it is simply a configuration error and can be marked so that when a contribution is added, the check is marked. This causes issues when editing the product line with the contribution, as it is incorrectly linked and cannot be found, leading to the creation of a new contribution line. | |||||||
| Steps To Reproduce | - Enter to the POS - Create an order with a line with a contribution. - Pay it - Do a cancel and replace | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0172657) jonae (developer) 2024-11-28 06:35 |
Jira - https://openbravo.atlassian.net/browse/RM-19480 [^] |
|
(0172936) hgbot (developer) 2024-12-04 07:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1827 [^] |
|
(0173203) hgbot (developer) 2024-12-12 06:59 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1827 [^] |
|
(0173204) hgbot (developer) 2024-12-12 06:59 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 845f3cd93b53801bd02a8b54d9e7506d47d59c14 Author: Radhakrishnan Seeman <r.seeman@external.orisha.com> Date: 12-12-2024 05:59:53 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/845f3cd93b53801bd02a8b54d9e7506d47d59c14 [^] Fixed ISSUE-57260: Removed service filter to update relatedLines --- M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateReplaceTicket.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-11-22 13:29 | javietxe | New Issue | |
| 2024-11-22 13:29 | javietxe | Assigned To | => Retail |
| 2024-11-22 13:29 | javietxe | Triggers an Emergency Pack | => No |
| 2024-11-22 13:30 | javietxe | Issue Monitored: javietxe | |
| 2024-11-22 13:30 | javietxe | Assigned To | Retail => Triage Omni OMS |
| 2024-11-28 06:35 | jonae | Note Added: 0172657 | |
| 2024-11-28 06:35 | jonae | Assigned To | Triage Omni OMS => radhakrishnan |
| 2024-12-04 07:45 | hgbot | Note Added: 0172936 | |
| 2024-12-12 06:59 | hgbot | Resolution | open => fixed |
| 2024-12-12 06:59 | hgbot | Status | new => closed |
| 2024-12-12 06:59 | hgbot | Note Added: 0173203 | |
| 2024-12-12 06:59 | hgbot | Fixed in Version | => RR25Q1 |
| 2024-12-12 06:59 | hgbot | Note Added: 0173204 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |