0057205: Safe box - Expected ending amount is not correcty set when counted amount not initialized with expected amount

Description

Reported in https://openbravo.atlassian.net/browse/RM-19256 [^]

REPRODUCED ON LIVEBUILDS :
Back office : https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/security/Login [^]
POS : https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBSSB1 [^]

PREREQUISITES :
YOU SHOULD USE SAFEBOX, AND HAVE ‘CASH’ PAYMENT METHOD SET TO ‘TRUE’.
YOU SHOULD USE ‘UNIQUE SAFEBOX INITIAL COUNTING’ FEATURE

ISSUE :
When the checkbox ‘Initialize counted amount with expected amount’ is set to ‘false’ on touchpoint type > payment method > cash-up, then the ending expected amount is not correc -> the expected amount does not take into account the initially counted amount.

Steps To Reproduce

Step to reproduce :

On Back-office :
- Touchpoint type > Payment method > ‘Cash’ > ‘Initialize counted amount with expected amount’ = False

On POS :
- Open a till to do the initial counting of the safe box
- Open a till AND DO NOT SELECT A SAFEBOX
- Go to the initial counting menu
- Initialise your safebox with an amount = 200€.
- Do a cash-up to close the till
- Open a till, and select the just initially counted safebox
- Do sales
- Do a cash-up to close the till
- Open a till to do the final counting (do not select a safebox)

-> The expected amount = amount of sales.
-> Counted amount = 0

- Enter the counted amount = (initialized amount+sales amount)
- Keep 200 then finish the counting
- Do a cash-up to close the till

On Back-office
- On Safebox > Safe Box Ending Count History > select your counting date
- On Safe Box Ending Count Payment Method > Expected amount = sales amount. It does not take into account the initially counted amount in the safebox, so, it’s not the expected amount => KO.

CORRECT BEHAVIOR :
If you set Touchpoint type > Payment method > ‘Cash’ > ‘Initialize counted amount with expected amount’ = True

Then, at the final counting : Expected amount = (initialized amount+sales amount) => OK.

=> Which is OK.

Proposed Solution

Whatever the value of the parameter ‘Initialize counted amount with expected amount’ (TRUE/FALSE), the expected amount should not be different.

It should always be the initially counted amount + all cash movements during the day (like when currently the parameter is set to TRUE).

Issue History
Date Modified	Username	Field	Change
2024-11-20 11:56	migueldejuana	Type	defect => backport
2024-11-20 11:56	migueldejuana	Target Version	=> 24Q2.5
2024-11-29 12:55	migueldejuana	Assigned To	Retail => gorka_gil
2024-12-02 16:18	gorka_gil	Note Added: 0172910
2024-12-02 16:18	gorka_gil	Status	scheduled => closed
2024-12-02 16:18	gorka_gil	Resolution	open => fixed

Notes
(0172910) gorka_gil (administrator) 2024-12-02 16:18	Fixed by this jira: https://openbravo.atlassian.net/browse/RM-17977 [^] [^]