Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0056783
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2024-10-15 11:302024-12-02 16:17
ReportermigueldejuanaView Statuspublic 
Assigned ToSABARINATH P 
PrioritynormalResolutionfixedFixed in Version25Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Togorka_gil
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056783: Incorrect starting cash amount when using safe box functionality in the POS

DescriptionWe are not taking into account the initial Counted amount for Safe Boxes
Steps To ReproduceLog in into a terminal that can use safe boxes (VBSSB2) with vallblanca user

Select one free safe box

In the initial count step choose that you are starting with 100€ the day

After being logged in into the POS go to Cash Management window

See that it shows 0€ as starting cash, a totally wrong amount that would always make the user have incorrect amount on the POS.
Proposed SolutionTry to implement it in the same way of regular payments. We should put in Starting the expected amount for the Safebox payment. In case there is difference, we should create a cash management with the difference and the total should match.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0057201 closedgorka_gil Safe box - Expected ending amount is not correcty set when counted amount not initialized with expected amount 
depends on backport 005735024Q4.1 scheduledSABARINATH P Incorrect starting cash amount when using safe box functionality in the POS 
depends on backport 005735124Q3.3 scheduledSABARINATH P Incorrect starting cash amount when using safe box functionality in the POS 
depends on backport 005735224Q2.5 scheduledSABARINATH P Incorrect starting cash amount when using safe box functionality in the POS 
related to defect 0056876 closedmigueldejuana POS 2 - Cash Management - It's possible to do a withdrawal > total amount available 
blocks feature request 0057212 scheduledprakashmurugesan88 Initial count: share logic safebox and no safebox 
Not all the children of this issue are yet resolved or closed.

-  Notes
(0170804)
migueldejuana (developer)
2024-10-23 09:11

Linked JIRA: https://openbravo.atlassian.net/browse/RM-17977 [^]
(0171721)
hgbot (developer)
2024-11-09 15:06

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3080 [^]
(0172641)
hgbot (developer)
2024-11-27 15:31

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1810 [^]
(0172646)
hgbot (developer)
2024-11-27 17:28

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1810 [^]
(0172647)
hgbot (developer)
2024-11-27 17:28

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a0445e09bdcbca2e4d7a39c00d6686c3d74d0de6
Author: Gorka Gil <go.gil@orisha.com>
Date: 27-11-2024 15:39:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a0445e09bdcbca2e4d7a39c00d6686c3d74d0de6 [^]

Fixed ISSUE-56783: create cashmanagement event on initial count difference of a safebox

* so in the count, we should ignore the differences and don't create any transaction of differences

---
M src/org/openbravo/retail/posterminal/CountSafeBoxProcessor.java
---
(0172648)
hgbot (developer)
2024-11-27 17:31

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3080 [^]
(0172649)
hgbot (developer)
2024-11-27 17:31

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 193d033df6e6988892aac03c262d0262e19a7bdf
Author: Sabarinath <s.palanisamy@external.orisha.com>
Date: 27-11-2024 16:28:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/193d033df6e6988892aac03c262d0262e19a7bdf [^]

Fixed ISSUE-56783: Included safebox initial count in cashmanagement.

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSafeboxInitialCountCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/PreparePayloadForFinishInitialCount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SynchronizeInitialCountSafeBox.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/__test__/PreparePayloadForFinishInitialCount.test.js
---
(0172650)
hgbot (developer)
2024-11-27 17:31

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b944edb9e2e2b0c3e5e6c45094be7cb3fcb58d41
Author: Gorka Gil <go.gil@orisha.com>
Date: 27-11-2024 16:28:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b944edb9e2e2b0c3e5e6c45094be7cb3fcb58d41 [^]

Fixed ISSUE-56783: create a cashmanagement of differences

* call to setInitialCountCashup instead create a new code for safeboxes
* fix that safebox can contain many payment methods

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/PreparePayloadForFinishInitialCount.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SynchronizeInitialCountSafeBox.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/__test__/PreparePayloadForFinishInitialCount.test.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SetSafeboxInitialCountCashup.js
---
(0172733)
hgbot (developer)
2024-11-28 17:47

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3170 [^]
(0172904)
hgbot (developer)
2024-12-02 15:02

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c8a42745a941bbcaec1fb1eabc085860d1e34956
Author: Gorka Gil <go.gil@orisha.com>
Date: 02-12-2024 13:58:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c8a42745a941bbcaec1fb1eabc085860d1e34956 [^]

Fixes ISSUE-56783: Fix safe box starting cash when initial count cash is not set

* fix when no initial count, to also set the safebox initial acount

---
A web-jspack/org.openbravo.pos2/src/model/cashup/actions/UpdateSafeboxStartingCash.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/model/cashup/CashupExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/SynchronizeInitialCountSafeBox.js
---
(0172905)
hgbot (developer)
2024-12-02 15:02

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e0af2ed9c0548b3024e9daa97a5d7829e9058453
Author: Gorka Gil <go.gil@orisha.com>
Date: 02-12-2024 13:58:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e0af2ed9c0548b3024e9daa97a5d7829e9058453 [^]

Fixes ISSUE-56783: Small fixes and tests

* fix the import of ob and make code not fail when when paymentMethod not found in terminal payments
* Fix selectDrawerStep tests
* Add new test for UpdateSafeboxStartingCash

---
A web-jspack/org.openbravo.pos2/src/model/cashup/actions/__test__/UpdateSafeboxStartingCash.test.js
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/__test__/SelectDrawerStep.test.jsx
M web-jspack/org.openbravo.pos2/src/model/cashup/actions/UpdateSafeboxStartingCash.js
---
(0172906)
hgbot (developer)
2024-12-02 15:02

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3170 [^]

- Issue History
Date Modified Username Field Change
2024-10-15 11:30 migueldejuana New Issue
2024-10-15 11:30 migueldejuana Assigned To => migueldejuana
2024-10-15 11:30 migueldejuana Triggers an Emergency Pack => No
2024-10-15 14:02 migueldejuana Assigned To migueldejuana => SABARINATH P
2024-10-15 14:03 migueldejuana Proposed Solution updated
2024-10-15 18:10 SABARINATH P Status new => scheduled
2024-10-23 09:11 migueldejuana Note Added: 0170804
2024-11-09 15:06 hgbot Note Added: 0171721
2024-11-20 11:53 guillermogil Relationship added related to 0057201
2024-11-20 16:25 gorka_gil Relationship added blocks 0057212
2024-11-27 15:31 hgbot Note Added: 0172641
2024-11-27 16:05 javietxe Relationship added related to 0056876
2024-11-27 17:28 hgbot Note Added: 0172646
2024-11-27 17:28 hgbot Resolution open => fixed
2024-11-27 17:28 hgbot Status scheduled => closed
2024-11-27 17:28 hgbot Fixed in Version => RR25Q1
2024-11-27 17:28 hgbot Note Added: 0172647
2024-11-27 17:31 hgbot Note Added: 0172648
2024-11-27 17:31 hgbot Fixed in Version RR25Q1 => 25Q1
2024-11-27 17:31 hgbot Note Added: 0172649
2024-11-27 17:31 hgbot Note Added: 0172650
2024-11-28 17:47 hgbot Note Added: 0172733
2024-12-02 15:02 hgbot Note Added: 0172904
2024-12-02 15:02 hgbot Note Added: 0172905
2024-12-02 15:02 hgbot Note Added: 0172906
2024-12-02 16:16 gorka_gil Status closed => new
2024-12-02 16:16 gorka_gil Resolution fixed => open
2024-12-02 16:16 gorka_gil Fixed in Version 25Q1 =>
2024-12-02 16:16 gorka_gil Status new => scheduled
2024-12-02 16:17 gorka_gil Status scheduled => resolved
2024-12-02 16:17 gorka_gil Resolution open => fixed
2024-12-02 16:17 gorka_gil Review Assigned To => gorka_gil
2024-12-02 16:17 gorka_gil Status resolved => closed
2024-12-02 16:17 gorka_gil Fixed in Version => 25Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker