Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0055377
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo Localizations] Localization Italycriticalalways2024-04-30 15:462024-05-09 06:42
ReporteregoitzView Statuspublic 
Assigned Tokousalya_r 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Regression introduced in release
Summary

0055377: XML invoices can be sent to the Authorities without fiscal code

DescriptionThe process "Export Italy Invoices to a XML file" does not check if the business partner for Italy has a taxid or em_mdita_taxid. (depending on the customer type)

If the value is null or empty the XML generated is not valid, and it is not legal to sent to the authorities.

Steps To Reproduce- Execute the process for a business partner without taxid.
Proposed Solution- Easier way is to not consider the invoice if the partner has not bueinss partner, but identifying later the pending invoices could be a problem.

- It is better to get the invoice as pending to be sent but if the taxid or em_mdita_taxid is null, don't generate the invoice and put a specific error on the c_invoice.einvoice_status field. Smomething like BP_NOT_TAX.

Then identifying the failed invoices will be easier using a alert.

A way to regenarate the XML file and send it later will be required. (create or document)
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0163967)
psanjuan (manager)
2024-04-30 17:27
edited on: 2024-04-30 18:04

First thing to research on this issue is why customer data (Tax ID) is being removed. That should NOT be the case. CSU team will work on researching why this is happening with the customer. Openbravo is NOT the owner of customer data.

Besides this we need to check below two topics (reproduced in Dev enviroment, we need to check also what is happening in pre-prod or production):

1.- As it seems it is now possible to create an Invoice via Norauto API for a customer who does not have either a Partita IVA (Tax ID) or Codice Fiscale. That should NOT be the case. Partita IVA should be mandatory for Invoice issuance. If there is also a Codice Fiscale, that one can also be added.

2.- If the Business Partner does not have a Partita IVA (Tax ID) it should not be possible to create the XML (e-invoice). The e-invoice process should give an error in those cases. As it seems this is not happening now. XML are generated without the nodes:
1.4.1.1.1 <IdPaese>
1.4.1.1.2 <IdCodice> (Tax ID)

For addtional information, review e-invoice Functional Specification

https://docs.google.com/document/d/1Za1KJsTSxVrOjJBcAT7MG5nU1OEkHvpXM28SjDAD1Ws/edit [^]

Example:

<CessionarioCommittente>

            <DatiAnagrafici>

                <IdFiscaleIVA>

                    <IdPaese>IT</IdPaese>

                    <IdCodice>01321430322</IdCodice>

                </IdFiscaleIVA>

Please focus on providing a fix for topic 2 above, first.
In any case if we fix this the XML will not be generated because the data is not the proper one.

(0163979)
aferraz (developer)
2024-05-02 09:39

Jira: https://openbravo.atlassian.net/browse/RM-13657 [^]
(0164305)
hgbot (developer)
2024-05-08 07:58

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/39 [^]
(0164346)
hgbot (developer)
2024-05-09 06:42

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/merge_requests/39 [^]
(0164347)
hgbot (developer)
2024-05-09 06:42

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice [^]
Changeset: 41d27a4be256fc546a5221c65103e61b429bf448
Author: Kousalya Ramasamy <kousalya.ramasamy@openbravo.com>
Date: 09-05-2024 04:42:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.localization.italy.einvoice/-/commit/41d27a4be256fc546a5221c65103e61b429bf448 [^]

Fixes ISSUE-55377: Validation added for taxId and codiceFiscale

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/localization/italy/einvoice/xmlengine/document/ItalyDatiAnagraficiCessionario.java
---

- Issue History
Date Modified Username Field Change
2024-04-30 15:46 egoitz New Issue
2024-04-30 15:46 egoitz Assigned To => psanjuan
2024-04-30 17:27 psanjuan Note Added: 0163967
2024-04-30 17:29 psanjuan Note Edited: 0163967 View Revisions
2024-04-30 17:30 psanjuan Assigned To psanjuan => aferraz
2024-04-30 17:32 psanjuan Note Edited: 0163967 View Revisions
2024-04-30 17:58 psanjuan Note Edited: 0163967 View Revisions
2024-04-30 18:02 psanjuan Note Edited: 0163967 View Revisions
2024-04-30 18:04 psanjuan Note Edited: 0163967 View Revisions
2024-05-02 09:39 aferraz Note Added: 0163979
2024-05-02 09:51 aferraz Assigned To aferraz => kousalya_r
2024-05-08 07:58 hgbot Note Added: 0164305
2024-05-09 06:42 hgbot Note Added: 0164346
2024-05-09 06:42 hgbot Resolution open => fixed
2024-05-09 06:42 hgbot Status new => closed
2024-05-09 06:42 hgbot Note Added: 0164347


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker