0055215: Keymap goes to EWI if the product doesn't exist in obpos2_keymap_product and the JSON doesn't include the product property

Notes
(0163316) malsasua (developer) 2024-04-17 11:09 edited on: 2024-04-17 11:10	The error shown is raised in the following code (modules/org.openbravo.pos2/src/org/openbravo/pos2/KeymapLoader.java): private void checkMandatoryFields(String fields[], JSONObject json, String objectIdentifier) throws JSONException { for (String field : fields) { if (!json.has(field) \|\| "null".equals(json.getString(field))) { String errorMessage = objectIdentifier + " " + field + " is a mandatory field to create a new " + objectIdentifier + " from Web Pos"; log.error(errorMessage); throw new OBException(errorMessage); } } } It is launched in the createEntity function that is only launched from the processEntity function when the obpos2_keymap_product doesn't exist. private void processEntity(Class<? extends BaseOBObject> type, JSONArray jsonEntities, String[] mandatoryFields, Map<String, String> uniqueProperties) throws JSONException { JSONArray filteredEntities = filterNotDeletedObjects(jsonEntities); deleteObjectsIfRequired(type, jsonEntities); for (int i = 0; i < filteredEntities.length(); i++) { JSONObject jsonEntityObject = filteredEntities.getJSONObject(i); BaseOBObject entityInstance = getEntityInstance(type, jsonEntityObject.optString("id", null)); if (entityInstance == null) { BaseOBObject equivalentInstance = getEquivalentInstance(type, jsonEntityObject, uniqueProperties); if (equivalentInstance == null) { createEntity(type, jsonEntityObject, mandatoryFields); } else { updateEntity(type, equivalentInstance, jsonEntityObject); } } else { updateEntity(type, entityInstance, jsonEntityObject); } } } This is why all the Keymaps are not failing. In this case, when the entity doesn't exist, it looks for the following mandatory fields: if (json.has("keymapProducts")) { processEntity(OBPOS2KeymapProduct.class, json.getJSONArray("keymapProducts"), KEYMAP_PRODUCT_MANDATORY_FIELDS); } public static final String[] KEYMAP_PRODUCT_MANDATORY_FIELDS = { "id", "organization", "name", "status", "product" }; It is looking for the product property and it doesn't exist. We checked if any of the records in keymapProducts property didn't exist in the backoffice and we found one: { "id": "...", "image": null, "organization": "0", "priority": 0, "useProductImg": true, "keymapCategoryId": "...", "productId": "...", "name": "...", "status": "A", "startingDate": null, "endingDate": null, "isButtonMandatory": false, "active": true } Although we added the "product" property to that section, it failed with a NPE in the following piece of code (modules/org.openbravo.pos2/src/org/openbravo/pos2/event/OBPOS2KeymapCategoryIsExtensibleEventHandler.java): OBPOS2KeymapProduct keymapProduct = (OBPOS2KeymapProduct) event.getTargetInstance(); OBPOS2KeymapCategory keymapCategory = keymapProduct.getOBPOS2KeymapCategory(); Boolean canCreateProduct = keymapCategory.isStoresAllowedToAddNewProducts(); It is because the keymapCategory is null.

Issue History
Date Modified	Username	Field	Change
2024-04-17 11:08	malsasua	New Issue
2024-04-17 11:08	malsasua	Assigned To	=> Retail
2024-04-17 11:08	malsasua	File Added: TerminalLogCDSKeymap.csv
2024-04-17 11:08	malsasua	Triggers an Emergency Pack	=> No
2024-04-17 11:09	malsasua	Note Added: 0163316
2024-04-17 11:09	ngarcia	Issue Monitored: ngarcia
2024-04-17 11:10	ngarcia	Note Edited: 0163316	View Revisions
2024-04-23 09:18	guilleaer	Status	new => acknowledged
2024-04-29 09:38	sreehari	Assigned To	Retail => sreehari
2024-04-29 09:38	sreehari	Status	acknowledged => scheduled

Relationships [ Relation Graph ] [ Dependency Graph ]