Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055187 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Events for Client | minor | have not tried | 2024-04-12 14:33 | 2024-04-17 09:51 | |||
| Reporter | jonae | View Status | public | |||||
| Assigned To | jonae | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055187: Avalara Connector - trigger Avalara commit based on the creation of simplified invoice | |||||||
| Description | The data to be sent to Avalara will be the same as currently, but the trigger of the transaction commit into Avalara (if the parameter “Commit Openbravo Documents“ is enabled) will be based on the creation of a simplified invoice or an Invoice. Simplified Invoice are created at sales time, if the parameter “Generate Simplified Invoice” is selected. This parameter is located in channel touchpoint type. Invoices are created at sales time, if the seller uses the feature “Issue Invoice”. So the commit will be executed only at sales time and as described below, if the parameter “Commit Openbravo Documents =Y”: an order is created in the POS at checkout we call Avalara to retrieve the sales taxes. After payment, and only in the case when an Invoice “Simplified Invoice” or “Full Invoice” properties are not null, because any of those has been created, we commit that transaction into Avalara We need to take into account that: Openbravo documents will not be committed in Avalara regardless of the “Commit Openbravo Documents” = Yes, if the “Generate Aggregated Invoice” parameter is enabled. This parameter is automatically selected, if the parameter “Generate Simplified Invoice” is not selected. If “Generate Aggregated Invoice” is selected, aggregated invoices are created for all sales/return at cash up. This type of aggregated invoices must not be sent to Avalara in any case. Openbravo will support the import of legacy information import as well as Corners (so such transactions are not committed once again in Avalara) by implementing this new capability in the Avalara connector. | |||||||
| Steps To Reproduce | The data to be sent to Avalara will be the same as currently, but the trigger of the transaction commit into Avalara (if the parameter “Commit Openbravo Documents“ is enabled) will be based on the creation of a simplified invoice or an Invoice. Simplified Invoice are created at sales time, if the parameter “Generate Simplified Invoice” is selected. This parameter is located in channel touchpoint type. Invoices are created at sales time, if the seller uses the feature “Issue Invoice”. So the commit will be executed only at sales time and as described below, if the parameter “Commit Openbravo Documents =Y”: an order is created in the POS at checkout we call Avalara to retrieve the sales taxes. After payment, and only in the case when an Invoice “Simplified Invoice” or “Full Invoice” properties are not null, because any of those has been created, we commit that transaction into Avalara We need to take into account that: Openbravo documents will not be committed in Avalara regardless of the “Commit Openbravo Documents” = Yes, if the “Generate Aggregated Invoice” parameter is enabled. This parameter is automatically selected, if the parameter “Generate Simplified Invoice” is not selected. If “Generate Aggregated Invoice” is selected, aggregated invoices are created for all sales/return at cash up. This type of aggregated invoices must not be sent to Avalara in any case. Openbravo will support the import of legacy information import as well as Corners (so such transactions are not committed once again in Avalara) by implementing this new capability in the Avalara connector. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0163157) hgbot (developer) 2024-04-12 14:36 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/10 [^] |
|
(0163308) hgbot (developer) 2024-04-17 09:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector [^] Changeset: 1d6c6e3e87de9f8f8e03fe8b6ae0164dbf82aade Author: Jon Alegría <jon.alegria@openbravo.com> Date: 17-04-2024 07:51:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/commit/1d6c6e3e87de9f8f8e03fe8b6ae0164dbf82aade [^] Fixes ISSUE-55187: The commit to the avalara portal will be done only in case the invoice, full or simplified, is generated --- M src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java M src/org/openbravo/retail/avalaraconnector/hooks/CancelLayawayHook.java M src/org/openbravo/retail/avalaraconnector/hooks/SendEDLRequestHook.java M src/org/openbravo/retail/avalaraconnector/hooks/VoidLayawayHook.java M src/org/openbravo/retail/avalaraconnector/utils/OBAVCO_Utility.java --- |
|
(0163309) hgbot (developer) 2024-04-17 09:51 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/10 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-04-12 14:33 | jonae | New Issue | |
| 2024-04-12 14:33 | jonae | Assigned To | => jonae |
| 2024-04-12 14:33 | jonae | Triggers an Emergency Pack | => No |
| 2024-04-12 14:36 | hgbot | Note Added: 0163157 | |
| 2024-04-17 09:51 | hgbot | Resolution | open => fixed |
| 2024-04-17 09:51 | hgbot | Status | new => closed |
| 2024-04-17 09:51 | hgbot | Note Added: 0163308 | |
| 2024-04-17 09:51 | hgbot | Note Added: 0163309 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |