Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0055132 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [POS2] POS | major | have not tried | 2024-04-08 19:02 | 2024-04-10 16:46 | |||
Reporter | ablasco | View Status | public | |||||
Assigned To | ablasco | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 24Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | 24Q2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c34cab696709f30c58492b9f06a2c4e2d0d4756a [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0055132: ClassName breaks alignment CSS rule in StandardButton component | |||||||
Description | Development in state-based badges in BaseContent caused a regression in alignment inside StandardButtons due to a hidden space in className definition inside conditional variantClass. This additional space creates is misinterpreted CSS rule in standardbutton when stateBasedContent attribute is false. variantClass={`obc2StandardButton-content ${ stateBasedContent ? 'obc2StandardButton-fab' : ''}`} | |||||||
Steps To Reproduce | Giftcards module is required to see the changes. - Select a customer or create a new one. - Click on Restaurant-> "Gift card/Credit notes /Gift certificates" from DrawerMenu. - Click on Create Certificate. - Create a new Certificate. - Search the certificate created, associated with the customer. - Click on the eye on the right side. The Refund button is misaligned at the bottom on the dialog. | |||||||
Proposed Solution | variantClass={`${ stateBasedContent ? 'obc2StandardButton-content obc2StandardButton-fab' : 'obc2StandardButton-content' }`} | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0163059) hgbot (developer) 2024-04-10 15:55 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1450 [^] |
(0163063) hgbot (developer) 2024-04-10 16:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 3ff12465467b0de456f7de7f69de1d6b549f5668 Author: adrian.blasco <adrian.blasco@openbravo.com> Date: 10-04-2024 15:53:50 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3ff12465467b0de456f7de7f69de1d6b549f5668 [^] Fixes ISSUE-55132: ClassName in StandardButton should not add hidden space in order to apply CSS alignment rule correctly [ClassName StandardButton] BaseButton variantClass apply _simple and _full suffix in order to specify each variant in CSS rules --- M web-jspack/org.openbravo.core2/src/components/BaseContent/BaseContent.jsx M web-jspack/org.openbravo.core2/src/components/StandardButton/StandardButton.jsx --- |
(0163064) hgbot (developer) 2024-04-10 16:46 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1450 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2024-04-09 09:19 | guilleaer | Type | defect => backport |
2024-04-09 09:19 | guilleaer | Target Version | => 24Q2 |
2024-04-10 15:55 | hgbot | Note Added: 0163059 | |
2024-04-10 16:46 | hgbot | Resolution | open => fixed |
2024-04-10 16:46 | hgbot | Status | scheduled => closed |
2024-04-10 16:46 | hgbot | Fixed in Version | => 24Q2 |
2024-04-10 16:46 | hgbot | Note Added: 0163063 | |
2024-04-10 16:46 | hgbot | Note Added: 0163064 |
Copyright © 2000 - 2009 MantisBT Group |