Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054882 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | major | always | 2024-03-07 16:26 | 2024-04-15 09:19 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR24Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | diffs?commit | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054882: Fields related to sqllogic columns are force to be read only | |||||||
| Description | When a column is defined with a SQL Logic, the associated field is always force to be read only. However, for P&E windows, it might be needed to allow editing this field, as it might be sent as input parameter to the handler in the server. | |||||||
| Steps To Reproduce | To be able to reproduce the issue, apply the attached 54882_reproducer.diff or: As System Admin: Create a dummy column "M_Warehouse_ID" (Tabledir) in M_Storage_Detail table with sql logic = select max(l.m_warehouse_id) from m_locator l Go to Window, Tabs and fields and find the "Box Handling Unit P&E". Go to tab, then fields Add a new field for the new column. Make sure it's shown in grid and is not set as read only. Then: Run ant smartbuild Go to Handling unit window, create a new record and press the Box button. In the grid see the field is displayed, but it can't be edited. This is wrong, the user should be able to change the value if the field is not readonly | |||||||
| Proposed Solution | Attached a patch that works for me. Please check other scenarios. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  54882-proposed-solution.diff [^] (1,248 bytes) 2024-03-07 16:30 [Show Content]
54882_reproducer.diff [^] (8,217 bytes) 2024-04-08 12:02 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0162917) hgbot (developer) 2024-04-08 12:07 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1184 [^] |
|
(0163174) hgbot (developer) 2024-04-15 09:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 30837829452d7fee1fdc6615238a89f116308323 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 12-04-2024 15:07:22 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/30837829452d7fee1fdc6615238a89f116308323 [^] Fixes ISSUE-54882: Computed columns are not necessarily read only in P&E grids Computed columns should be read only in standard grids, because it does not make sense to change their value in the source table, as the value is autocalculated. In Pick and Execute window it could make sense to edit them, and use the computed column sql logic as a sort of default value --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java --- |
|
(0163175) hgbot (developer) 2024-04-15 09:19 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1184 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-03-07 16:26 | vmromanos | New Issue | |
| 2024-03-07 16:26 | vmromanos | Assigned To | => Triage Platform Base |
| 2024-03-07 16:26 | vmromanos | Modules | => Core |
| 2024-03-07 16:26 | vmromanos | Triggers an Emergency Pack | => No |
| 2024-03-07 16:30 | vmromanos | File Added: 54882-proposed-solution.diff | |
| 2024-03-12 17:38 | vmromanos | Relationship added | blocks 0054667 |
| 2024-03-21 23:19 | AugustoMauch | Status | new => acknowledged |
| 2024-04-08 08:44 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2024-04-08 12:02 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2024-04-08 12:02 | AugustoMauch | File Added: 54882_reproducer.diff | |
| 2024-04-08 12:04 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2024-04-08 12:07 | hgbot | Note Added: 0162917 | |
| 2024-04-08 12:09 | AugustoMauch | Status | acknowledged => scheduled |
| 2024-04-08 12:10 | AugustoMauch | Status | scheduled => resolved |
| 2024-04-08 12:10 | AugustoMauch | Fixed in SCM revision | => https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1184/diffs?commit_id=9407d8a3ec4ea7990125573a44980816e1a487ed [^] |
| 2024-04-08 12:10 | AugustoMauch | Resolution | open => fixed |
| 2024-04-15 09:19 | hgbot | Status | resolved => closed |
| 2024-04-15 09:19 | hgbot | Fixed in Version | => PR24Q3 |
| 2024-04-15 09:19 | hgbot | Note Added: 0163174 | |
| 2024-04-15 09:19 | hgbot | Note Added: 0163175 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |