0054654: ExternalOrderLoader should also look by the search key when trying to find a tax rate

Description

ExternalOrderLoader should also look by the search key when trying to find a tax rate. Currently it is looking for:

id
Name
Tax Search Key (hidden field of 5 char)

Steps To Reproduce

Change the name of the Entregas IVA 21% tax rate, but leave the search key as it is (Entregas IVA 21%)
Import an order through the External Order Loader with the "Entregas IVA 21%" tax rate
Check the following error is returned:

"error": {
        "message": "Value Entregas IVA 21% does not resolve to an instance of FinancialMgmtTaxRate",
        "messageType": "Error",
        "title": ""
    },
    "totalRows": 0
}

Proposed Solution

In transformTaxes function of ExternalOrderLoader, add the value as a property to look for. Something such as

final String taxId = resolveJsonValue(TaxRate.ENTITY_NAME, name,
new String[] { "id", "name", "taxSearchKey", "value" });

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0054577

closed

Rajesh_18

ExternalOrderLoader should also look by the search key when trying to find a tax rate

Notes
(0160682) hgbot (developer) 2024-02-13 11:42	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1471 [^]

(0160683) hgbot (developer) 2024-02-13 12:19	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1471 [^]

(0160684) hgbot (developer) 2024-02-13 12:19	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: db8d71325279f744d0b008f7502921e99f639eb4 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 13-02-2024 10:42:45 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/db8d71325279f744d0b008f7502921e99f639eb4 [^] Fixed ISSUE-54654: Added Tax searchKey property while finding taxes --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2024-02-13 11:23	marvintm	Type	defect => backport
2024-02-13 11:23	marvintm	Target Version	=> RR24Q1.1
2024-02-13 11:42	hgbot	Note Added: 0160682
2024-02-13 12:19	hgbot	Resolution	open => fixed
2024-02-13 12:19	hgbot	Status	scheduled => closed
2024-02-13 12:19	hgbot	Note Added: 0160683
2024-02-13 12:19	hgbot	Fixed in Version	=> RR24Q1
2024-02-13 12:19	hgbot	Note Added: 0160684