Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054618
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Retail APImajoralways2024-02-08 10:412024-04-12 10:14
ReporterwicherrView Statuspublic 
Assigned ToTriage Omni OMS 
PrioritynormalResolutionfixedFixed in VersionRR24Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054618: [US] The import of historical ticket is wrong because of the import of ticket and line taxes

DescriptionTrying to import the ticket in "Step to reproduce" the tax tabs (ticket level and line level) contain 1 line instead of 3 probably because we use the same dummy tax for all of them.

Trying to create this same ticket from POS works.
Steps To ReproduceThe organization should be located in US and use AVALARA with the configuration expected for this kind of organization (dummy tax + price list without tax included...)



Import a ticket like :

{
    "messageId": "D05600/20240117016",
    "posTerminal": "D05600",
    "channel": "External",
    "data": [
        {
            "id": "D05600/2024011706",
            "documentNo": "D05600/2024011706",
            "orderReference": "422024011706",
            "smcpcfWebordertype": "Click and collect",
            "orderDate": "2024-01-17T11:55:46.000Z",
            "invoiceTerms": "I",
            "currency": "EUR",
            "step": "all",
            "grossAmount": 157.87,
            "netAmount": 145.00,
            "businessPartner": "D056 - Client",
            //"externalBusinessPartnerReference": "D0561002917",
            "printed": "true",
            "lines": [
                {
                    "product": "3607171804993",
                    "qty": 1,
                    "grossAmount": 157.87,
                    "netAmount": 145.00,
                    "taxAmount": 12.87,
                    "grossListPrice": 145,
                    "baseGrossUnitPrice": 145,
                    "priceIncludesTaxes": false,
                    "taxLines": {
                        "Preliminary Tax US": {
                            "rate": 4,
                            "netAmount": 145.00,
                            "taxAmount": 5.80,
                            "ctaxesExternalTaxName": "NY STATE TAX",
                            "ctaxesExternalTaxRate": 4
                        },
                        "Preliminary Tax US": {
                            "rate": 4.5,
                            "netAmount": 145.00,
                            "taxAmount": 6.53,
                            "ctaxesExternalTaxName": "NY CITY TAX",
                            "ctaxesExternalTaxRate": 4.5
                        },
                        "Preliminary Tax US": {
                            "rate": 0.38,
                            "netAmount": 145.00,
                            "taxAmount": 0.54,
                            "ctaxesExternalTaxName": "NY SPECIAL TAX",
                            "ctaxesExternalTaxRate": 0.38
                        }
                    }
                }
            ],
            "payments": [
                {
                    "paidAmount": 157.87,
                    "kind": "OBPOS_payment.cash",
                    "isocode": "EUR"
                }
            ],
            "taxes": {
                "Preliminary Tax US": {
                    "rate": 4,
                    "netAmount": 145.00,
                    "taxAmount": 5.80,
                    "ctaxesExternalTaxName": "NY STATE TAX",
                    "ctaxesExternalTaxRate": 4
                },
                "Preliminary Tax US": {
                    "rate": 4.5,
                    "netAmount": 145.00,
                    "taxAmount": 6.53,
                    "ctaxesExternalTaxName": "NY CITY TAX",
                    "ctaxesExternalTaxRate": 4.5
                },
                "Preliminary Tax US": {
                    "rate": 0.38,
                    "netAmount": 145.00,
                    "taxAmount": 0.54,
                    "ctaxesExternalTaxName": "NY SPECIAL TAX",
                    "ctaxesExternalTaxRate": 0.38
                }
            }
        }
    ]
}
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0161911)
hgbot (developer)
2024-03-08 15:25

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1501 [^]
(0162535)
hgbot (developer)
2024-03-22 09:29

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a45e20e00cc832fc53b49fcf20fc532bd54635f7
Author: Ram Prakash <ram.prakash@openbravo.com>
Date: 22-03-2024 08:29:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a45e20e00cc832fc53b49fcf20fc532bd54635f7 [^]

Fixes ISSUE-54618: Updated EOL logic to support same taxes in ticket

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0162536)
hgbot (developer)
2024-03-22 09:29

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1501 [^]
(0162552)
hgbot (developer)
2024-03-22 13:27

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2a74c1cbfed85f864526a71033ee606d2bc684b6
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 22-03-2024 13:26:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2a74c1cbfed85f864526a71033ee606d2bc684b6 [^]

Revert "Fixes ISSUE-54618: Updated EOL logic to support same taxes in ticket"

This reverts commit a45e20e00cc832fc53b49fcf20fc532bd54635f7.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0162919)
hgbot (developer)
2024-04-08 13:17

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1525 [^]
(0163130)
hgbot (developer)
2024-04-12 10:14

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1525 [^]
(0163131)
hgbot (developer)
2024-04-12 10:14

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1fe871db0caa1b8cbb78b6d9ec31a6ac69c1f4ce
Author: Ram Prakash <ram.prakash@openbravo.com>
Date: 12-04-2024 08:14:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1fe871db0caa1b8cbb78b6d9ec31a6ac69c1f4ce [^]

Fixes ISSUE-54618: Updated EOL logic to support same taxes in ticket

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---

- Issue History
Date Modified Username Field Change
2024-02-08 10:41 wicherr New Issue
2024-02-08 10:41 wicherr Assigned To => Triage Platform Conn
2024-02-08 10:41 wicherr Triggers an Emergency Pack => No
2024-02-08 14:04 adrianromero Assigned To Triage Platform Conn => Triage Omni OMS
2024-03-08 15:25 hgbot Note Added: 0161911
2024-03-22 09:29 hgbot Resolution open => fixed
2024-03-22 09:29 hgbot Status new => closed
2024-03-22 09:29 hgbot Fixed in Version => RR24Q2
2024-03-22 09:29 hgbot Note Added: 0162535
2024-03-22 09:29 hgbot Note Added: 0162536
2024-03-22 13:27 hgbot Note Added: 0162552
2024-03-25 10:56 aferraz Type defect => feature request
2024-03-25 10:56 aferraz Status closed => new
2024-03-25 10:56 aferraz Resolution fixed => open
2024-03-25 10:56 aferraz Fixed in Version RR24Q2 =>
2024-04-08 13:17 hgbot Note Added: 0162919
2024-04-12 10:14 hgbot Note Added: 0163130
2024-04-12 10:14 hgbot Resolution open => fixed
2024-04-12 10:14 hgbot Status new => closed
2024-04-12 10:14 hgbot Fixed in Version => RR24Q3
2024-04-12 10:14 hgbot Note Added: 0163131

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker