Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0054297

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

major

always

2024-01-10 16:27

2024-01-12 11:17

Reporter

Lcazaux

View Status

public

Assigned To

sreehari

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0054297: Approval pop up displayed for SetBusinessDate still wrong after test

Description

We previously logged a mantis (linked to this one), but after doing some tests, we still have the approval asked when there is no Business Date to enter.

Steps To Reproduce

Go to livebuild BO
- Configure "set business date" user action to = approval required on your test user
- And to "Can Use and approve" to an admin user
- Go to the POS and do a refresh masterdata
- Log out and close all of the tills
- Close the store
- Log in, a business date is to be set --> an approval is displayed --> OK
- Close the till but don't close the store (store is open but till is closed)
- Log in --> no business date is to be set yet an approval is still displayed --> KO

Proposed Solution

The approval shoudl only appear when the business date window appears and the user has to choose a business date to open the till, meaning, at the opening of the store (when all the tills of the store were previously closed and the store was also indicated as "status = closed")

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

Approval pop up displayed for SetBusinessDate when not needed

Notes
(0159245) hgbot (developer) 2024-01-12 09:31	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/105 [^]

(0159253) hgbot (developer) 2024-01-12 11:17	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: 7a0906c89bef323c75b22cf8040d2b53e7179958 Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com> Date: 12-01-2024 10:16:59 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/7a0906c89bef323c75b22cf8040d2b53e7179958 [^] Fixes ISSUE-54297: Added skipApproval flag to all automatic scenarios in SetBusinessDate flow --- M web-jspack/org.openbravo.retail.sessions/src/model/till/TillUtils.js M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/ValidateClosedTillsNotClosedStore.js ---

(0159254) hgbot (developer) 2024-01-12 11:17	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/105 [^]

Issue History
Date Modified	Username	Field	Change
2024-01-10 16:27	Lcazaux	New Issue
2024-01-10 16:27	Lcazaux	Assigned To	=> Retail
2024-01-10 16:27	Lcazaux	Triggers an Emergency Pack	=> No
2024-01-10 16:27	Lcazaux	Relationship added	related to 0054208
2024-01-11 06:49	sreehari	Assigned To	Retail => sreehari
2024-01-11 08:33	sreehari	Status	new => scheduled
2024-01-12 09:31	hgbot	Note Added: 0159245
2024-01-12 11:17	hgbot	Resolution	open => fixed
2024-01-12 11:17	hgbot	Status	scheduled => closed
2024-01-12 11:17	hgbot	Note Added: 0159253
2024-01-12 11:17	hgbot	Note Added: 0159254

Copyright © 2000 - 2009 MantisBT Group