0053493: Cash up is not stuck in Errors While Importing POS Data but it is not set as isprocessedbo if it has an existing reconciliation

Description

Cash up is not stuck in Errors While Importing POS Data but it is not set as isprocessedbo if it has an existing reconciliation

Steps To Reproduce

Log in in https://livebuilds.openbravo.com/context/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]

Do a sale
Do a cashup

In the backoffice:
Create a new record in the Data Import Entry window with the same data as the one related to the previous cashup

Change the "id" property and set it as Initial

Once it is processed, check the cash up has been created with isprocessed = 'Y' and isprocessedbo = 'N' but there isn't any related entry in the Errors While Importing POS Data

The log shows:

ERROR org.openbravo.retail.posterminal.ProcessCashClose - Cashup cannot be processed since error occurred in CashClose: A different object with the same identifier value was already associated with the session : [FIN_Reconciliation#D7C9B201C3ABC4553E5A4C340D2984E1]
org.hibernate.NonUniqueObjectException: A different object with the same identifier value was already associated with the session : [FIN_Reconciliation#D7C9B201C3ABC4553E5A4C340D2984E1]
    at org.hibernate.event.internal.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:179) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.internal.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:134) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:194) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:179) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:100) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:75) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:107) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.internal.SessionImpl.fireSaveOrUpdate(SessionImpl.java:652) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.hibernate.internal.SessionImpl.saveOrUpdate(SessionImpl.java:645) ~[hibernate-core-5.6.15.Final.jar:5.6.15.Final]
    at org.openbravo.dal.core.SessionHandler.save(SessionHandler.java:439) ~[classes/:?]
    at org.openbravo.dal.service.OBDal.save(OBDal.java:317) ~[classes/:?]
    at org.openbravo.retail.posterminal.CashCloseProcessor.processCashClose(CashCloseProcessor.java:128) ~[classes/:?]
    at org.openbravo.retail.posterminal.ProcessCashClose.doReconciliationAndInvoices(ProcessCashClose.java:518) [classes/:?]
    at org.openbravo.retail.posterminal.ProcessCashClose.saveRecord(ProcessCashClose.java:222) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
    at org.openbravo.retail.posterminal.importprocess.CashUpImportEntryProcessor$CashUpRunnable.processEntry(CashUpImportEntryProcessor.java:80) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:437) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:360) [classes/:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0053536	RR23Q3.1	closed	ranjith_qualiantech_com	Cash up is not stuck in Errors While Importing POS Data but it is not set as isprocessedbo if it has an existing reconciliation
caused by	defect	0052664		closed	ranjith_qualiantech_com	Cash Up in Errors While Importing POS Data cannot be saved again if the amount counted is higher than the amount to keep

Notes
(0155226) hgbot (developer) 2023-09-26 04:22	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1361 [^]

(0155288) hgbot (developer) 2023-09-27 11:27	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1361 [^]

(0155289) hgbot (developer) 2023-09-27 11:27	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: a7f4db84ba33f88dff1208208ad09b3a761490d2 Author: Ranjith S R <ranjith@qualiantech.com> Date: 26-09-2023 13:57:28 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a7f4db84ba33f88dff1208208ad09b3a761490d2 [^] Fixed ISSUE-53493: Exception should be thrown when error occurs in CashCloseProcess --- M src/org/openbravo/retail/posterminal/ProcessCashClose.java ---

Issue History
Date Modified	Username	Field	Change
2023-09-19 14:11	ngarcia	New Issue
2023-09-19 14:11	ngarcia	Assigned To	=> Retail
2023-09-19 14:11	ngarcia	Triggers an Emergency Pack	=> No
2023-09-25 10:54	marvintm	Assigned To	Retail => ranjith_qualiantech_com
2023-09-25 10:54	marvintm	Status	new => acknowledged
2023-09-25 12:08	ranjith_qualiantech_com	Regression level	=> Production - QA Approved
2023-09-25 12:08	ranjith_qualiantech_com	Regression date	=> 2023-06-14
2023-09-25 12:08	ranjith_qualiantech_com	Regression introduced in release	=> RR23Q3
2023-09-25 12:08	ranjith_qualiantech_com	Regression introduced by commit	=> https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/faabbb8d7b63d358a3f032d02bbcee51471532a3 [^]
2023-09-25 12:08	ranjith_qualiantech_com	Status	acknowledged => scheduled
2023-09-25 12:15	ranjith_qualiantech_com	Relationship added	caused by 0052664
2023-09-26 04:22	hgbot	Note Added: 0155226
2023-09-27 11:27	hgbot	Resolution	open => fixed
2023-09-27 11:27	hgbot	Status	scheduled => closed
2023-09-27 11:27	hgbot	Note Added: 0155288
2023-09-27 11:27	hgbot	Fixed in Version	=> RR23Q4
2023-09-27 11:27	hgbot	Note Added: 0155289