0051879: [Promo] - Buy X Get Y - Number of gifts is multiplied by number of eligible products bought even if Max Y = 1

Description

Relates to: https://issues.openbravo.com/view.php?id=50976 [^]

When configuring Buy X Get Y, the number of gifts is multiplied by number of eligible products bought even if Max Y = 1. Moreover, when adding several gifts to the ticket, only one is free.

Steps To Reproduce

Step 1: Definition of promotion

                Name: Test number of gift multiplied

                Type: Buy X get Y as a gift

               Subtype: Here Buy Any X Get Any Y (But this bug concerns the 4
               subtypes)

               Application Method: Optional

               Add in the list of products in "Product subtab":

               Product: “Alpine poles “

               Product: “Blue Coat “

               Gift Product: “Beer 0.5L”

X = 1
Min Y = 1
Max Y = 1

Step 2: Add one eligible product to the ticket, only one gift can be selected among the 3 possible gifts defined => Result OK

Step 3 : Add a second eligible product to the ticket --> KO
The pop up indicates that 2 eligible products can be selected instead of 1 (number of gifts is equal to the number of eligible products bought)
When we select only one gift and click on Apply, error message is displayed

Step 4: We select 2 gifts and click on Apply --> KO both gifts are added to the ticket, but only one is free

Proposed Solution

Expected behavior : If max Y = 1, only one gift can be offered to the client, even if he buys several eligible products - we expect the same pop up and behavior as when only one eligible product is bought (requirement 3 in the specification)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0051795		closed	ranjith_qualiantech_com	Retail Modules	When "Apply only once" is uncheck, it is possible to add gift endlessly
related to	defect	0052053		new	Retail	POS2	buy x gift y popup not show if pending gifts

Notes
(0148057) gorka_gil (administrator) 2023-03-29 17:01	Needed fix: - the min should be the min of the promotion, instead the sum of the mins - the max should remain the same (sum of maxes) I only remember about the problem in the popup, but as far as I remember the rule was working fine once it is added to the ticket, please test again and ensure the apply only once it is not check

(0148218) gorka_gil (administrator) 2023-04-03 19:40	This issue report two things: - 1) If a promotion can be applied twice, in the popup the min should be the min y, not the twice the min y. - 2) If applied twice to the ticket manually, only one gift it is taken as gift Right now, in livebuilds both things are working, so rejecting this issue.

Issue History
Date Modified	Username	Field	Change
2023-03-16 08:22	noemieroussel	New Issue
2023-03-16 08:22	noemieroussel	Assigned To	=> Retail
2023-03-16 08:22	noemieroussel	Triggers an Emergency Pack	=> No
2023-03-20 11:11	noemieroussel	Note Added: 0147694
2023-03-27 08:40	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2023-03-27 08:40	ranjith_qualiantech_com	Status	new => scheduled
2023-03-27 08:42	guillermogil	Sticky Issue	No => Yes
2023-03-27 08:42	guillermogil	Sticky Issue	Yes => No
2023-03-29 08:13	noemieroussel	Note Deleted: 0147694
2023-03-29 17:01	gorka_gil	Note Added: 0148057
2023-03-30 11:16	ranjith_qualiantech_com	Relationship added	related to 0051795
2023-04-03 19:40	gorka_gil	Note Added: 0148218
2023-04-03 19:40	gorka_gil	Status	scheduled => closed
2023-04-03 19:40	gorka_gil	Resolution	open => no change required
2023-04-03 19:51	gorka_gil	Relationship added	related to 0052053