Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050506
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Gift cards and gift voucherscriticalhave not tried2022-10-12 16:522022-10-25 12:32
ReporterrafarodaView Statuspublic 
Assigned Tomontse_cabanas 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050506: Gift Card as Payment Method: Gift Card Prefix can lead to duplicated C_ORDER DOCUMENT NUMBERS

DescriptionGift Card as Payment Method: Gift Card Prefix can lead to duplicated C_ORDER DOCUMENT NUMBERS

We should avoid duplicated document numbers in C_ORDER Sales Order window
Steps To Reproduce1) Go to Live Builds with modules: window TouchPoint https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=FF80818132F311740132F3233778004B&emptyFilterClause=true [^]

2.a) Take record AMS1001 https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=FF80818132F311740132F3233778004B&recordId=2694D5D99689476AABC5E3494D9191D5 [^]

2.b) You will be able to do Gift Card Prefix = Order Prefix = AMS1001: this will lead to duplicated document numbers in C_ORDER Sales Order window inside the same terminal

3.a) Go to record CTST1 https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=FF80818132F311740132F3233778004B&recordId=3A95A52107624AE0846FF0278906B4AA [^]

3.b) You will be able to set Gift Card Prefix = AMS1001: this will lead to duplicated document numbers in C_ORDER Sales Order window within 2 different terminals

See video
Proposed SolutionMake

A) Constraint to make Gift Card Prefix != Order Prefix inside the same terminal

B) Constraint to make Gift Card Prefix unique (in the same way Order Prefix is unique)
TagsFASH
Attached Files? file icon Gift Card as Payment Method Gift Card Prefix can lead to duplicated C_ORDER DOCUMENT NUMBERS.webm [^] (3,602,634 bytes) 2022-10-12 16:52

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0050373 closedmontse_cabanas touchpoint window - Gift Card Sale Sequence Prefix and and Gift Card Sale Sequence Number confusing labels 
related to feature request 0050593 closedmontse_cabanas [GiftCard] - Wrong documentNo for gift card selling Ticket 

-  Notes
(0142407)
hgbot (developer)
2022-10-21 12:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/159 [^]
(0142422)
hgbot (developer)
2022-10-21 14:37

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 7489d85e43a9c838927ad91c76ca7591ae06257f
Author: Montserrat Cabañas <montserrat.cabanas@openbravo.com>
Date: 21-10-2022 12:37:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/7489d85e43a9c838927ad91c76ca7591ae06257f [^]

Fixes ISSUE-50506: Add constraints to gift card order prefix to avoid duplicated order document numbers

---
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
---
(0142423)
hgbot (developer)
2022-10-21 14:37

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/159 [^]
(0142428)
hgbot (developer)
2022-10-21 16:45

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: b3e792c55e6be66ccbf69076f0b685826aa571cc
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 21-10-2022 16:45:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b3e792c55e6be66ccbf69076f0b685826aa571cc [^]

Related to ISSUE-50506: Replace unique constraint by unique index to add is not null where clause and avoid error in oracle

---
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
---
(0142429)
hgbot (developer)
2022-10-21 17:29

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: ed1b7383fc59d8c75250a90b56acc4e3425a01e3
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 21-10-2022 17:28:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ed1b7383fc59d8c75250a90b56acc4e3425a01e3 [^]

Revert "Related to ISSUE-50506: Replace unique constraint by unique index to add is not null where clause and avoid error in oracle"

This reverts commit b3e792c55e6be66ccbf69076f0b685826aa571cc.

---
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
---
(0142430)
hgbot (developer)
2022-10-21 17:29

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 8e78a8f2a407222d25c59ffaf4153140f952d4e2
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 21-10-2022 17:28:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/8e78a8f2a407222d25c59ffaf4153140f952d4e2 [^]

Revert "Fixes ISSUE-50506: Add constraints to gift card order prefix to avoid duplicated order document numbers"

This reverts commit 7489d85e43a9c838927ad91c76ca7591ae06257f.

---
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
---
(0142431)
hgbot (developer)
2022-10-23 12:04

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/160 [^]
(0142553)
hgbot (developer)
2022-10-25 12:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: c9c95e84655deaa44649bdc75550639ea23ddaec
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 25-10-2022 10:32:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/c9c95e84655deaa44649bdc75550639ea23ddaec [^]

Fixes ISSUE-50506: Add constraints to gift card order prefix to avoid duplicated order document numbers

---
M src-db/database/model/modifiedTables/OBPOS_APPLICATIONS.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/giftcards/event/GCNVCertificateSequencePrefixEventHandler.java
---
(0142554)
hgbot (developer)
2022-10-25 12:32

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/160 [^]

- Issue History
Date Modified Username Field Change
2022-10-12 16:52 rafaroda New Issue
2022-10-12 16:52 rafaroda Assigned To => Retail
2022-10-12 16:52 rafaroda File Added: Gift Card as Payment Method Gift Card Prefix can lead to duplicated C_ORDER DOCUMENT NUMBERS.webm
2022-10-12 16:52 rafaroda Triggers an Emergency Pack => No
2022-10-12 16:53 rafaroda Assigned To Retail => aferraz
2022-10-12 16:53 rafaroda Severity major => critical
2022-10-12 16:53 rafaroda Tag Attached: FASH
2022-10-12 16:53 rafaroda Relationship added related to 0050373
2022-10-13 11:45 psanjuan Proposed Solution updated
2022-10-20 15:42 aferraz Assigned To aferraz => montse_cabanas
2022-10-20 17:55 aferraz Relationship added related to 0050593
2022-10-21 12:32 hgbot Note Added: 0142407
2022-10-21 14:37 hgbot Resolution open => fixed
2022-10-21 14:37 hgbot Status new => closed
2022-10-21 14:37 hgbot Note Added: 0142422
2022-10-21 14:37 hgbot Note Added: 0142423
2022-10-21 16:45 hgbot Note Added: 0142428
2022-10-21 17:29 hgbot Note Added: 0142429
2022-10-21 17:29 hgbot Note Added: 0142430
2022-10-21 17:29 aferraz Status closed => new
2022-10-21 17:29 aferraz Resolution fixed => open
2022-10-23 12:04 hgbot Note Added: 0142431
2022-10-25 12:32 hgbot Resolution open => fixed
2022-10-25 12:32 hgbot Status new => closed
2022-10-25 12:32 hgbot Note Added: 0142553
2022-10-25 12:32 hgbot Note Added: 0142554

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker