0050330: Sending a ticket by email, is generating an Import Entry in Error status

Description

Sending a ticket by email, is generating two import entries from different flows, and one of them is creating an Import Entry in Error status.

Steps To Reproduce

Install everything following this wiki page[1]

[1]http://wiki.openbravo.com/wiki/Retail:Send_By_Email [^]

1) Login in WebPOS
2) Select a customer that is not the anonymous customer
3) Add products to the ticket
4) Pay the ticket
5) In the Send Email popup, introduce a valid email address and check Send Email option
6) Click on Continue button
7) Verify the ticket is closed and the email is sent to the email address set in step 5
8) Login in ERP
9) Navigate to Import Entry window
10) Verify a "Send Email" import entry is in status Error
9) Navigate

Proposed Solution

It is necessary to remove the import entry creation OBSMAIL_OrderLoaderHookImplementation.java file as is no longer necessary (see attached fix)

Tags

No tags attached.

Attached Files

I50330_possibleFix.diff [^] (1,369 bytes) 2022-09-26 11:05 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/sendemail/hooks_implementations/OBSMAIL_OrderLoaderHookImplementation.java b/src/org/openbravo/retail/sendemail/hooks_implementations/OBSMAIL_OrderLoaderHookImplementation.java
index 8559724..cabaa02 100644
--- a/src/org/openbravo/retail/sendemail/hooks_implementations/OBSMAIL_OrderLoaderHookImplementation.java
+++ b/src/org/openbravo/retail/sendemail/hooks_implementations/OBSMAIL_OrderLoaderHookImplementation.java
@@ -8,8 +8,6 @@
  */
 package org.openbravo.retail.sendemail.hooks_implementations;
 
-import java.util.Optional;
-
 import javax.enterprise.context.ApplicationScoped;
 
 import org.apache.commons.lang.StringUtils;
@@ -19,7 +17,6 @@ import org.openbravo.model.common.order.Order;
 import org.openbravo.model.materialmgmt.transaction.ShipmentInOut;
 import org.openbravo.retail.posterminal.OrderLoaderHook;
 import org.openbravo.retail.posterminal.OrderLoaderHookForQuotations;
-import org.openbravo.retail.sendemail.OBSMAIL_Utils;
 
 @ApplicationScoped
 public class OBSMAIL_OrderLoaderHookImplementation
@@ -36,8 +33,6 @@ public class OBSMAIL_OrderLoaderHookImplementation
         order.setOBSMAILEmailAddress(emailAddress);
       }
 
-      OBSMAIL_Utils.createEmailImportEntry(order, invoice, emailAddress,
-          Optional.ofNullable(jsonorder.optJSONObject("externalBusinessPartner")));
     }
   }
 }

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

0051644

closed

ranjith_qualiantech_com

Sending ticket by mail from POS doesn't work, it doesn't send the mail.

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2022-09-26 11:02	jorge-garcia	New Issue
2022-09-26 11:02	jorge-garcia	Assigned To	=> Retail
2022-09-26 11:02	jorge-garcia	Triggers an Emergency Pack	=> No
2022-09-26 11:05	jorge-garcia	File Added: I50330_possibleFix.diff
2023-02-20 16:17	marvintm	Review Assigned To	=> marvintm
2023-02-20 16:17	marvintm	Relationship added	duplicate of 0051644
2023-02-20 16:17	marvintm	Status	new => closed
2023-02-20 16:17	marvintm	Resolution	open => duplicate