Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050234
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] E. Translationmajorhave not tried2022-09-13 12:202023-10-31 16:18
ReportershuehnerView Statuspublic 
Assigned Toaferraz 
PrioritynormalResolutionfixedFixed in VersionPR24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050234: Export translation process creates many 'empty' xml files for tables not having a translation

DescriptionWhen having a module with some translatable elements and then exporting this translation the process creates 1 xml file for each table even if there are 0 rows inside those files.

That produces lot of useless files and makes it hard to see what is the real content.

We should probably change the export to just skip creating the xml file in case there are no rows.
Steps To ReproduceInstall module:
https://gitlab.com/obcustomers/OBFR/org.openbravo.reporting.integration.retail.fr_FR [^]

Export translation for french language.
Check the created xml files in <attach.path>/lang/fr_FR/org.openbravo.reporting.integration.retail

Only 2 of 25 files have rows inside them:
grep -c '<row' *.xml | grep -v :0

AD_MESSAGE_TRL_fr_FR.xml:8
AD_REF_LIST_TRL_fr_FR.xml:1
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0141053)
hgbot (developer)
2022-09-13 13:44

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/710 [^]
(0156560)
hgbot (developer)
2023-10-31 16:18

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/710 [^]
(0156561)
hgbot (developer)
2023-10-31 16:18

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5e4dc581ab768c87f2430179c605d2f36f0af128
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-10-2023 16:17:13
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5e4dc581ab768c87f2430179c605d2f36f0af128 [^]

Fixes ISSUE-50234: Skip exporting translation xml files if empty

Skip creating the exported xml translation files entirely if they would
be empty (not having any rows).

Adjust the ReducedTranslactionExportTests to test the modified behavior
- Rename test expectedEmptyTranslationFiles to expectedEmptyTranslationFilesAbsent
  as now no 'empty (just 2 header lines) xml file is expected when there
  is no content but instead the xml file should be absent/missing
- Adjust testExistInFullAndNotExistsInReduced testcase (which checks that
  a specific text is absent) to allow for the reduced file to be missing
  - That way the test case can be used flexibly for checking the
    'reduced export' functionality without needing to know if the
    resulting xml file got empty/missing

---
M src-test/src/org/openbravo/test/reducedtranslation/ReducedTranslationExportTests.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---

- Issue History
Date Modified Username Field Change
2022-09-13 12:20 shuehner New Issue
2022-09-13 12:20 shuehner Assigned To => Triage Platform Base
2022-09-13 12:20 shuehner Modules => Core
2022-09-13 12:20 shuehner Triggers an Emergency Pack => No
2022-09-13 13:44 hgbot Note Added: 0141053
2023-01-12 09:33 AugustoMauch Assigned To Triage Platform Base => meriem_azaf
2023-01-12 13:35 AugustoMauch Assigned To meriem_azaf => aferraz
2023-10-31 16:18 hgbot Note Added: 0156560
2023-10-31 16:18 hgbot Resolution open => fixed
2023-10-31 16:18 hgbot Status new => closed
2023-10-31 16:18 hgbot Fixed in Version => PR24Q1
2023-10-31 16:18 hgbot Note Added: 0156561


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker