Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049949 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] Core | major | have not tried | 2022-08-04 11:46 | 2022-08-16 22:56 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049949: There should be a way to register steps on a window or window flow enter | |||||||
| Description | When entering a window or a flow, in some occasions we want to show several steps before the main flow, this way the user can input some data, or perform some actions in these cases. Currently we have 2 types of hooks for windows and flows, onExitHooks and onEnterHooks, this Feature request proposes to add a new one, which would be onEnterMultiStepHooks, which will be executed after the onEnterHooks and will display a multistep process with the registered steps and when finished will return to the window/flow where is executing. As part of this issue, some steps should be migrated to the new functionality, in particular FinalServiceMandatoryProposal and DCMConfiguration at ticket level, both of them shown before payments flow. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0139904) hgbot (developer) 2022-08-04 19:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/814 [^] |
|
(0139905) hgbot (developer) 2022-08-04 20:19 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1124 [^] |
|
(0139943) hgbot (developer) 2022-08-06 18:04 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/173 [^] |
|
(0140097) hgbot (developer) 2022-08-12 13:01 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 619b958d181b19f6c395c102dee104dad3f8dcb8 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 12:55:23 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/619b958d181b19f6c395c102dee104dad3f8dcb8 [^] Related to FR-49949: Add window flow component to main window and migrate FinalMandatoryServiceStep This migrates the FinalMandatoryProposal service step to the new API for onEnterMultiStepHooks. So it is the first step that will appear when entering the payments flow. --- A web-jspack/org.openbravo.pos2/src/components/Service/__test__/FinalMandatoryServicePaymentFlow.test.js M web-jspack/org.openbravo.pos2/src/components/MainPOSApp/MainPOSApp.config.json M web-jspack/org.openbravo.pos2/src/components/Service/FinalMandatoryServicePaymentFlowHook.js M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/ServiceConfigurationStep.jsx M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/UpdateServiceConfigurationSearchInput.js M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/DCMController.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishDCMConfigurationStep.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/FinishDCMConfigurationStep.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/AbortCashupUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/AbortInitialCount.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/FinishInitialCount.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SelectCurrentSchema.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToInitialCountWindow.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToTicketListLocalWindow.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToPayments.js M web-jspack/org.openbravo.pos2/src/ob-init.js R web-jspack/org.openbravo.pos2/src/components/Service/FinalMandatoryServiceConfiguration/FinalMandatoryServiceConfiguration.jsx R web-jspack/org.openbravo.pos2/src/components/Service/FinalMandatoryServiceConfiguration/FinalMandatoryServiceConfiguration.scss R web-jspack/org.openbravo.pos2/src/components/Service/FinalMandatoryServiceConfiguration/__test__/FinalMandatoryServiceConfiguration.test.jsx R web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AbortFinalMandatoryServiceConfiguration.js R web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/AbortFinalMandatoryServiceConfiguration.test.js --- |
|
(0140098) hgbot (developer) 2022-08-12 13:01 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1124 [^] |
|
(0140099) hgbot (developer) 2022-08-12 13:01 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 6015b9ecd4db238c8ddedbf6d601d21b378d6689 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 13:00:25 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6015b9ecd4db238c8ddedbf6d601d21b378d6689 [^] Fixes FR-49949: There should be a way to register steps on a window or window flow enter This MR adds an API to register onEnterMultiStepHooks which will be executed after the onEnterHooks of the window, and will appear in a multi step process. Once finished the multi step process, the main flow of the window/flow change action will continue. It is also possible to abort the process, and will return to the previous window/flow. --- A web-jspack/org.openbravo.core2/src/components/Window/WindowOnEnterMultiStep/WindowOnEnterMultiStep.config.json A web-jspack/org.openbravo.core2/src/components/Window/WindowOnEnterMultiStep/WindowOnEnterMultiStepPanel.jsx A web-jspack/org.openbravo.core2/src/components/Window/WindowOnEnterMultiStep/WindowOnEnterMultiStepPanel.scss A web-jspack/org.openbravo.core2/src/components/Window/WindowOnEnterMultiStep/index.js A web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/FinishOnEnterMultiStepProcess.js M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.core2/src/core/Registry.js M web-jspack/org.openbravo.core2/src/core/user-action/WindowFlowSwitchAction.js M web-jspack/org.openbravo.core2/src/core/user-action/WindowSwitchAction.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowFlowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowSwitchAction.test.js M web-jspack/org.openbravo.core2/src/ob-init.js --- |
|
(0140100) hgbot (developer) 2022-08-12 13:01 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/814 [^] |
|
(0140101) hgbot (developer) 2022-08-12 13:01 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: bebe80f4010108eed9781149fd74fa1a1f8932bb Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 11:42:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/bebe80f4010108eed9781149fd74fa1a1f8932bb [^] Related to FR-49949: Fix test OpenMenuWizard by taking into account new payload The test expects some parameters for the calls to WindowFlowSwitchAction, and new payload properties have been added in the development of this FR, this fixes the test by taking these new properties into account in the test. --- M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/OpenMenuWizard.test.js --- |
|
(0140102) hgbot (developer) 2022-08-12 13:01 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/173 [^] |
|
(0140138) hgbot (developer) 2022-08-16 09:27 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0101f716fea645a403fab5cd2640b5d6e99317b8 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 16-08-2022 09:26:15 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0101f716fea645a403fab5cd2640b5d6e99317b8 [^] Related to FR-49949: Fix error in test ServiceConfigurationStep --- M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/__test__/ServiceConfigurationStep.test.jsx --- |
|
(0140161) hgbot (developer) 2022-08-16 22:56 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 825033b5e36ebc39b13c116ef546dcaa9cd869a4 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 16-08-2022 22:54:53 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/825033b5e36ebc39b13c116ef546dcaa9cd869a4 [^] Related to FR-49949: Fix incorrect max-width on FinalMandatoryServices step search input max-width was set to 33rem, and should be unset on this particular field. This was due to the refactor of this component to be an onEnterMultiStepHook --- M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/ServiceConfigurationStep.scss --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-08-04 11:46 | cberner | New Issue | |
| 2022-08-04 11:46 | cberner | Assigned To | => cberner |
| 2022-08-04 11:46 | cberner | OBNetwork customer | => No |
| 2022-08-04 11:46 | cberner | Triggers an Emergency Pack | => No |
| 2022-08-04 19:45 | hgbot | Merge Request Status | => open |
| 2022-08-04 19:45 | hgbot | Note Added: 0139904 | |
| 2022-08-04 20:19 | hgbot | Note Added: 0139905 | |
| 2022-08-06 18:04 | hgbot | Note Added: 0139943 | |
| 2022-08-07 09:58 | hgbot | Merge Request Status | open => approved |
| 2022-08-12 13:01 | hgbot | Note Added: 0140097 | |
| 2022-08-12 13:01 | hgbot | Note Added: 0140098 | |
| 2022-08-12 13:01 | hgbot | Resolution | open => fixed |
| 2022-08-12 13:01 | hgbot | Status | new => closed |
| 2022-08-12 13:01 | hgbot | Fixed in Version | => 22Q4 |
| 2022-08-12 13:01 | hgbot | Note Added: 0140099 | |
| 2022-08-12 13:01 | hgbot | Note Added: 0140100 | |
| 2022-08-12 13:01 | hgbot | Note Added: 0140101 | |
| 2022-08-12 13:01 | hgbot | Note Added: 0140102 | |
| 2022-08-16 09:27 | hgbot | Note Added: 0140138 | |
| 2022-08-16 22:56 | hgbot | Note Added: 0140161 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |