Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049266
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Localization Pack: Spain] SIImajoralways2022-05-09 13:562022-05-23 11:36
ReporterpsanjuanView Statuspublic 
Assigned Tomgonzalezh 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0049266: "Clave NIF Pais de Residencia" update if the error 1103 "Valor del campo IDType Incorrecto" is obtained after sending to SII.

Description"Clave NIF Pais de Residencia" update if the error 1103 "Valor del campo IDType Incorrecto" is obtained after sending a sales invoice to SII.
Steps To ReproduceCreate a BP located in France (or in the United States), by mistake enter the value 1 NIF in the field Clave NIF País de residencia.

Register a sales invoice (Full Invoice) for this BP.

Complete and send it to SII.

Verity that below error is shown.

Error 1103 - Valor del campo IDType incorrecto

See images attached.

Same would apply if a customer located out of the EU is configured with the option 1=NIF
Proposed SolutionThe background process "Correct TaxID Not Identified Error (background)" needs to be renamed as "Correct "Clave NIF País de Residencia" configuration" (Corrección de la configuración de la "Clave NIF País de Residencia")

An additional SQL query needs to be added to this background process, or the existing one can be modified, to add below described business logic (additionaly to what existing:

* if the error found on a sales invoice previously sent to SII is 1103, this process must find the BP associated to that invoice:

** If the "Invoice Address" is located in a EU Country, configured as "Is European Country" = Yes in the "Country and Region" window, and it is NOT Spain (ISO Code = ES), then Clave NiF Pais de Residencia of the BP must be changed to 2 = NOI.

** If the "Invoice Address" is located in another country (not EU Country, and not ES=Spain), then Clave NiF Pais de Residencia of the BP must be changed to 4 = Documento Oficial de identificación expedido por el país.
TagsNOR
Attached Filespng file icon Screenshot from 2022-05-09 14-29-59.png [^] (132,489 bytes) 2022-05-09 14:30

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0049173 closedmgonzalezh El proceso "Correct TaxId Not Identified Error" needs to take into account organizations underneath the one for which it is set 
causes defect 0049509 closedmgonzalezh SII translation can not be installed. 

-  Notes
(0137358)
hgbot (developer)
2022-05-17 01:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/41 [^]
(0137359)
hgbot (developer)
2022-05-17 01:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES/-/merge_requests/3 [^]
(0137426)
psanjuan (manager)
2022-05-18 13:07
edited on: 2022-05-18 15:50

 Test plan

1.- Create a BP named "Cliente UE LE" in the Legal Entity organization (that is the one for wich SII is configured). Assign the value "1" in the field, and a Tax ID = FR12456789 . Enter a location of France.
Create a Sales Invoice for this customer and try to send it to SII. Verify that an error is shown saying "Valor del campo IDType incorrecto". Error number 1103


2. Repeat the same test for a BP "Cliente UE Store" created in a store underneath the Legal Entity of test 1, located in Germany and with the Tax ID = . Clave NIF = 1
Create a Sales Invoice for this customer in the store, and try to send it to SII. Verify that the same error is shown saying "Valor del campo IDType incorrecto". Error number 1103

3. Go to Preference window, and create a new one with below setup:
Organization = Legal Entity
Property List = No
Selected = Yes
Attribute = SIIDaysToReviewNotIdentifiedError
Value = 2

4. Go to Process Request window, and launch the process "Correct "Clave NIF País de Residencia" configuration"

5. Verify that the process is executed succesfully and there is a process Log info saying aht 2 business partner successfully updated.

6. Go back to the BP and check that for both of them, the value now is 2 NOI. Send the invoices to SII.

7. Go back to the BP and change them back to 1 NIF

8. Register new sales dated on 5 days ago, and try to send them to SII. Verify that the same error is shown.

9. Once again run the process and verify that no change has been made (as the value of the preference is lower that 5 days). Log info shows 0 business partner sucessfully updted.

10. Go an change the value of the preference to 30 days, for instance.

11. Run the process request once more and verify that the Clave NiF for those customers, now is updated to 2=NOI.

12. Repeat the same test plan for customers located in USA, and verify that Clave NiF is changed to 04 when applies.
(0137604)
hgbot (developer)
2022-05-23 11:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii [^]
Changeset: d25bd8623539e8e12e45ca3e7ea0a1cb03bbfd4e
Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es>
Date: 16-05-2022 18:55:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/commit/d25bd8623539e8e12e45ca3e7ea0a1cb03bbfd4e [^]

Fixed ISSUE-49266: update TaxID if error 1103 is obtained sending to SII

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_PROCESS.xml
M src/org/openbravo/module/sii/process/background/CorrectTaxIdNotIdentifiedErrorBackground.java
---
(0137605)
hgbot (developer)
2022-05-23 11:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/41 [^]
(0137606)
hgbot (developer)
2022-05-23 11:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES [^]
Changeset: e4034314d5c467d598857749566f5d6bea9a744b
Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es>
Date: 16-05-2022 18:57:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES/-/commit/e4034314d5c467d598857749566f5d6bea9a744b [^]

Fixed ISSUE-49266: update TaxID if error 1103 is obtained sending to SII

---
M referencedata/translation/es_ES/AD_PROCESS_TRL_es_ES.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0137607)
hgbot (developer)
2022-05-23 11:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES [^]
Changeset: 584748ea371d11b4316ccb800ca50dbd8f0ca3d8
Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es>
Date: 17-05-2022 06:13:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES/-/commit/584748ea371d11b4316ccb800ca50dbd8f0ca3d8 [^]

Fixed ISSUE-49266: upgrade module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0137608)
hgbot (developer)
2022-05-23 11:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.es_ES/-/merge_requests/3 [^]

- Issue History
Date Modified Username Field Change
2022-05-09 13:56 psanjuan New Issue
2022-05-09 13:56 psanjuan Assigned To => Jorge Bravo
2022-05-09 13:57 psanjuan Assigned To Jorge Bravo => psanjuan
2022-05-09 14:03 psanjuan Steps to Reproduce Updated View Revisions
2022-05-09 14:03 psanjuan Proposed Solution updated
2022-05-09 14:19 psanjuan File Added: Screenshot from 2022-05-09 14-19-02.png
2022-05-09 14:21 psanjuan File Deleted: Screenshot from 2022-05-09 14-19-02.png
2022-05-09 14:25 psanjuan Steps to Reproduce Updated View Revisions
2022-05-09 14:25 psanjuan Proposed Solution updated
2022-05-09 14:28 psanjuan Steps to Reproduce Updated View Revisions
2022-05-09 14:30 psanjuan File Added: Screenshot from 2022-05-09 14-29-59.png
2022-05-09 14:33 rafaroda Tag Attached: NOR
2022-05-09 14:33 psanjuan Description Updated View Revisions
2022-05-09 14:33 psanjuan Proposed Solution updated
2022-05-09 14:34 psanjuan Relationship added related to 0049173
2022-05-10 07:30 ivancaceres Issue Monitored: ivancaceres
2022-05-11 13:51 psanjuan Summary "Clave NIF Pais de Residencia" update => "Clave NIF Pais de Residencia" update if the error 1103 "Valor del campo IDType Incorrecto" is obtained after sending to SII.
2022-05-11 13:51 psanjuan Description Updated View Revisions
2022-05-11 13:51 psanjuan Steps to Reproduce Updated View Revisions
2022-05-11 13:51 psanjuan Proposed Solution updated
2022-05-11 13:53 psanjuan Proposed Solution updated
2022-05-11 13:55 psanjuan Proposed Solution updated
2022-05-11 14:06 psanjuan Proposed Solution updated
2022-05-16 13:15 psanjuan Proposed Solution updated
2022-05-16 13:20 psanjuan Proposed Solution updated
2022-05-16 13:25 psanjuan Proposed Solution updated
2022-05-16 13:25 psanjuan Assigned To psanjuan => mgonzalezh
2022-05-16 13:25 psanjuan Status new => scheduled
2022-05-16 13:28 psanjuan Proposed Solution updated
2022-05-17 01:58 hgbot Note Added: 0137358
2022-05-17 01:58 hgbot Note Added: 0137359
2022-05-18 13:07 psanjuan Note Added: 0137426
2022-05-18 13:10 psanjuan Note Edited: 0137426 View Revisions
2022-05-18 13:22 psanjuan Note Edited: 0137426 View Revisions
2022-05-18 13:27 psanjuan Note Edited: 0137426 View Revisions
2022-05-18 13:33 psanjuan Note Edited: 0137426 View Revisions
2022-05-18 14:59 psanjuan Note Edited: 0137426 View Revisions
2022-05-18 15:50 psanjuan Note Edited: 0137426 View Revisions
2022-05-23 11:36 hgbot Resolution open => fixed
2022-05-23 11:36 hgbot Status scheduled => closed
2022-05-23 11:36 hgbot Note Added: 0137604
2022-05-23 11:36 hgbot Note Added: 0137605
2022-05-23 11:36 hgbot Note Added: 0137606
2022-05-23 11:36 hgbot Note Added: 0137607
2022-05-23 11:36 hgbot Note Added: 0137608
2022-06-08 17:45 mgonzalezh Relationship added causes 0049509

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker