Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048981
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Restaurantsmajoralways2022-04-06 11:402022-06-20 18:59
Reportertimothee_catteeuwView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048981: JIRA 2151 - Credit note - Scan doesn't work in payment screen

DescriptionIn the old version of Openbravo, we were able to scan a credit note directly from the payment screen. On WebPOS 2, we must click on the "Credit note management" button before scanning the credit note.
 
The request here is to be able to directly scan a credit note in payment screen.
Steps To Reproduce1) Go to WebPOS
2) Select several products and go to payment screen
3) Pay with a payment method which generates a credit note in case of over payment in order to generate a credit note. Of course the payment amount has to be higher to the ticket amount
4) Open a new ticket and select several products
5) Go to payment screen
6) Scan the credit note you previously generated (ex : OB.App.BarcodeScanner.scanCode({ code: '00690031/0000267'}))
--> KO, it opens the sales ticket corresponding to the credit note instead of detecting the credit note





Proposed Solution1. When you scan a credit note in the main window of POS a popup with the information of the credit note should appear (same as: open menu -> credit notes -> insert credit note code -> press search -> click on the result)
2. When you scan a credit note when you are in the flow of the payments (same as: select payment method for credit note -> open dialog to select credit note -> insert credit note code -> press search -> click on the result)
2.1 Credit note popup will be open showing credit note information
2.2 When "pay with credit note" is pressed the system should be enough smart to detect which is the payment method prepared to manage credit notes and add the payment with it. If more than one payment method can be used to manage credit notes then the user should receive a prompt in which he must decide which payment method to use

Note: Credit notes MUST have a unique code (to avoid collide with orders)
TagsNo tags attached.
Attached Filespng file icon 45b0a932-b4ca-4892-b9f6-ecc4cab8ae08.png [^] (35,357 bytes) 2022-06-17 12:03

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0137399)
hgbot (developer)
2022-05-17 18:54

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/962 [^]
(0137400)
hgbot (developer)
2022-05-17 19:07

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/117 [^]
(0137743)
hgbot (developer)
2022-05-25 22:52

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ec18e9c1c1a99b5694dd3df0941ed84e394e1983
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-05-2022 20:52:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ec18e9c1c1a99b5694dd3df0941ed84e394e1983 [^]

Related to BUG-0048981: JIRA 2151 - Credit note - Scan doesn't work in payment screen

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetPaymentStateProperties.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/MockProvider.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/PaymentProvider.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/__test__/MockPaymentProvider.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethods.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsHighVolumePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsStandardPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__test__/PaymentPanel.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
---
(0137744)
hgbot (developer)
2022-05-25 22:52

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/962 [^]
(0137745)
hgbot (developer)
2022-05-25 22:53

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 01126e14b7c8d540c5bf5de026e14057407e6baf
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 25-05-2022 20:53:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/01126e14b7c8d540c5bf5de026e14057407e6baf [^]

Fixes BUG-0048981: JIRA 2151 - Credit note - Scan doesn't work in payment screen

---
A web-jspack/org.openbravo.retail.giftcards/src/services/scan/handlers/CreditNoteScanEventHandler.js
A web-jspack/org.openbravo.retail.giftcards/src/services/scan/registerScanningDevicesAndHandlers.js
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.jsx
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.jsx
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
---
(0137746)
hgbot (developer)
2022-05-25 22:53

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/117 [^]
(0137758)
hgbot (developer)
2022-05-26 12:39

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/973 [^]
(0137763)
hgbot (developer)
2022-05-26 15:11

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e030aa9c5e64291f2562b14d5dff329f321ed16f
Author: Martin Taal <martin.taal@openbravo.com>
Date: 26-05-2022 12:35:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e030aa9c5e64291f2562b14d5dff329f321ed16f [^]

Related to ISSUE-48981: handle the case that the payment provider does not inherit form standard base class

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentButton/PaymentButton.jsx
---
(0137764)
hgbot (developer)
2022-05-26 15:11

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/973 [^]
(0138488)
mtaal (manager)
2022-06-17 12:03
edited on: 2022-06-17 12:06

The popup has the filter field repeated. See screenshot. This happens only when scanning, not when directly opening the popup.

(0138566)
AtulOpenbravo (developer)
2022-06-20 14:33
edited on: 2022-06-20 19:00

Gift Card Dialog has mandatory filter for Card ID which is also rendered as optional filters. Hence it was repeated. This problem is be fixed by the fix for issue https://issues.openbravo.com/view.php?id=49604 [^]

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/20a88c2c07fc83a54371e631728f5a9f874656ed [^]


- Issue History
Date Modified Username Field Change
2022-04-06 11:40 timothee_catteeuw New Issue
2022-04-06 11:40 timothee_catteeuw Assigned To => Retail
2022-04-06 11:40 timothee_catteeuw Triggers an Emergency Pack => No
2022-04-22 04:14 sntgreale Assigned To Retail => sntgreale
2022-04-22 04:14 sntgreale Status new => scheduled
2022-04-25 15:27 guilleaer Assigned To sntgreale => mtaal
2022-04-25 15:45 mtaal Assigned To mtaal => AtulOpenbravo
2022-04-27 13:03 guilleaer Proposed Solution updated
2022-04-27 13:03 guilleaer Proposed Solution updated
2022-05-17 18:54 hgbot Note Added: 0137399
2022-05-17 19:07 hgbot Note Added: 0137400
2022-05-25 22:52 hgbot Note Added: 0137743
2022-05-25 22:52 hgbot Note Added: 0137744
2022-05-25 22:53 hgbot Resolution open => fixed
2022-05-25 22:53 hgbot Status scheduled => closed
2022-05-25 22:53 hgbot Note Added: 0137745
2022-05-25 22:53 hgbot Note Added: 0137746
2022-05-26 12:39 hgbot Note Added: 0137758
2022-05-26 15:11 hgbot Note Added: 0137763
2022-05-26 15:11 hgbot Note Added: 0137764
2022-06-17 12:03 mtaal Note Added: 0138488
2022-06-17 12:03 mtaal Status closed => new
2022-06-17 12:03 mtaal Resolution fixed => open
2022-06-17 12:03 mtaal File Added: 45b0a932-b4ca-4892-b9f6-ecc4cab8ae08.png
2022-06-17 12:06 mtaal Note Edited: 0138488 View Revisions
2022-06-20 14:33 AtulOpenbravo Status new => scheduled
2022-06-20 14:33 AtulOpenbravo Note Added: 0138566
2022-06-20 14:33 AtulOpenbravo Assigned To AtulOpenbravo => gorka_gil
2022-06-20 15:13 gorka_gil Assigned To gorka_gil => AtulOpenbravo
2022-06-20 18:32 AtulOpenbravo Note Edited: 0138566 View Revisions
2022-06-20 18:59 AtulOpenbravo Status scheduled => resolved
2022-06-20 18:59 AtulOpenbravo Resolution open => fixed
2022-06-20 18:59 AtulOpenbravo Status resolved => closed
2022-06-20 19:00 AtulOpenbravo Note Edited: 0138566 View Revisions


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker