Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047797
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2021-10-01 17:002021-10-18 16:25
Reportertimothee_catteeuwView Statuspublic 
Assigned Toprakashmurugesan88 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionTAP
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047797: JIRA 2364 - Right & Role - Delete current ticket VS Close old ticket

DescriptionThe same user action is used for 2 actions :
- close ticket
- delete ticket
User action is DeleteTicket
Steps To Reproduce1) Go to BO --> https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/ [^]
2) Open role Menu
3) select Role "Vall Blanca user"
4) Go to User Action access Tab
5) Open DeleteTicket User action
6) change the field Approval to approval required
7) GO to https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]
8) refresh data
9) Start a new ticket and add several items
10) Try to delete ticket by pressing "delete Order" button
--> approval is required --> OK
11) Open a old ticket in orders menu (ex : VBS1/0000073)
12) Try to close ticket by pressing "Close Order" button
--> approval is also required --> KO it is not the same action
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0047807TAP closedprakashmurugesan88 JIRA 2364 - Right & Role - Delete current ticket VS Close old ticket 

-  Notes
(0132170)
hgbot (developer)
2021-10-05 14:47

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/588 [^]
(0132171)
hgbot (developer)
2021-10-05 14:48

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/694 [^]
(0132318)
hgbot (developer)
2021-10-13 15:08

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ccb2546df45f29c6f1b1d032a9f6ff5fe14dd18e
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-10-13T13:06:04+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ccb2546df45f29c6f1b1d032a9f6ff5fe14dd18e [^]

Related to BUG-47797: Created new user action for Close Ticket

---
A web-test/model/business-object/ticket/actions/CloseTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0132319)
hgbot (developer)
2021-10-13 15:08

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/588 [^]
(0132320)
hgbot (developer)
2021-10-13 15:08

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/694 [^]
(0132321)
hgbot (developer)
2021-10-13 15:08

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c8848a1d5fdcb58b9a6488fa69f3b1d322b68723
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-10-13T16:04:34+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c8848a1d5fdcb58b9a6488fa69f3b1d322b68723 [^]

Fixed BUG-47797: Created new user action for Close Ticket
* Currently both delete and close ticket are handled by Delete Ticket User Action
* Therefore all access validation given for delete ticket applies for close ticket
* Close ticket doesn't require any secured action
* So created separate user action for Close Ticket

---
A web-jspack/org.openbravo.pos2/src/model/ticket/__test__/CloseTicket.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CloseTicket.js
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedDisabledAll.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedQuotation.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedReturn.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/ButtonBar2-BookedTicket.config.json
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/finishCashupUi.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0132421)
hgbot (developer)
2021-10-18 16:25

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4256ab4572ad6a18e804b28f631cdd3c61d85a86
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-10-18T19:53:53+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4256ab4572ad6a18e804b28f631cdd3c61d85a86 [^]

Related to BUG-47797: Included Close Ticket user action to AD

---
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
---

- Issue History
Date Modified Username Field Change
2021-10-01 17:00 timothee_catteeuw New Issue
2021-10-01 17:00 timothee_catteeuw Assigned To => Retail
2021-10-01 17:00 timothee_catteeuw Triggers an Emergency Pack => No
2021-10-04 12:52 prakashmurugesan88 Assigned To Retail => prakashmurugesan88
2021-10-04 12:52 prakashmurugesan88 Status new => scheduled
2021-10-04 17:00 guilleaer Status scheduled => acknowledged
2021-10-04 17:00 guilleaer Status acknowledged => scheduled
2021-10-05 14:47 hgbot Note Added: 0132170
2021-10-05 14:48 hgbot Note Added: 0132171
2021-10-13 15:08 hgbot Note Added: 0132318
2021-10-13 15:08 hgbot Note Added: 0132319
2021-10-13 15:08 hgbot Note Added: 0132320
2021-10-13 15:08 hgbot Resolution open => fixed
2021-10-13 15:08 hgbot Status scheduled => closed
2021-10-13 15:08 hgbot Note Added: 0132321
2021-10-18 16:25 hgbot Note Added: 0132421

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker