Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047731 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Restaurants | major | always | 2021-09-21 12:37 | 2021-10-22 08:35 | |||
| Reporter | timothee_catteeuw | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | TAP | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047731: JIRA 2328 - Display of menu to improve | |||||||
| Description | When a component included in a menu contains lot of products and when displaying all products of this component, these products are not correctly displayed. These products shown for a component type in the menu wizard contain all the products available for that category, and they are distributed in 6 fixed columns. It is not like the keymap products outside the menu wizard, where there is pagination and the user can configure the layout on the backend Also tested in 1024x768, in that definition, quickly a limit exists and all the product buttons are very tight and labels go out buttons | |||||||
| Steps To Reproduce | 1) Configure a menu with 2 components 2) For each component, add lot of products (in my case for each component it is configured 72 products) 3) to reproduce easily switch to 1024 x 768 resolution 4) go Webpos2 5) Start a new ticket and select the configured menu --> all the product button are displayed on the same screen | |||||||
| Proposed Solution | 2 things to solve here, proposition : - When it is necessary to display product buttons for a component after selecting a menu, it is necessary to take back the same layout as previous category - Display product buttons in several pages when too much products have to be displayed and 1 page is not enough Solution for the future --> to be able to configure the layout as we can do with keymap today | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0132358) timothee_catteeuw (developer) 2021-10-15 09:57 |
Two topics raised to Augusto, on going : - colors of buttons are black, request to come back to the previous color (orange) - default layout row numbers are not correctly taken into account |
|
(0132418) hgbot (developer) 2021-10-18 16:04 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/83 [^] |
|
(0132419) hgbot (developer) 2021-10-18 16:05 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/708 [^] |
|
(0132420) hgbot (developer) 2021-10-18 16:06 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/651 [^] |
|
(0132534) hgbot (developer) 2021-10-21 13:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: e0e4e5e0bca43776c0346c008959e2c99c57d0b8 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T12:57:14+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e0e4e5e0bca43776c0346c008959e2c99c57d0b8 [^] Related to ISSUE-47731: Define a default value for keymap pages in case a keymap page does not exist --- M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js M web-jspack/org.openbravo.core2/src/model/user-interface/actions/SetKeymapPages.js --- |
|
(0132535) hgbot (developer) 2021-10-21 13:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 6d07582a806caad75cdebd439579b54698be9104 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T12:57:14+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6d07582a806caad75cdebd439579b54698be9104 [^] Related to ISSUE-47731: Add tests for core2 module --- M web-jspack/org.openbravo.core2/src/model/user-interface/__test__/SetKeymapPages.test.js --- |
|
(0132536) hgbot (developer) 2021-10-21 13:14 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/651 [^] |
|
(0132537) hgbot (developer) 2021-10-21 13:15 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f29236166723819e49c265c5e3d238109cad6bba Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T13:02:27+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f29236166723819e49c265c5e3d238109cad6bba [^] Related to ISSUE-47731: Refactor the code to reuse in menu keymaps --- A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/utils/getAutomatedButtonPosition.js A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/utils/getBestScreenResolutionKeymapOption.js A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/utils/updateKeymapPageInfo.js M web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/generateKeymapConfig.js M web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/getKeymapConfiguration.js M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetSelectedKeymapCategory.js R web-jspack/org.openbravo.pos2/src/configurations/loadMasterdataConfigurations.js --- |
|
(0132538) hgbot (developer) 2021-10-21 13:15 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 6e23f1191ab998a8375c7402f6770e3b187f5959 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T13:02:27+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6e23f1191ab998a8375c7402f6770e3b187f5959 [^] Related to ISSUE-47731: Add tests for pos2 module --- A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/__test__/getAutomatedButtonPositionUtils.test.js A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/__test__/getBestScreenResolutionKeymapOptionUtils.test.js A web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/__test__/updateKeymapPageInfoUtils.test.js M web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/utils/getBestScreenResolutionKeymapOption.js --- |
|
(0132539) hgbot (developer) 2021-10-21 13:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/708 [^] |
|
(0132540) hgbot (developer) 2021-10-21 13:15 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 0a2dcb4586c2051f2f1585c6ddfa101d49cb27c6 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T13:06:48+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/0a2dcb4586c2051f2f1585c6ddfa101d49cb27c6 [^] Fixed ISSUE-47731: Improve display of product keymap in menu wizard --- A src-db/database/model/tables/OBREST_MENU_PROD_LAYOUT.xml A src/org/openbravo/pos2/restaurant/master/MenuProductLayout.java A src/org/openbravo/pos2/restaurant/master/MenuProductLayoutProperties.java A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/generateMenuKeymapConfig.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/getMenuKeymapConfiguration.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/index.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/loadMenuKeymapConfigurations.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/selectMenuKeymapConfig.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/utils/calculateKeymapHorizontalAndVerticalPages.js A web-jspack/org.openbravo.pos2.restaurant/src/model/masterdata/MenuProductLayoutModel.js A web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/actions/SetSelectMenuKeymapCategory.js M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_TAB.xml M src-db/database/sourcedata/AD_TABLE.xml M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryButton/MenuWizardCategoryButton.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryButton/__test__/MenuWizardCategoryButton.test.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryButton/stories/MenuWizardCategoryButton.stories.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryKeymapLayout.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/__test__/MenuWizardCategoryKeymapLayout.test.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/index.js M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/stories/MenuWizardCategoryKeyMapLayout.stories.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductButton/MenuWizardProductButton.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductButton/MenuWizardProductButton.scss M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductKeymapLayout.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/__test__/MenuWizardProductKeymapLayout.test.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/index.js M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/stories/MenuWizardProductKeymapLayout.stories.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/__test__/MenuWizard.test.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/stories/MenuWizard.stories.jsx M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/UIExtension.js M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/SelectMenuCategory.test.js M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/user-actions/SelectMenuCategory.js M web-jspack/org.openbravo.pos2.restaurant/src/ob-init.js --- |
|
(0132541) hgbot (developer) 2021-10-21 13:15 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: abca11a7088808ee523786819d15a2934ec83aa7 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-21T13:06:48+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/abca11a7088808ee523786819d15a2934ec83aa7 [^] Related to ISSUE-47731: Add tests for restaurant module --- A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/__mock__/Menu1.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/__test__/calculateKeymapHorizontalAndVerticalPagesUtils.test.js A web-jspack/org.openbravo.pos2.restaurant/src/configurations/menuKeymapConfiguration/__test__/generateMenuKeymapConfig.test.js --- |
|
(0132542) hgbot (developer) 2021-10-21 13:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/83 [^] |
|
(0132549) hgbot (developer) 2021-10-22 08:01 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: cb2217e4aaff878e6ac8f27c0ee9935a7d05675d Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-22T08:00:05+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/cb2217e4aaff878e6ac8f27c0ee9935a7d05675d [^] Related to ISSUE-47731: Solve problems from CI --- M src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0132552) hgbot (developer) 2021-10-22 08:35 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: f019b5f6e035b6c12bf412736f4c22f937ff3098 Author: Jorge Garcia <jorge.garcia@openbravo.com> Date: 2021-10-22T08:34:41+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/f019b5f6e035b6c12bf412736f4c22f937ff3098 [^] Related to ISSUE-47731: Solve new problems from CI after last changes --- M src-db/database/sourcedata/AD_FIELD.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-09-21 12:37 | timothee_catteeuw | New Issue | |
| 2021-09-21 12:37 | timothee_catteeuw | Assigned To | => Retail |
| 2021-09-21 12:37 | timothee_catteeuw | Triggers an Emergency Pack | => No |
| 2021-09-21 12:40 | timothee_catteeuw | Description Updated | View Revisions |
| 2021-09-27 17:54 | guilleaer | Status | new => scheduled |
| 2021-09-27 17:54 | guilleaer | Status | scheduled => acknowledged |
| 2021-09-28 13:52 | AugustoMauch | Assigned To | Retail => jarmendariz |
| 2021-09-28 13:52 | AugustoMauch | Status | acknowledged => scheduled |
| 2021-10-15 09:57 | timothee_catteeuw | Note Added: 0132358 | |
| 2021-10-18 16:04 | hgbot | Note Added: 0132418 | |
| 2021-10-18 16:05 | hgbot | Note Added: 0132419 | |
| 2021-10-18 16:05 | jorge-garcia | Assigned To | jarmendariz => jorge-garcia |
| 2021-10-18 16:06 | hgbot | Note Added: 0132420 | |
| 2021-10-21 13:14 | hgbot | Note Added: 0132534 | |
| 2021-10-21 13:14 | hgbot | Note Added: 0132535 | |
| 2021-10-21 13:14 | hgbot | Note Added: 0132536 | |
| 2021-10-21 13:15 | hgbot | Note Added: 0132537 | |
| 2021-10-21 13:15 | hgbot | Note Added: 0132538 | |
| 2021-10-21 13:15 | hgbot | Note Added: 0132539 | |
| 2021-10-21 13:15 | hgbot | Resolution | open => fixed |
| 2021-10-21 13:15 | hgbot | Status | scheduled => closed |
| 2021-10-21 13:15 | hgbot | Note Added: 0132540 | |
| 2021-10-21 13:15 | hgbot | Note Added: 0132541 | |
| 2021-10-21 13:15 | hgbot | Note Added: 0132542 | |
| 2021-10-22 08:01 | hgbot | Note Added: 0132549 | |
| 2021-10-22 08:35 | hgbot | Note Added: 0132552 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |