Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0004759

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] Y. DBSourceManager

major

always

2008-08-29 12:19

2009-03-18 11:02

Reporter

marvintm

View Status

public

Assigned To

marvintm

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Oracle

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0004759: OnCreateDefault statements are not correct if the table wasn't recreated by the upgrader

Description

During the upgrade process, if a column is new and has an onCreateDefault statement, that statement will be constructed and executed.

The problem is that the way it is constructed now depends on the table of the column being recreated by the upgrader. If it is not, the statement will fail.

This problem currently only happens in Oracle, as in PostgreSQL the tables are recreated if a new column has been added.

Steps To Reproduce

Just add a new column to the end of a table in an table XML file, assign an onCreateDefault statement to it, and execute an update.database process, in an Oracle database.

Proposed Solution

The onCreateDefault statement has to be constructed differently for tables that have been not recreated.

Tags

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0008782) svnbot (reporter) 2008-08-29 12:21	Repository: dbsourcemanager Revision: 115 Author: marvintm Date: 2008-08-29 12:21:18 +0200 (Fri, 29 Aug 2008) Fixed bug 4759. Now onCreateDefault statements will be constructed differently if the table wasn't recreated by the upgrader process. --- U branches/r0.8x/src/org/apache/ddlutils/platform/SqlBuilder.java U branches/r0.8x/src/org/apache/ddlutils/platform/oracle/Oracle8Builder.java --- https://dev.openbravo.com/websvn/dbsourcemanager/?rev=115&sc=1 [^]

(0008783) svnbot (reporter) 2008-08-29 12:23	Repository: dbsourcemanager Revision: 116 Author: marvintm Date: 2008-08-29 12:23:39 +0200 (Fri, 29 Aug 2008) Backport of bug 4759.. Now onCreateDefault statements will be constructed differently if the table wasn't recreated by the upgrader process. --- _U trunk/ U trunk/src/org/apache/ddlutils/platform/SqlBuilder.java U trunk/src/org/apache/ddlutils/platform/oracle/Oracle8Builder.java --- https://dev.openbravo.com/websvn/dbsourcemanager/?rev=116&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-08-29 12:19	marvintm	New Issue
2008-08-29 12:19	marvintm	Assigned To	=> marvintm
2008-08-29 12:21	svnbot	Checkin
2008-08-29 12:21	svnbot	Note Added: 0008782
2008-08-29 12:21	svnbot	Status	new => resolved
2008-08-29 12:21	svnbot	Resolution	open => fixed
2008-08-29 12:21	svnbot	svn_revision	=> 115
2008-08-29 12:23	svnbot	Checkin
2008-08-29 12:23	svnbot	Note Added: 0008783
2008-08-29 12:23	svnbot	svn_revision	115 => 116
2008-12-15 19:00	psarobe	Status	resolved => closed
2008-12-18 12:38	jpabloae	Sticky Issue	No => Yes
2008-12-18 12:39	jpabloae	Sticky Issue	Yes => No
2008-12-18 12:39	jpabloae	Tag Attached: dbsm_migrate
2008-12-18 12:41	jpabloae	Project	@4@ => Openbravo ERP
2008-12-18 12:41	jpabloae	Category	=> Y. DBSourceManager
2009-03-18 11:02	anonymous	sf_bug_id	0 => 2691348

Copyright © 2000 - 2009 MantisBT Group