Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047570 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [POS2] POS | major | have not tried | 2021-08-18 12:03 | 2021-09-29 12:51 | |||
Reporter | jarmendariz | View Status | public | |||||
Assigned To | elara | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | jarmendariz | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047570: Application crashes with TypeError when CRM Connector is not configured | |||||||
Description | When we log in in a POS2 environment without the CRM Connector configured, the following error appears during the load process: TypeError: Cannot read property 'filter' of undefined getDetailProperties src/components/Customer/CustomerForm/CustomerFormHandler.js:311 308 | if (!externalBpConfig) { 309 | return []; 310 | } > 311 | return externalBpConfig.properties 312 | .filter(property => property.displayInDetail) 313 | .sort((a, b) => a.detailSequenceNumber - b.detailSequenceNumber); 314 | } | |||||||
Steps To Reproduce | In backoffice: - Go to Client -> 'The White Valley Group' - In Information tab, uncheck 'Enable CRM Connector' In POS2: - Perform a login | |||||||
Proposed Solution | When CRM Connector is not enabled, OB.App.TerminalProperty.get('externalBpIntegration') or Terminal.externalBpIntegration returns an empty object ({}). So, in all places where we check the extBP configuration, we should add a check that the returned object is not empty. Also, I'd be a good idea to centralize this check logic and avoid repeating it thoughout our code. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0131712) hgbot (developer) 2021-09-10 17:13 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/672 [^] |
(0132065) hgbot (developer) 2021-09-29 10:41 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f29d91fb6057f8ff8b56cff67621619f152981fd Author: Eduardo Lara <eduardo.lara@smfconsulting.es> Date: 2021-09-29T10:39:11+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f29d91fb6057f8ff8b56cff67621619f152981fd [^] fixed ISSUE-47570: Created centralized checkCRMConnector function to validate CRM Connector data --- A web-jspack/org.openbravo.pos2/src/model/global/__test__/isCRMConnectorEnabled.test.js A web-jspack/org.openbravo.pos2/src/model/global/utils/isCRMConnectorEnabled.js M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/isValidEmailCheck.js M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/TicketHeaderBPButton.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGrid.test.jsx M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/render/TicketRemoteCustomerCellRender.jsx M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AskDeliveryOptionsHook.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/DeliverReceiptPreCompleteTicketHook.js M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/DeliverReceiptUserAction.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/DeliverReceipt.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToCustomerWindow.js M web-jspack/org.openbravo.pos2/src/services/scan/handlers/CrmConnectorScanEventHandler.js M web-jspack/org.openbravo.pos2/src/services/scan/handlers/__test__/CrmConnectorScanEventHandler.test.js --- |
(0132066) hgbot (developer) 2021-09-29 10:41 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/672 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-08-18 12:03 | jarmendariz | New Issue | |
2021-08-18 12:03 | jarmendariz | Assigned To | => Retail |
2021-08-18 12:03 | jarmendariz | Triggers an Emergency Pack | => No |
2021-08-23 09:49 | dmiguelez | Resolution time | => 1632348000 |
2021-08-23 09:50 | dmiguelez | Assigned To | Retail => ealvarez |
2021-08-23 09:50 | dmiguelez | Status | new => acknowledged |
2021-08-28 01:44 | elara | Assigned To | ealvarez => elara |
2021-08-30 12:46 | dmiguelez | Assigned To | elara => ealvarez |
2021-09-03 04:30 | elara | Assigned To | ealvarez => elara |
2021-09-03 04:32 | elara | Status | acknowledged => scheduled |
2021-09-03 15:24 | dmiguelez | Assigned To | elara => ealvarez |
2021-09-10 17:13 | hgbot | Note Added: 0131712 | |
2021-09-20 08:53 | guilleaer | Assigned To | ealvarez => elara |
2021-09-29 10:41 | hgbot | Resolution | open => fixed |
2021-09-29 10:41 | hgbot | Status | scheduled => resolved |
2021-09-29 10:41 | hgbot | Note Added: 0132065 | |
2021-09-29 10:41 | hgbot | Note Added: 0132066 | |
2021-09-29 12:51 | jarmendariz | Review Assigned To | => jarmendariz |
2021-09-29 12:51 | jarmendariz | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |