Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046307
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] SII Retailmajoralways2021-04-20 12:162021-06-28 17:54
ReporterpsanjuanView Statuspublic 
Assigned Tovmromanos 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0046307: Default Sales SII Description should be automatically taken for sales invoices when those are created from POS

DescriptionDefault Sales SII Description should be automatically taken for sales invoices when those are created from POS
Steps To ReproduceIn an environment with SII create a sales in the POS.
Go to backoffice and check that this invoice or simplified invoice does not have a SII Description.

It is necessary to manually introduce that description, to send the invoice to SII.
Proposed SolutionSII Description should be automatically filled in the sales invoices created in the backoffice, coming from Web POS sales.

That SII description should be the one setup as Default for Sales transactions.

TagsNOR
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0129081)
psanjuan (manager)
2021-06-04 16:19

The resolution of this bug is being requested by Project team.
(0129348)
vmromanos (manager)
2021-06-10 14:12

Test plan:

Login into backoffice with The White Valley Group Admin.

Go to SII Descriptions window and create a new record for * organization.
Fill mandatory fields and make sure both Default and Sales invoice description fields are enabled.

Test plan I (named customer):
Login in POS with vallblanca user
Change customer to Arturo Montoro
In Menu, select "Issue Invoice" option.
Enter any product and pay the ticket.
In backend, search for the newly created sales order, browse to the sales invoice and make sure the Sii Description field is populated

Test plan II (anonymous customer):
Login in POS with vallblanca user
Enter any product and pay the ticket.
In backend, search for the newly created sales order. Verify there is no invoice yet.
In POS, Menu -> Cash Up. Follow the steps to complete it.
In backend, verify the sales order is invoiced. Browse to the sales invoice and make sure the Sii Description field is populated

Test plan III (Issue Sales Order):
In backoffice, create the preference "Web POS Enable Delivery Modes" and set it as Value = Yes, for all users and organizations. Set "selected" parameter as Yes.
Login in POS with vallblanca user.
Change customer to Arturo Montoro
Select Menu option "Receipt Properties" to change Invoice Terms to "After Delivery" and Default Delivery Mode as "Pick Up in Store". Press Apply.
Select any product and pay the ticket.
Navigate to the backoffice and verify that no invoice has been created for this sale but a sales order set as not invoiced.
Go back to Web POS and Issue the sales order.
Go back to backoffice, navigate to the Sales Invoice and make sure the Sii Description field is populated

Test plan IV (not active description):
In backoffice, deactivate the SII description previously created.
Login in POS with vallblanca user
Change customer to Arturo Montoro
In Menu, select "Issue Invoice" option.
Enter any product and pay the ticket.
In backend, search for the newly created sales order, browse to the sales invoice and make sure the Sii Description field is empty

Test plan V (not default description):
In backoffice, activate the SII description previously created and set it as default = 'N'
Login in POS with vallblanca user
Change customer to Arturo Montoro
In Menu, select "Issue Invoice" option.
Enter any product and pay the ticket.
In backend, search for the newly created sales order, browse to the sales invoice and make sure the Sii Description field is empty
(0129350)
hgbot (developer)
2021-06-10 14:44
edited on: 2021-06-28 16:27

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/3 [^]

(0129868)
psanjuan (manager)
2021-06-28 16:24
edited on: 2021-06-28 16:39

Additional Test Plan

Login into backoffice with The White Valley Group Admin.

Go to SII Descriptions window and create a new record for * organization.
Fill mandatory fields and make sure both Default and Sales invoice description fields are enabled.

Test Plan VI
Go to Web POS and create a Verified Return.
Complete and pay it
Go to backoffice.
Verify that a reverse sales invoice (Corrective Invoice) has been created including a SII Description.

Test Plan VII
Repeat above Test case for a Verified Return of a sale including an identified customer (ie. Arturo Montoro)

Test Plan VIII
Repeat above Test Case for a blind return, by using the menu option (Return this Receipt).

Test Plan IX
In backoffice, go to the channel touchpoint type and configure it to generate Aggregated Invoices.

Go to Openbravo Web POS and create a sale, run the cash up.
Go to the backoffice and verify that a Simplified Invoices summary has been created, and it does have the SII Description.

Test Plan X

Repeat the same test for a verified return, created as by the cash up process.
Verify it does have SII Description.

(0129872)
hgbot (developer)
2021-06-28 17:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: b5636bb910895e6e824c517dba54dd2a6d635245
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-06-10T14:35:42+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/b5636bb910895e6e824c517dba54dd2a6d635245 [^]

Fixed ISSUE-46307: Set sales default SII description in POS generated invoices

When an invoice is generated from a POS ticket, the SII automatically sets the
invoice's SII Description field using the available invoice organization's (or its inmediate
parent) default SII description for Sales. It is necessary that the description is marked as:
* active
* default
* Sales invoice description

This works for:
* Invoices generated for named customers
* Invoices generated through cash up
* Invoices generated through the Issue Sales Order feature

---
M src/org/openbravo/module/sii/retail/hook/SIIFinishInvoiceHook.java
M src/org/openbravo/module/sii/retail/hook/SIIInvoiceShipmentHook.java
M src/org/openbravo/module/sii/retail/hook/SIIOrderLoaderHook.java
M src/org/openbravo/module/sii/retail/hook/SIIUtility.java
---
(0129873)
hgbot (developer)
2021-06-28 17:54

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: efb36ac834660df9ded90975dd282c0ab859bf5e
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-06-10T14:49:11+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/efb36ac834660df9ded90975dd282c0ab859bf5e [^]

Related to ISSUE-46307: update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0129874)
hgbot (developer)
2021-06-28 17:54

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/3 [^]

- Issue History
Date Modified Username Field Change
2021-04-20 12:16 psanjuan New Issue
2021-04-20 12:16 psanjuan Assigned To => psanjuan
2021-06-03 15:51 psanjuan Summary Default Description should be taken for sales invoices when those are created from POS => Default Sales SII Description should be automatically taken for sales invoices when those are created from POS
2021-06-03 15:51 psanjuan Description Updated View Revisions
2021-06-03 15:51 psanjuan Proposed Solution updated
2021-06-04 16:19 psanjuan Note Added: 0129081
2021-06-07 14:04 rafaroda Tag Attached: NOR
2021-06-10 13:59 vmromanos Status new => scheduled
2021-06-10 13:59 vmromanos Assigned To psanjuan => vmromanos
2021-06-10 14:12 vmromanos Note Added: 0129348
2021-06-10 14:44 hgbot Note Added: 0129350
2021-06-28 16:24 psanjuan Note Added: 0129868
2021-06-28 16:27 psanjuan Note Edited: 0129350 View Revisions
2021-06-28 16:27 psanjuan Note Edited: 0129868 View Revisions
2021-06-28 16:30 psanjuan Note Edited: 0129868 View Revisions
2021-06-28 16:30 psanjuan Note Edited: 0129868 View Revisions
2021-06-28 16:39 psanjuan Note Edited: 0129868 View Revisions
2021-06-28 17:54 hgbot Resolution open => fixed
2021-06-28 17:54 hgbot Status scheduled => closed
2021-06-28 17:54 hgbot Note Added: 0129872
2021-06-28 17:54 hgbot Note Added: 0129873
2021-06-28 17:54 hgbot Note Added: 0129874


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker