Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046253
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Quotationsminoralways2021-04-12 15:132021-04-14 11:10
ReporterdmiguelezView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046253: Add Quotations filter in PaidReceiptsFilter.java Query

DescriptionWhen opening a Ticket is it possible to filter it by Document Type.

The filter for the Quotations DocType works differently as it is done for the rest of the DocTypes.
It is implemented in modalselector.js as:
if (flt.column === 'orderType' && flt.value === 'QT') {
          //When filtering by quotations, use the specific documentType filter
          criteria.remoteFilters.push({
            value: OB.MobileApp.model.get('terminal').terminalType
              .documentTypeForQuotations,
            columns: ['documentTypeId'],
            operator: '=',
            isId: true
          });
        }

This does not work in the new POS and also, it makes it functionally inconsistent, as it is filtering by the Terminal DocType for Quotations, but this is not how it is done for Returns.

Implement the logic in the java query, like it is done for returns, so it is compatible with the new POS and functionally consistent.
Steps To ReproduceIn the POS log in as Vallblanca.
In the menu click on Open Receipt.
Filter by Document Type Quotations.
Check that only Quotation documents are shown.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0127237)
hgbot (developer)
2021-04-12 15:23

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/376 [^]
(0127267)
hgbot (developer)
2021-04-14 11:10

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/376 [^]
(0127268)
hgbot (developer)
2021-04-14 11:10

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: bbfbf99ffcad1bbbc7516f5408842202e4563742
Author: David Miguelez <david.miguelez@openbravo.com>
Date: 2021-04-14T09:10:06+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bbfbf99ffcad1bbbc7516f5408842202e4563742 [^]

Fixes ISSUE-46253. Adds filter by Quotation DocType

---
M src/org/openbravo/retail/posterminal/PaidReceiptsFilter.java
---

- Issue History
Date Modified Username Field Change
2021-04-12 15:13 dmiguelez New Issue
2021-04-12 15:13 dmiguelez Assigned To => Retail
2021-04-12 15:13 dmiguelez Triggers an Emergency Pack => No
2021-04-12 15:23 hgbot Note Added: 0127237
2021-04-14 11:10 hgbot Resolution open => fixed
2021-04-14 11:10 hgbot Status new => closed
2021-04-14 11:10 hgbot Note Added: 0127267
2021-04-14 11:10 hgbot Fixed in Version => RR21Q3
2021-04-14 11:10 hgbot Note Added: 0127268


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker