Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046186
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Modules] Remittancemajoralways2021-03-30 16:142021-04-08 11:33
ReporterpsanjuanView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0046186: A new parameter needs to be added to remittance infrastructure named FILE_EXTENSION

DescriptionA new parameter needs to be added to remittance infrastructure named FILE_EXTENSION, therefore it is possible to setup the file extension type (.DAT or .XML) of SEPA remittances.
Steps To Reproducen/a
Proposed SolutionSee diff attached.
TagsNo tags attached.
Attached Filesdiff file icon remmitance.diff [^] (3,922 bytes) 2021-03-30 16:14 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0127034)
psanjuan (manager)
2021-03-30 16:21
edited on: 2021-03-30 16:41

Test this parameter works with any type of remittances, including SEPA ones.

(0127101)
psanjuan (manager)
2021-04-06 10:27

Podemos añadir ese parámetro en los módulos de sepa si queremos que cada vez que se genere un fichero tenga el nombre:

remittance.getDocumentNo() + "_" + remittance.getName() + "." + FILE_EXTENSION

en lugar de lo que saca ahora que es, si no recuerdo mal:

BANK.DAT

Esto básicamente es lo que hace la contribución de Practis.
(0127155)
markmm82 (developer)
2021-04-07 19:13

Install remittance module and apply remittance module dataset to F&B España.
Install SEPA infrastructure and apply SEPA module dataset to España.

Test Case 1 - Create Remittance File - Default extension (No parameter is added)

Go to Remittance type window and search by "Printable Remittance".
  Check it is set as "Posting Allowed" = Yes.
  Set Java Class Name = org.openbravo.sepa.iso20022.credittransfer.customertobank.pain.x001.x001.x03.report.CreditTransfer
  Save the remittance type.
Go to Accounting tab and select any ledger account for F&B International Group US Dollar general ledger; and select below accounts for F&B España Euro general ledger:
  57200 (Bancos) - Settlement Account
  43120 (Efectos comerciales) - Sent Account.
Go to Parameters tab and add a new one:
  Remittance Type = Printable Remittance
  Name = GENERATE_BUSINESSPARTNER_IBAN
  Value = Y

Go to Financial Account window and search "Cuenta de Banco". Set information for Bank Account like this:
  Generic Account No. = 0000000001
  IBAN = ES7921000813610123456789
  Country = Spain
  Bank Account Format = Use IBAN
  
Go to Payment Method tab and add Remittance to it.

Go to Business Partner window and create a new one named "Cliente Remesa", set up as shown below, in customer tab:
  Price list = "Tarifa de ventas"
  Payment Method = "Remittance"
  Payment Terms = "30 days"
  Financial Account = "Cuenta de Banco" .

Enter an spanish location for the business partner "Cliente Remesa".

Go to Bank Account tab and create a new one:
  Bank name = Test
  Country = Spain
  Bank Account Format = Use IBAN
  Generic Account No. = 00000000000000000000
  IBAN = ES7921000813610123456789

Go to Sales Invoice window and create a new one for F&B España and just created business partner, dated on today (for example 06-04-2021)
Select "Cerveza Ale 0,5L" product and enter "100" as invoiced quantity.
Complete, Pay and Post the invoice. Posting looks like:
  204.00 (43000) Clientes - DEBIT
  204.00 (70000) Ventas - CREDIT

Go to General Ledger report and run it with below setup:
  From date = Today (for example 06-04-2021)
  To date = Today (for example 06-04-2021)
  Organization = F&B España
  General Leger = F&B España EURO
  Show open balances = NO
  Business Partner = Cliente Remesa

Verify an amount equal to 204.00 is shown in DEBIT column for Account 43000.
Verify an amount equal to 204.00 is shown in CREDIT column for Account 70000.

Go to Remittance window and create a new one:
  Organization = F&B España
  Document Type = Remittance
  Document No. = 1000000 (Take note of this number as it is Autogenerated and will be used as part of the fine name)
  Transaction Date = 06-04-2021
  Expected Date = 06-05-2021
  Name = R1
  Financial Account = Cuenta de Banco - EUR
  Single Payment = No
Press Select Orders or Invoices. Select the invoice just created. Press Process, and process the remittance.

Execute "Create Remittance File" and press OK button.
  Notice a new file is automatically downloaded in the browser with the following name: 1000000_R1.DAT, having as filename the concatenation of the document number and the remittance name, and using as extension the default "DAT" extension.
  
  Notice content of generated file corresponds to a valid XML file:
  
  <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Document xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" [^] xmlns="urn:iso:std:iso:20022:tech:xsd:pain.001.001.03">
    <CstmrCdtTrfInitn>
        <GrpHdr>
            <MsgId>1000000</MsgId>
            <CreDtTm>2021-04-07T14:07:38</CreDtTm>
            <NbOfTxs>1</NbOfTxs>
            <CtrlSum>204.00</CtrlSum>
        </GrpHdr>
        <PmtInf>
            <PmtInfId>1000000-2021-04-06-10</PmtInfId>
            <PmtMtd>TRF</PmtMtd>
            <PmtTpInf>
                <InstrPrty>NORM</InstrPrty>
                <SvcLvl>
                    <Cd>SEPA</Cd>
                </SvcLvl>
            </PmtTpInf>
            <ReqdExctnDt>2021-04-06</ReqdExctnDt>
            <Dbtr/>
            <DbtrAcct>
                <Id>
                    <IBAN>ES7921000813610123456789</IBAN>
                </Id>
            </DbtrAcct>
            <DbtrAgt>
                <FinInstnId/>
            </DbtrAgt>
            <ChrgBr>SLEV</ChrgBr>
            <CdtTrfTxInf>
                <PmtId>
                    <InstrId>1000000-2021-04-06-10</InstrId>
                    <EndToEndId>F4BB975017484F938505BA0C2CED322D</EndToEndId>
                </PmtId>
                <Amt>
                    <InstdAmt Ccy="EUR">204.00</InstdAmt>
                </Amt>
                <CdtrAgt>
                    <FinInstnId/>
                </CdtrAgt>
                <Cdtr>
                    <PstlAdr>
                        <Ctry>ES</Ctry>
                        <AdrLine>ee ee 11100 Montevideo</AdrLine>
                    </PstlAdr>
                </Cdtr>
                <CdtrAcct>
                    <Id>
                        <IBAN>ES7921000813610123456789</IBAN>
                    </Id>
                </CdtrAcct>
                <RmtInf>
                    <Ustrd>Invoice No.: 1000358</Ustrd>
                </RmtInf>
            </CdtTrfTxInf>
        </PmtInf>
    </CstmrCdtTrfInitn>
</Document>
(0127156)
markmm82 (developer)
2021-04-07 19:21

Test Case 2 - Create Remittance File - File extension parameter is defined
  Execute Test Case 1.
  
  Go to Remittance type window and search by "Printable Remittance".
  Go to Parameters tab and add a new one:
    Remittance Type = Printable Remittance
    Name = FILE_EXTENSION
    Value = xml

  Go to Remittance window and select remittance created in Test Case 1.
    Name = R1
    
  Execute "Create Remittance File" and press OK button.
    Notice a new file is automatically downloaded in the browser with the following name: 1000000_R1.xml, having as filename the concatenation of the document number and the remittance name, and using as extension the one defined for the remittance type parameter: "xml" extension.
    Notice content of generated file corresponds to a valid XML file.
(0127157)
markmm82 (developer)
2021-04-07 19:29
edited on: 2021-04-07 20:41

Test Case 3: Using all SEPA Remittance Types
 Test test cases 1 and 2 by configuring each SEPA Remittance types and creating remittance of these types.
Notice in all the cases, the generated file will generated as:
<Remittance Doc No.> _ <Remittance Name> . <Remittance Type FILE_EXTENSION param value if defined, or "DAT" as default>

If the remittance type has FILE_EXTENSION parameter defined
For example extension file value = REM,
  Remittance Document No = 10000012
  Remittance name = R12
then generated file will be like this:
 10000012_R12.REM
Else if the remittance type has not FILE_EXTENSION parameter defined:
 10000012_R12.DAT

(0127165)
markmm82 (developer)
2021-04-07 20:40
edited on: 2021-04-07 20:42

Test Case 4a SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.02) - Without file extension parameter
  Execute Test Case 1 but configure the remittance type java class with the java class used by SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.02) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.coredirectdebit.customertobank.pain.x008.x001.x02.report.CoreDirectDebit
  Save the remittance type.
  After execute steps of test case 1 notice the file is generated as 1000000_R1.DAT
  
Test Case 4b SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.02) - With file extension parameter
  Execute Test Case 2 but configure the remittance type java class with the java class used by SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.02) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.coredirectdebit.customertobank.pain.x008.x001.x02.report.CoreDirectDebit
  Save the remittance type.
  After execute steps of test case 1 notice the file is generated as 1000000_R1.xml
  
Test Case 5a SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.03) - Without file extension parameter
  Execute Test Case 1 but configure the remittance type java class with the java class used by SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.03) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.coredirectdebit.customertobank.pain.x008.x001.x03.report.CoreDirectDebit
  Save the remittance type.
  After execute steps of test case 1 notice the file is generated as 1000000_R1.DAT
  
Test Case 5b SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.03) - With file extension parameter
  Execute Test Case 2 but configure the remittance type java class with the java class used by SEPA B2B Direct Debit Customer-to-Bank (pain.008.001.03) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.coredirectdebit.customertobank.pain.x008.x001.x03.report.CoreDirectDebit
  Save the remittance type.
  After execute steps of test case 2 notice the file is generated as 1000000_R1.xml

Test Case 6a SEPA Credit Transfer Customer-to-Bank (pain.001.001.03) - Without file extension parameter
  Execute Test Case 1 but configure the remittance type java class with the java class used by SEPA Credit Transfer Customer-to-Bank (pain.001.001.03) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.credittransfer.customertobank.pain.x001.x001.x03.report.CreditTransfer
  Save the remittance type.
  After execute steps of test case 1 notice the file is generated as 1000000_R1.DAT
  
Test Case 6b SEPA Credit Transfer Customer-to-Bank (pain.001.001.03) - With file extension parameter
  Execute Test Case 2 but configure the remittance type java class with the java class used by SEPA Credit Transfer Customer-to-Bank (pain.001.001.03) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.credittransfer.customertobank.pain.x001.x001.x03.report.CreditTransfer
  Save the remittance type.
  After execute steps of test case 2 notice the file is generated as 1000000_R1.xml
  
Test Case 7a SEPA Credit Transfer Customer-to-Bank (pain.001.001.04) - Without file extension parameter
  Execute Test Case 1 but configure the remittance type java class with the java class used by SEPA Credit Transfer Customer-to-Bank (pain.001.001.04) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.credittransfer.customertobank.pain.x001.x001.x04.report.CreditTransfer
  Save the remittance type.
  After execute steps of test case 1 notice the file is generated as 1000000_R1.DAT
  
Test Case 7b SEPA Credit Transfer Customer-to-Bank (pain.001.001.04) - With file extension parameter
  Execute Test Case 2 but configure the remittance type java class with the java class used by SSEPA Credit Transfer Customer-to-Bank (pain.001.001.04) remittance type to generate remittance file
  Go to Remittance type window and search by "Printable Remittance".
  Set Java Class Name = org.openbravo.sepa.iso20022.credittransfer.customertobank.pain.x001.x001.x04.report.CreditTransfer
  Save the remittance type.
  After execute steps of test case 2 notice the file is generated as 1000000_R1.xml

(0127166)
hgbot (developer)
2021-04-07 20:43

Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/2 [^]
(0127173)
hgbot (developer)
2021-04-08 11:33

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: 3604703dc458051c7a278c4635d4fc135aafa7a6
Author: Mark <markmm82@gmail.com>
Date: 2021-04-08T09:27:31+00:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/3604703dc458051c7a278c4635d4fc135aafa7a6 [^]

Fixes ISSUE-46186: Added FILE_EXTENSION new parameter to remittance infrastructure

A new parameter named FILE_EXTENSION has been added to the remittance infrastructure, therefore it is possible to setup the file extension type (.DAT or .XML) of SEPA remittances.

---
M src/org/openbravo/module/remittance/ad_actionbutton/CreateFile.java
---
(0127174)
hgbot (developer)
2021-04-08 11:33

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: 62ab172ebeabaf936e439b711df90d5a7f9dc1bc
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-04-08T09:27:31+00:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/62ab172ebeabaf936e439b711df90d5a7f9dc1bc [^]

Related to ISSUE-46186: code review improvements

Fixed unbalanced admin mode calls.
Use StringUtils.isBlank as it's stricter than StringUtils.isEmpty
Improved constant and method names
Added module's update info.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/remittance/ad_actionbutton/CreateFile.java
---
(0127175)
hgbot (developer)
2021-04-08 11:33

Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/2 [^]

- Issue History
Date Modified Username Field Change
2021-03-30 16:14 psanjuan New Issue
2021-03-30 16:14 psanjuan Assigned To => Triage Finance
2021-03-30 16:14 psanjuan File Added: remmitance.diff
2021-03-30 16:19 psanjuan Category SEPA Direct Debit Customer-to-Bank => Remittance
2021-03-30 16:19 psanjuan Summary A new parameter needs to be added to SEPA remittance => A new parameter needs to be added to remittance infrastructure
2021-03-30 16:19 psanjuan Description Updated View Revisions
2021-03-30 16:21 psanjuan Note Added: 0127034
2021-03-30 16:23 psanjuan Description Updated View Revisions
2021-03-30 16:23 psanjuan Summary A new parameter needs to be added to remittance infrastructure => A new parameter needs to be added to remittance infrastructure named FILE_EXTENSION
2021-03-30 16:41 psanjuan Note Edited: 0127034 View Revisions
2021-04-01 18:35 markmm82 Assigned To Triage Finance => markmm82
2021-04-01 18:35 markmm82 Status new => acknowledged
2021-04-06 02:01 markmm82 Status acknowledged => scheduled
2021-04-06 10:27 psanjuan Note Added: 0127101
2021-04-07 19:13 markmm82 Note Added: 0127155
2021-04-07 19:21 markmm82 Note Added: 0127156
2021-04-07 19:29 markmm82 Note Added: 0127157
2021-04-07 20:40 markmm82 Note Added: 0127165
2021-04-07 20:41 markmm82 Note Edited: 0127157 View Revisions
2021-04-07 20:42 markmm82 Note Edited: 0127165 View Revisions
2021-04-07 20:43 hgbot Note Added: 0127166
2021-04-08 11:33 hgbot Resolution open => fixed
2021-04-08 11:33 hgbot Status scheduled => closed
2021-04-08 11:33 hgbot Note Added: 0127173
2021-04-08 11:33 hgbot Note Added: 0127174
2021-04-08 11:33 hgbot Note Added: 0127175


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker