Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045473
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-11-20 11:032022-02-01 07:24
ReportershuehnerView Statuspublic 
Assigned ToTriage Platform Base 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045473: Add 2 more visible warnings for '>1 tabs on root-level of a window', check for '2 tabs has same seqno,tablevel'

DescriptionIn some projects/customization both of the following window definition mistakes happen sometimes:
a.) Define >1 tab on root-level of a window
b.) Have 2 tabs with same tablevel & seqno

The first one has a log.WARN in ViewComponent but that is hard to stop as only seen at runtime + hidden inside junit log output of CI junit ViewGeneration.

The second one does not have any specific check about it.

However both cause problems
a.) Random, wrong Tab ordering/parent child relation for the UI
b.) IndexesTest.testSubTabs crashing with 'more than one row returned by a subquery used as an expression'

That 2nd one is especially hard to debug to get to the wrong tab

Steps To ReproduceCreate the wrong window definition intentionally and check on UI behavior.
Attached screenshots for ad_tab information shows two concrete examples seen in some customer modules.
Proposed SolutionEither add a WADValidation or specific JUnit test searching for those two error and give a clear output what is wrong.
Probably WADValidation makes sense here as it exists as to check 'AD definition for tables/windows/tab' anyway.
TagsNo tags attached.
Attached Filespng file icon 45473-example-a.png [^] (20,265 bytes) 2020-11-20 11:04


png file icon 45473-example-b.png [^] (109,728 bytes) 2020-11-20 11:04

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on design defect 0045818 newTriage Finance Tracking issue: Modules adding tabs with same tablevel & seqno as an existing tab should be fixed 
Not all the children of this issue are yet resolved or closed.

-  Notes
(0124520)
shuehner (administrator)
2020-11-20 11:06

 Note there is existing code to check in StandardWindowComponent.getRootTabComponent()

It checks
- Case a.) from above
- Does NOT check case b.)
- But checks an additional third case

That new check probably should cover/take-over all three of those.
(0124526)
shuehner (administrator)
2020-11-20 11:14

 Example warning from getRootTabComponent for case a.)

    [junit] 09:37:32.651 WARN org.openbravo.client.application.window.StandardWindowComponent - Window ABC Activity 134 has more than on tab on level 0, choosing an arbitrary root tab

- Issue History
Date Modified Username Field Change
2020-11-20 11:03 shuehner New Issue
2020-11-20 11:03 shuehner Assigned To => platform
2020-11-20 11:03 shuehner Modules => Core
2020-11-20 11:03 shuehner Triggers an Emergency Pack => No
2020-11-20 11:04 shuehner File Added: 45473-example-a.png
2020-11-20 11:04 shuehner File Added: 45473-example-b.png
2020-11-20 11:06 shuehner Note Added: 0124520
2020-11-20 11:14 shuehner Note Added: 0124526
2021-01-29 14:08 shuehner Relationship added depends on 0045818
2022-02-01 07:24 alostale Assigned To platform => Triage Platform Base

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker