Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045259
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-10-19 17:542020-10-21 16:46
ReportershuehnerView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045259: mobile-test remove javascript dependency by cleaning up no-op code

Descriptionthe "ant report" ant target in mobile test as effectively disabled by adding some message + stopping execution.

However that was done adding indirect javascript dependency to the build.xml which fail when run with Java>=15 as Java does no longer ship a JS engine.

Attached patch1 instead just cleans up the build.xml by removing the "ant report" target body.
ant target itself is kept to avoid needing to change jenkins/CI calling it unconditionally for now.

patch3 stops calling 'ant report' in awo jobs as just not useful

patch2 removes other 'test.retail' commented out before as it before called 'ant report' and seems to serve not extra purpose to be kept.
patch4 deletes another commented out target 'run.suites'
Steps To Reproduce-
TagsNo tags attached.
Attached Filesdiff file icon mobile-test-1-remove-ant-report-instead-of-disabling-it-with-javascript.diff [^] (2,364 bytes) 2020-10-19 17:54 [Show Content]
diff file icon mobile-test-2-remove-commented-out-test.retail.diff [^] (3,319 bytes) 2020-10-19 17:54 [Show Content]
diff file icon mobile-test-3-awo-remove-ant-report-call.diff [^] (350 bytes) 2020-10-19 17:54 [Show Content]
diff file icon mobile-test-4-remove-commented-out-run-suites.diff [^] (1,238 bytes) 2020-10-19 17:57 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0045261 closedcberner mobile-test disable report ant target and remove usage of javascript 

-  Notes
(0123823)
hgbot (developer)
2020-10-21 13:40

Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/50 [^]
(0123825)
hgbot (developer)
2020-10-21 16:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 7d5a9f645c3e45ba01f873cfe91bb67ddc06c63f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-21T11:25:18+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/7d5a9f645c3e45ba01f873cfe91bb67ddc06c63f [^]

Fixed ISSUE-45259: Removed deprecated ant targets
* Removed ant target report as its not useful for awo

---
M build.xml
---
(0123826)
hgbot (developer)
2020-10-21 16:46

Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/50 [^]

- Issue History
Date Modified Username Field Change
2020-10-19 17:54 shuehner New Issue
2020-10-19 17:54 shuehner Assigned To => Retail
2020-10-19 17:54 shuehner File Added: mobile-test-1-remove-ant-report-instead-of-disabling-it-with-javascript.diff
2020-10-19 17:54 shuehner Triggers an Emergency Pack => No
2020-10-19 17:54 shuehner File Added: mobile-test-2-remove-commented-out-test.retail.diff
2020-10-19 17:54 shuehner File Added: mobile-test-3-awo-remove-ant-report-call.diff
2020-10-19 17:54 shuehner Note Added: 0123782
2020-10-19 17:57 shuehner File Added: mobile-test-4-remove-commented-out-run-suites.diff
2020-10-19 17:57 shuehner Note Deleted: 0123782
2020-10-19 17:58 shuehner Description Updated View Revisions
2020-10-20 07:23 marvintm Resolution time => 1604098800
2020-10-20 13:57 cberner Relationship added related to 0045261
2020-10-21 13:40 hgbot Note Added: 0123823
2020-10-21 16:46 hgbot Resolution open => fixed
2020-10-21 16:46 hgbot Status new => closed
2020-10-21 16:46 hgbot Note Added: 0123825
2020-10-21 16:46 hgbot Note Added: 0123826


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker