Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044797 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Invoices Register Book | minor | have not tried | 2020-08-12 16:41 | 2020-10-20 15:46 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Mery Anelo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0044797: OBIRB_SE_BusinessPartnerTaxId is an old-style callout and should be refactored to use SimpleCallout | |||||||
| Description | This callout is one of the few ones left over not not refactored to be SimpleCallout (issue 36067 refactored every supported module except a few one). This bug exists in both the main module version and also in the cashvat variant and should be fixed in both. | |||||||
| Steps To Reproduce | product/pmods/org.openbravo.module.invoicesregisterbook/src/org/openbravo/module/invoicesregisterbook/obirb_callouts/OBIRB_SE_BusinessPartnerTaxId.java: resultado.append("var respuesta = new Array("); product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/src/org/openbravo/module/invoicesregisterbook/obirb_callouts/OBIRB_SE_BusinessPartnerTaxId.java: resultado.append("var respuesta = new Array("); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0122095) shuehner (administrator) 2020-08-17 12:24 |
When fixing this issue the ad_model_object_mapping entries are to be removed as well (not required and SimpleCallout subclasses are not servlets) |
|
(0122696) Mery Anelo (developer) 2020-09-05 03:02 |
Test plan: - Login as F&B Internation Group Admin - Create many invoices for different Business Partners - Make sure that this selected Business Partner has the "Tax ID" field configured. - Process and post the invoices created. - Configure "Invoice Register Book". - Create a new record in the "Invoice Register Book" window for the same organization selected in the invoices. - Run the "Create" process and note that the lines related to the invoices created has been added. Check that the lines have the correct value for "Tax Id". Also, you can try to create a line from the "Invoice Register Book" window, "Lines" tab and select a different business partner and see how this "Tax ID" field changes for the selected BP. |
|
(0122929) hgbot (developer) 2020-09-10 17:02 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/2 [^] |
|
(0122979) hgbot (developer) 2020-09-12 00:11 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/merge_requests/1 [^] |
|
(0123771) hgbot (developer) 2020-10-19 16:16 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^] Changeset: 2b52a8229664bca422dad7d9fe8a6bb289cedbc0 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-10T12:01:33-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/2b52a8229664bca422dad7d9fe8a6bb289cedbc0 [^] Fixed BUG-44797: Value in Tax ID field to SimpleCallout OBIRB_SE_BusinessPartnerTaxId transformed from old-style callout to SimpleCallout. --- M src/org/openbravo/module/invoicesregisterbook/obirb_callouts/OBIRB_SE_BusinessPartnerTaxId.java --- |
|
(0123772) hgbot (developer) 2020-10-19 16:16 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^] Changeset: eacbb4df80a5103624c8d0e9480e83b6bb16700d Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-11T19:06:55-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/eacbb4df80a5103624c8d0e9480e83b6bb16700d [^] Fixed BUG-44797: Value in Tax ID field to SimpleCallout Remove unnecessary debug line. --- M src/org/openbravo/module/invoicesregisterbook/obirb_callouts/OBIRB_SE_BusinessPartnerTaxId.java --- |
|
(0123773) hgbot (developer) 2020-10-19 16:16 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^] Changeset: b8b1d4ab1d8e56e871a2d0fcf54e75b2ee4e7bf9 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-28T21:41:04-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/b8b1d4ab1d8e56e871a2d0fcf54e75b2ee4e7bf9 [^] Fixed BUG-44797: Value in Tax ID field to SimpleCallout AD_MODEL_OBJECT_MAPPING entry removed. --- M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml --- |
|
(0123774) hgbot (developer) 2020-10-19 16:16 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/2 [^] |
|
(0123815) hgbot (developer) 2020-10-20 15:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat [^] Changeset: d0d846cad85d5937d1b6f7a98b1ea5914c5f7fc0 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-11T19:03:26-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/commit/d0d846cad85d5937d1b6f7a98b1ea5914c5f7fc0 [^] Fixed BUG-44797: Value in Tax ID field to SimpleCallout OBIRB_SE_BusinessPartnerTaxId transformed from old-style callout to SimpleCallout. --- M src/org/openbravo/module/invoicesregisterbook/obirb_callouts/OBIRB_SE_BusinessPartnerTaxId.java --- |
|
(0123816) hgbot (developer) 2020-10-20 15:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat [^] Changeset: 39be1f6520af6c3563d769372903ca9036092ad0 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-28T21:45:48-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/commit/39be1f6520af6c3563d769372903ca9036092ad0 [^] Fixed BUG-44797: Value in Tax ID field to SimpleCallout AD_MODEL_OBJECT_MAPPING entry removed. --- M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml --- |
|
(0123817) hgbot (developer) 2020-10-20 15:46 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/merge_requests/1 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-08-12 16:41 | shuehner | New Issue | |
| 2020-08-12 16:41 | shuehner | Assigned To | => Jorge Bravo |
| 2020-08-12 16:41 | shuehner | Relationship added | blocks 0044795 |
| 2020-08-12 16:42 | shuehner | Issue cloned | 0044798 |
| 2020-08-12 16:44 | shuehner | Description Updated | View Revisions |
| 2020-08-12 16:44 | shuehner | Steps to Reproduce Updated | View Revisions |
| 2020-08-14 14:26 | Jorge Bravo | Assigned To | Jorge Bravo => Mery Anelo |
| 2020-08-17 12:24 | shuehner | Note Added: 0122095 | |
| 2020-09-05 02:45 | Mery Anelo | Status | new => scheduled |
| 2020-09-05 03:02 | Mery Anelo | Note Added: 0122696 | |
| 2020-09-10 17:02 | hgbot | Note Added: 0122929 | |
| 2020-09-12 00:11 | hgbot | Note Added: 0122979 | |
| 2020-10-19 16:16 | hgbot | Resolution | open => fixed |
| 2020-10-19 16:16 | hgbot | Status | scheduled => closed |
| 2020-10-19 16:16 | hgbot | Note Added: 0123771 | |
| 2020-10-19 16:16 | hgbot | Note Added: 0123772 | |
| 2020-10-19 16:16 | hgbot | Note Added: 0123773 | |
| 2020-10-19 16:16 | hgbot | Note Added: 0123774 | |
| 2020-10-20 15:46 | hgbot | Note Added: 0123815 | |
| 2020-10-20 15:46 | hgbot | Note Added: 0123816 | |
| 2020-10-20 15:46 | hgbot | Note Added: 0123817 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |