0044365: Override existing promotions doesn't work with manual discounts

Description

If a line has an automatic discount applied and you add a manual discount with "override existing promotions", both discounts are applied. However, only the manual one should be applied.

Steps To Reproduce

0. Log into https://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^]
1. Create a 20% automatic discount for ALL products "price adjustment"
2. Create a 50% manual discount for all products "user defined percentage". Also uncheck "apply next discount/promotion" to make sure that it should override other discounts.
3. Log into https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]
4. Add any product and check that 20% discount is applied.
5. Select the line and click "discount" and add to the line the manual "50%" discount with the option "override existing promotions" selected.
6. Both discounts are applied while only the manual one should be.

Proposed Solution

Only the manual discount should be applied

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0120873) joniturralde93 (developer) 2020-06-16 16:15	Expected behavior. "Override existing promotions" only applies to other manual discounts, while "apply next promotion" in backoffice only applies to other automatic discounts. But you cannot avoid automatic discounts by adding a manual discount or vice versa. Expected behavior.

Issue History
Date Modified	Username	Field	Change
2020-06-16 12:32	joniturralde93	New Issue
2020-06-16 12:32	joniturralde93	Assigned To	=> Retail
2020-06-16 12:32	joniturralde93	Resolution time	=> 1594072800
2020-06-16 12:32	joniturralde93	Triggers an Emergency Pack	=> No
2020-06-16 12:35	Practics	Issue Monitored: Practics
2020-06-16 16:15	joniturralde93	Review Assigned To	=> joniturralde93
2020-06-16 16:15	joniturralde93	Note Added: 0120873
2020-06-16 16:15	joniturralde93	Status	new => closed
2020-06-16 16:15	joniturralde93	Resolution	open => no change required