Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044026
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] B. User interfaceminorhave not tried2020-05-11 15:492023-01-31 16:10
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044026: Review and probably removed old jrxml report templates replaced in 2013

DescriptionIn 2013 for 3.0MP24 release 'new' jrxml templates where added in issue 23745

However the old templates are still present in pi today in 2020 causing extra work i.e. for translations and sometimes mass-updates to 'all jrxml' files.


List of files (old & new):
./src/org/openbravo/erpReports/C_OrderJR.jrxml
./src/org/openbravo/erpReports/C_OrderJR_new.jrxml
./src/org/openbravo/erpReports/C_OrderLinesJR.jrxml
./src/org/openbravo/erpReports/C_OrderLinesJR_new.jrxml
./src/org/openbravo/erpReports/C_OrderLinesTaxIncludedJR.jrxml
./src/org/openbravo/erpReports/C_OrderLinesTaxIncludedJR_new.jrxml
./src/org/openbravo/erpReports/RptC_Invoice.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_Lines.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_Lines_new.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_new.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_TaxLines.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_TaxLines_new.jrxml
./src/org/openbravo/erpReports/RptC_Order_TaxLines.jrxml
./src/org/openbravo/erpReports/RptC_Order_TaxLines_new.jrxml
./src/org/openbravo/erpReports/RptM_InOut.jrxml
./src/org/openbravo/erpReports/Rptm_InOut_Lines.jrxml
./src/org/openbravo/erpReports/Rptm_InOut_Lines_new.jrxml
./src/org/openbravo/erpReports/RptM_InOut_new.jrxml

Review is needed to double-check if those 'old' files are completely unused and if they can be safely removed.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0023745 closedSandrahuguet New printable jrxml form for orders, invoices goods shipment and goods receipt 
blocks design defect 0032688 acknowledgedTriage Platform Base remove unused resources 

-  Notes
(0119738)
shuehner (administrator)
2020-05-11 15:53

Potential leftover usages today:
a.) src-util/modulescript/src/org/openbravo/modulescript/CreateDoctypeTemplate.java
Very old module-script still references the 'old file'
b.) While issues 23745 updated sampledata + 'Initial Client' dataset in 20013
  No code seems to be around to update existing installs to 'new files'

For that item b.) if correct need to decide how to deal with those cases today in 2020. I.e. BuildValidation to block updates or force move leftover instances to new files.

For removal:
Several of the jrxml ('old' versions) have manual java file in erpReports related to them which is also unused.
Examples are RptC_Invoice.java & RptC_Order.java those should also be cleanup while working on this issue.
(0132183)
vmromanos (manager)
2021-10-06 10:15
edited on: 2021-10-06 10:16

These are the reports that can be removed because they are not used anymore:
./src/org/openbravo/erpReports/C_OrderJR.jrxml
./src/org/openbravo/erpReports/C_OrderLinesJR.jrxml
./src/org/openbravo/erpReports/C_OrderLinesTaxIncludedJR.jrxml
./src/org/openbravo/erpReports/RptC_Order_TaxLines.jrxml

./src/org/openbravo/erpReports/RptC_Invoice.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_Lines.jrxml
./src/org/openbravo/erpReports/RptC_Invoice_TaxLines.jrxml

./src/org/openbravo/erpReports/RptM_InOut.jrxml
./src/org/openbravo/erpReports/Rptm_InOut_Lines.jrxml



The following java classes are no longer used and they can be removed:
./src/org/openbravo/erpReports/RptC_Order.java
./src/org/openbravo/erpReports/RptC_Invoice.java



The module script CreateDoctypeTemplate makes reference to one of the reports about to be removed. It has a last version ModuleScriptExecutionLimits that points to Openbravo 2.50, so we can safely remove the associated files:
./src-util/modulescript/src/org/openbravo/modulescript/CreateDoctypeTemplate.java
./src-util/modulescript/src/org/openbravo/modulescript/CreateDoctypeTemplate_Data.xsql



As part of the removal, please clean up also any reference to those in the tables:
AD_TextInterfaces
AD_Model_Object
AD_Model_Object_Mapping



Finally change the name attribute within the jrxml files to avoid confusions:
./src/org/openbravo/erpReports/RptM_RMInOut.jrxml: name="RptM_InOut" --> name="RptM_RMInOut"
./src/org/openbravo/erpReports/RptM_RMInOut_Lines.jrxml: name="Rptm_InOut_Lines" --> name="RptM_RMInOut_Lines"
Most likely these files were created as a copy of the files that we are about to remove, and it was forgotten to change that attribute.

(0132362)
hgbot (developer)
2021-10-15 11:28

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/441 [^]
(0144376)
hgbot (developer)
2022-12-02 15:14

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/38 [^]
(0144377)
hgbot (developer)
2022-12-02 15:19

Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/33 [^]
(0144378)
hgbot (developer)
2022-12-02 15:23

Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/51 [^]
(0144379)
hgbot (developer)
2022-12-02 15:26

Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/merge_requests/13 [^]
(0146071)
hgbot (developer)
2023-01-31 11:40

Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/40 [^]
(0146086)
hgbot (developer)
2023-01-31 15:40

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata [^]
Changeset: f83f59577ea5268a4eaa1eb5b6eff02b3f42f5dd
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 10:14:51
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/commit/f83f59577ea5268a4eaa1eb5b6eff02b3f42f5dd [^]

Related to ISSUE-44026. Remove old/obsolete jrxml report templates

Remove ad_process_access entries for deleted processes:
- ad_process_id=110
- ad_process_id=116

---
M referencedata/sampledata/AWO_QA/AD_PROCESS_ACCESS.xml
---
(0146087)
hgbot (developer)
2023-01-31 15:40

Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/merge_requests/13 [^]
(0146088)
hgbot (developer)
2023-01-31 15:40

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 7cb27592e35434c500aabb80bd06881e43c90471
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 11:37:44
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/7cb27592e35434c500aabb80bd06881e43c90471 [^]

Related to ISSUE-44026. Accept api-change (remove 2 obsolete processes)

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
---
(0146089)
hgbot (developer)
2023-01-31 15:40

Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/40 [^]
(0146090)
hgbot (developer)
2023-01-31 15:40

Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/51 [^]
(0146091)
hgbot (developer)
2023-01-31 15:40

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: a578116cc1344640d9d7dd32e08292fb30e47fe1
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 10:13:38
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/a578116cc1344640d9d7dd32e08292fb30e47fe1 [^]

Related to ISSUE-44026. Remove old/obsolete jrxml report templates

Remove ad_process_access entries for deleted processes:
- ad_process_id=110
- ad_process_id=116

---
M referencedata/sampledata/The_White_Valley_Group/AD_PROCESS_ACCESS.xml
---
(0146092)
hgbot (developer)
2023-01-31 15:40

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^]
Changeset: 318709e57100ee0359f58bcdd293fac3989d2115
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 10:12:32
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/318709e57100ee0359f58bcdd293fac3989d2115 [^]

Related to ISSUE-44026. Remove old/obsolete jrxml report templates

Remove ad_process_access entries for deleted processes:
- ad_process_id=110
- ad_process_id=116

---
M referencedata/sampledata/Retail_Test/AD_PROCESS_ACCESS.xml
---
(0146093)
hgbot (developer)
2023-01-31 15:40

Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/33 [^]
(0146094)
hgbot (developer)
2023-01-31 15:40

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 24cbc998bdc229dc56dc34ab0e14af4837cf2dab
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 10:09:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/24cbc998bdc229dc56dc34ab0e14af4837cf2dab [^]

Related to ISSUE-44026. Remove old/obsolete jrxml report templates

Remove ad_process_access entries for deleted processes:
- ad_process_id=110
- ad_process_id=116

---
M referencedata/sampledata/The_White_Valley_Group/AD_PROCESS_ACCESS.xml
---
(0146095)
hgbot (developer)
2023-01-31 15:40

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/38 [^]
(0146096)
hgbot (developer)
2023-01-31 15:41

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/441 [^]
(0146097)
hgbot (developer)
2023-01-31 15:41

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0efae9cda9c4447e360de52dacfbbaa0fe1e1649
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 10:16:49
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0efae9cda9c4447e360de52dacfbbaa0fe1e1649 [^]

Fixes ISSUE-44026. Remove old/obsolete jrxml report templates

Issue 23745 from 2013 added new jrxml report template called _new.jrxml
Sampledata & Initial_Setup.xml was also updated back then to use the new
files already.

This removed all the old version of those 3 reports still left today.

- C_OrderJR.jrxml
  - Remove main + 2 secondary jrxml files (and ad_textinterfaces entry)
- Remove unused RptC_Invoice.java pointing to it with the its related
  AD entries (ad_process, ad_model_object*)
- RptC_Invoice.jrxml
  - Same as C_OrderJR (jrxml, java pointing to it and ad_process, ...)

- For both above ad 2 ad_process entires were removed remove the
  ad_process_access entries from the sampledata also.

- RptM_InOut.jrxml
  - Remove jrxml + subreport and related ad_textinterfaces entries
  - Remove related modulescript: CreateDoctypeTemplate
    This was gated to only run until 2.50.17398 (<2.50MP18)
- Update misleading text-references in two other jrxml files
  to stop (wrongly) pointing to the remove files

- One ad_textinterfaces entries 'moves' from ad_module_id= without
  filename and is now appearing in paymentreport module.
  Happens automatically by translation code.

---
M modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M referencedata/sampledata/F_B_International_Group/AD_PROCESS_ACCESS.xml
M referencedata/sampledata/QA_Testing/AD_PROCESS_ACCESS.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpReports/RptM_RMInOut.jrxml
M src/org/openbravo/erpReports/RptM_RMInOut_Lines.jrxml
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateDoctypeTemplate.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateDoctypeTemplateData.class
R src-util/modulescript/src/org/openbravo/modulescript/CreateDoctypeTemplate.java
R src-util/modulescript/src/org/openbravo/modulescript/CreateDoctypeTemplate_Data.xsql
R src/org/openbravo/erpReports/C_OrderJR.jrxml
R src/org/openbravo/erpReports/C_OrderLinesJR.jrxml
R src/org/openbravo/erpReports/C_OrderLinesTaxIncludedJR.jrxml
R src/org/openbravo/erpReports/RptC_Invoice.java
R src/org/openbravo/erpReports/RptC_Invoice.jrxml
R src/org/openbravo/erpReports/RptC_Invoice_Header_data.xsql
R src/org/openbravo/erpReports/RptC_Invoice_Lines.jrxml
R src/org/openbravo/erpReports/RptC_Invoice_TaxLines.jrxml
R src/org/openbravo/erpReports/RptC_Invoice_data.xsql
R src/org/openbravo/erpReports/RptC_Order.java
R src/org/openbravo/erpReports/RptC_Order_Header_data.xsql
R src/org/openbravo/erpReports/RptC_Order_TaxLines.jrxml
R src/org/openbravo/erpReports/RptM_InOut.jrxml
R src/org/openbravo/erpReports/Rptm_InOut_Lines.jrxml
---
(0146099)
hgbot (developer)
2023-01-31 16:10

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: 32d21c250e919087e85753e83ea96c22f0feedaa
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 31-01-2023 16:09:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/32d21c250e919087e85753e83ea96c22f0feedaa [^]

Related to ISSUE-44026. Remove two more ad_process_access entries

Those where recently added and should have been removed in previous
commit.

---
M referencedata/sampledata/The_White_Valley_Group/AD_PROCESS_ACCESS.xml
---

- Issue History
Date Modified Username Field Change
2020-05-11 15:49 shuehner New Issue
2020-05-11 15:49 shuehner Assigned To => platform
2020-05-11 15:49 shuehner Modules => Core
2020-05-11 15:49 shuehner Triggers an Emergency Pack => No
2020-05-11 15:50 shuehner Relationship added blocks 0032688
2020-05-11 15:50 shuehner Relationship added related to 0023745
2020-05-11 15:53 shuehner Note Added: 0119738
2020-05-11 16:00 shuehner Assigned To platform => Triage Finance
2021-10-06 10:15 vmromanos Note Added: 0132183
2021-10-06 10:16 vmromanos Note Edited: 0132183 View Revisions
2021-10-15 11:28 hgbot Note Added: 0132362
2022-12-02 15:14 hgbot Note Added: 0144376
2022-12-02 15:19 hgbot Note Added: 0144377
2022-12-02 15:23 hgbot Note Added: 0144378
2022-12-02 15:26 hgbot Note Added: 0144379
2023-01-31 11:40 hgbot Note Added: 0146071
2023-01-31 15:40 hgbot Note Added: 0146086
2023-01-31 15:40 hgbot Note Added: 0146087
2023-01-31 15:40 hgbot Note Added: 0146088
2023-01-31 15:40 hgbot Note Added: 0146089
2023-01-31 15:40 hgbot Note Added: 0146090
2023-01-31 15:40 hgbot Note Added: 0146091
2023-01-31 15:40 hgbot Note Added: 0146092
2023-01-31 15:40 hgbot Note Added: 0146093
2023-01-31 15:40 hgbot Note Added: 0146094
2023-01-31 15:40 hgbot Note Added: 0146095
2023-01-31 15:41 hgbot Resolution open => fixed
2023-01-31 15:41 hgbot Status new => closed
2023-01-31 15:41 hgbot Note Added: 0146096
2023-01-31 15:41 hgbot Fixed in Version => PR23Q2
2023-01-31 15:41 hgbot Note Added: 0146097
2023-01-31 15:47 shuehner Assigned To Triage Finance => shuehner
2023-01-31 16:10 hgbot Note Added: 0146099


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker