Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043388 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2020-03-02 16:19 | 2020-03-06 14:21 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR20Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 864d0cc875ac | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | dmiguelez | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043388: Apply new HQL Style in ConversionRateEventHandler.java | |||||||
| Description | ConversionRateEventHandler.java has one HQL query with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0118292) inigo_lerga (reporter) 2020-03-03 12:14 |
--Test Plan Mantis HQL queries-- As the F&B International Group Admin role: - Go to the Conversion Rates window and create a new record with "AOA" as Currency. Set any date desired prior to today and "1" as Multiple Rate By field. Leave the rest of fields as default. Save the record. #In this moment the modified HQL is executed# |
|
(0118386) dmiguelez (developer) 2020-03-06 14:19 |
Test Plan II Log in as F&B International Group Admin Go to Conversion Rates Window and create a new record with: * Organization: * * Currency: USD * To Currency: EUR * Valid From Date: 06-03-2020 * Multiply Rate By: 2 Try to save the record, it fails with the message: Saving failed. There are different conversion rates with same dates. |
|
(0118387) hgbot (developer) 2020-03-06 14:20 |
Repository: erp/devel/pi Changeset: 864d0cc875aceea8f2cc80ca9daac4f834e14dee Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Tue Mar 03 09:46:52 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/864d0cc875aceea8f2cc80ca9daac4f834e14dee [^] fixes BUG-43388:Applied new HQL Style --- M src/org/openbravo/event/ConversionRateEventHandler.java --- |
|
(0118388) hgbot (developer) 2020-03-06 14:20 |
Repository: erp/devel/pi Changeset: 2e054b8f16dcaf7665537e2ec3a3c6bd43d4e9c7 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Tue Mar 03 09:59:55 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/2e054b8f16dcaf7665537e2ec3a3c6bd43d4e9c7 [^] related to ISSUE-43388: Finals added -Finals added -No Sonarlint suggestions found --- M src/org/openbravo/event/ConversionRateEventHandler.java --- |
|
(0118389) hgbot (developer) 2020-03-06 14:20 |
Repository: erp/devel/pi Changeset: 9466c9337936130a83c31150391ca3a764491afb Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Fri Mar 06 14:20:35 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/9466c9337936130a83c31150391ca3a764491afb [^] Related to ISSUE-43388. Code Review changes: Retrieve first the query into an object and then do the !list.isEmpty() comparison. The reason for this change is to make more obvius the list empty comparison while reading the code. --- M src/org/openbravo/event/ConversionRateEventHandler.java --- |
|
(0118390) dmiguelez (developer) 2020-03-06 14:21 |
Code Review + Testing Ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-03-02 16:19 | inigo_lerga | New Issue | |
| 2020-03-02 16:19 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-03-02 16:19 | inigo_lerga | Modules | => Core |
| 2020-03-02 16:19 | inigo_lerga | Triggers an Emergency Pack | => No |
| 2020-03-02 16:19 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-03-02 16:19 | inigo_lerga | Status | new => scheduled |
| 2020-03-03 12:14 | inigo_lerga | Note Added: 0118292 | |
| 2020-03-06 14:19 | dmiguelez | Note Added: 0118386 | |
| 2020-03-06 14:20 | hgbot | Checkin | |
| 2020-03-06 14:20 | hgbot | Note Added: 0118387 | |
| 2020-03-06 14:20 | hgbot | Status | scheduled => resolved |
| 2020-03-06 14:20 | hgbot | Resolution | open => fixed |
| 2020-03-06 14:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/864d0cc875aceea8f2cc80ca9daac4f834e14dee [^] |
| 2020-03-06 14:20 | hgbot | Checkin | |
| 2020-03-06 14:20 | hgbot | Note Added: 0118388 | |
| 2020-03-06 14:20 | hgbot | Checkin | |
| 2020-03-06 14:20 | hgbot | Note Added: 0118389 | |
| 2020-03-06 14:21 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-03-06 14:21 | dmiguelez | Note Added: 0118390 | |
| 2020-03-06 14:21 | dmiguelez | Status | resolved => closed |
| 2020-03-06 14:21 | dmiguelez | Fixed in Version | => 3.0PR20Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |