Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043320
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-25 10:342020-03-02 18:54
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision78a01293cd69
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043320: Apply new HQL Style in GeneralAccountingReports.java

DescriptionGeneralAccountingReports.java has three HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118094)
inigo_lerga (reporter)
2020-02-25 13:34

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Balance sheet and P&L structure window
    Select "F&B España, S.A. US/A/Euro" as General Ledger.
    Select "Balance de Situación" as Accounting Report.

    #In this moment one of the modified HQLs is executed#

    Select "F&B International Group" as Organization and "Heading"
    as Acount Level.
    Select "2011 (Calendario España)" as Year and "2018
    (Calendario España)" as Reference Year.
    Press the PDF Format button.
    
    #In this moment two of the modified HQLs are executed#
(0118273)
hgbot (developer)
2020-03-02 18:53

 Repository: erp/devel/pi
Changeset: 78a01293cd69f019a0f3bca6bbb0b3be2b95e99a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 25 13:35:51 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/78a01293cd69f019a0f3bca6bbb0b3be2b95e99a [^]

fixes BUG-43320:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0118274)
hgbot (developer)
2020-03-02 18:53

 Repository: erp/devel/pi
Changeset: 5074d9bfb8e7cbdaaafda3fb82496354d3acb9aa
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Feb 25 16:17:19 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5074d9bfb8e7cbdaaafda3fb82496354d3acb9aa [^]

related to ISSUE-43320: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied
-Pieces of code refactores do be more legible.

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0118275)
hgbot (developer)
2020-03-02 18:53

 Repository: erp/devel/pi
Changeset: b82dcc5d24556c41f503f670a5a688129aabe89f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 17:58:58 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b82dcc5d24556c41f503f670a5a688129aabe89f [^]

Related to ISSUE-43320. Use id's to compare inside hql queries.

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0118276)
hgbot (developer)
2020-03-02 18:53

 Repository: erp/devel/pi
Changeset: 6a1a38fa540d9c41c63559fd32086f5f0b2659ff
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 18:00:07 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6a1a38fa540d9c41c63559fd32086f5f0b2659ff [^]

Related to ISSUE-43320. Reordered methods

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0118277)
hgbot (developer)
2020-03-02 18:53

 Repository: erp/devel/pi
Changeset: c8824eb6e7898b9110d0654a414e160070127b73
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Mar 02 18:16:55 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c8824eb6e7898b9110d0654a414e160070127b73 [^]

Related to ISSUE-43320. Code Review Changes:
* Revert refactor that extracted code into method as it was
  mixing logic between methods.

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
---
(0118278)
dmiguelez (developer)
2020-03-02 18:54

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-25 10:34 inigo_lerga New Issue
2020-02-25 10:34 inigo_lerga Assigned To => inigo_lerga
2020-02-25 10:34 inigo_lerga Modules => Core
2020-02-25 10:34 inigo_lerga Triggers an Emergency Pack => No
2020-02-25 10:34 inigo_lerga Relationship added related to 0041287
2020-02-25 10:35 inigo_lerga Status new => scheduled
2020-02-25 13:34 inigo_lerga Note Added: 0118094
2020-03-02 18:53 hgbot Checkin
2020-03-02 18:53 hgbot Note Added: 0118273
2020-03-02 18:53 hgbot Status scheduled => resolved
2020-03-02 18:53 hgbot Resolution open => fixed
2020-03-02 18:53 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/78a01293cd69f019a0f3bca6bbb0b3be2b95e99a [^]
2020-03-02 18:53 hgbot Checkin
2020-03-02 18:53 hgbot Note Added: 0118274
2020-03-02 18:53 hgbot Checkin
2020-03-02 18:53 hgbot Note Added: 0118275
2020-03-02 18:53 hgbot Checkin
2020-03-02 18:53 hgbot Note Added: 0118276
2020-03-02 18:53 hgbot Checkin
2020-03-02 18:53 hgbot Note Added: 0118277
2020-03-02 18:54 dmiguelez Review Assigned To => dmiguelez
2020-03-02 18:54 dmiguelez Note Added: 0118278
2020-03-02 18:54 dmiguelez Status resolved => closed
2020-03-02 18:54 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker