Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0042200
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2019-11-06 08:422020-02-19 16:35
ReporteradrianromeroView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR20Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042200: Remove use of OB.Data.OrderFindTaxes in Giftcards module

DescriptionGift cards module makes use of OB.DATA.OrderFindTaxes function to check a giftcard has tax exempt before adding a gift card to a receipt. This function must not be used as it is a private method of the taxes engine and will change.

This check is a configuration check that must not be verified in execution but during the configuration.

This is the code that must be removed: https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/file/tip/web/org.openbravo.retail.giftcards/js/components/lineproperties.js#l108 [^]
Steps To ReproduceN/A
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0115683)
hgbot (developer)
2019-11-19 10:52

Repository: tools/automation/pi-mobile
Changeset: f7285607b5faced1111f7db3046f88fb79cf4255
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Nov 19 10:52:37 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f7285607b5faced1111f7db3046f88fb79cf4255 [^]

Related to issue 42200: Remove use of OB.Data.OrderFindTaxes in Giftcards module

I35097_VerfiyGiftCardWithTaxNotExempt is not necessary anymore

---
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I35097_VerfiyGiftCardWithTaxNotExempt.java
---
(0117942)
ranjith_qualiantech_com (developer)
2020-02-19 12:40

Issue fixed in https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/562b2813a59d164e89561760fcc3d3a0486ad1c2 [^]

- Issue History
Date Modified Username Field Change
2019-11-06 08:42 adrianromero New Issue
2019-11-06 08:42 adrianromero Assigned To => Retail
2019-11-06 08:42 adrianromero Triggers an Emergency Pack => No
2019-11-19 10:52 hgbot Checkin
2019-11-19 10:52 hgbot Note Added: 0115683
2020-02-19 12:40 ranjith_qualiantech_com Note Added: 0117942
2020-02-19 16:35 guilleaer Status new => scheduled
2020-02-19 16:35 guilleaer Status scheduled => resolved
2020-02-19 16:35 guilleaer Fixed in Version => RR20Q1
2020-02-19 16:35 guilleaer Resolution open => fixed
2020-02-19 16:35 guilleaer Review Assigned To => guilleaer
2020-02-19 16:35 guilleaer Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker