Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0040664 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] StoreServer | minor | have not tried | 2019-04-24 09:37 | 2019-05-15 23:22 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 08301e57ffa5 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0040664: Allow the specify the column to use in the GenericBusinessPartnerSegmentationEventHandler to select the business partner | |||||||
| Description | The GenericBusinessPartnerSegmentationEventHandler is an event handler that acts upon the tables defined in the OBSTSYN_AUTO_ADD_BP_STORE table. It takes the c_bpartner_id column of those tables, and adds that business partner to the stores with access to the organization selected in other column. In some cases, the column that references the c_bpartner table is not named c_bpartner_id, so a new column should be added to the OBSTSYN_AUTO_ADD_BP_STORE table to allow selecting it. It should be possible to specify in the Auto Add Business Partner to Store Tables window the column to use in the event handler | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0111256) hgbot (developer) 2019-04-24 10:45 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: 216622970772d6b8f2f128256697b56fdc342662 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Apr 24 10:44:27 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/216622970772d6b8f2f128256697b56fdc342662 [^] Fixes issue 40664: It is possible to specify c_bpartner_id column in OBSTSYN_AUTO_ADD_BP_STORE Before this changeset, the GenericBusinessPartnerSegmentationEventHandler always picked a column name c_bpartner_id on the target table. Now it is possible to pick the column that will be used to select the referenced business partner. If this column is not filled in, c_bpartner_id will be used by default. --- M src-db/database/model/tables/OBSTSYN_AUTO_ADD_BP_STORE.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/retail/storeserver/synchronization/eventhandler/GenericBusinessPartnerSegmentationEventHandler.java --- |
|
(0111509) mtaal (manager) 2019-05-06 16:58 |
Some comments/questions: - I am not sure on the thread safety of the global static Maps, should maybe the initialization method be set to be synchronized? - Should the initialization of the map [1] not be outside of the for loop? - I would rename orgProperty here to bpProperty [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/216622970772/src/org/openbravo/retail/storeserver/synchronization/eventhandler/GenericBusinessPartnerSegmentationEventHandler.java#l101 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/216622970772/src/org/openbravo/retail/storeserver/synchronization/eventhandler/GenericBusinessPartnerSegmentationEventHandler.java#l105 [^] |
|
(0111511) mtaal (manager) 2019-05-06 17:15 |
See comments |
|
(0111688) hgbot (developer) 2019-05-15 10:18 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: 08301e57ffa58fd5d7f9ef6a09555ae9a782f297 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed May 15 10:18:52 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/08301e57ffa58fd5d7f9ef6a09555ae9a782f297 [^] Fixes issue 40664: Applies code review commentes: - Variable orgProperty has been renamed to bpProperty - Initialization of map nonDefaultBusinessPartnerProperties was wrong, not it is placed outside a loop - Initialization method getEntitiesThatAddAutomaticallBusinessPartnerToStore is now synchronized --- M src/org/openbravo/retail/storeserver/synchronization/eventhandler/GenericBusinessPartnerSegmentationEventHandler.java --- |
|
(0111695) mtaal (manager) 2019-05-15 23:22 |
reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-04-24 09:37 | AugustoMauch | New Issue | |
| 2019-04-24 09:37 | AugustoMauch | Assigned To | => AugustoMauch |
| 2019-04-24 09:37 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2019-04-24 09:37 | AugustoMauch | Relationship added | related to 0039114 |
| 2019-04-24 10:45 | hgbot | Checkin | |
| 2019-04-24 10:45 | hgbot | Note Added: 0111256 | |
| 2019-04-24 10:45 | hgbot | Status | new => resolved |
| 2019-04-24 10:45 | hgbot | Resolution | open => fixed |
| 2019-04-24 10:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/216622970772d6b8f2f128256697b56fdc342662 [^] |
| 2019-04-24 10:47 | AugustoMauch | Review Assigned To | => mtaal |
| 2019-04-24 10:47 | AugustoMauch | Relationship added | blocks 0040495 |
| 2019-05-06 16:58 | mtaal | Note Added: 0111509 | |
| 2019-05-06 17:15 | mtaal | Note Added: 0111511 | |
| 2019-05-06 17:15 | mtaal | Status | resolved => new |
| 2019-05-06 17:15 | mtaal | Resolution | fixed => open |
| 2019-05-15 10:18 | hgbot | Checkin | |
| 2019-05-15 10:18 | hgbot | Note Added: 0111688 | |
| 2019-05-15 10:18 | hgbot | Status | new => resolved |
| 2019-05-15 10:18 | hgbot | Resolution | open => fixed |
| 2019-05-15 10:18 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/216622970772d6b8f2f128256697b56fdc342662 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/08301e57ffa58fd5d7f9ef6a09555ae9a782f297 [^] |
| 2019-05-15 23:22 | mtaal | Note Added: 0111695 | |
| 2019-05-15 23:22 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |