Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040504 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Discounts and Promotions | minor | always | 2019-04-01 23:49 | 2019-04-15 14:46 | |||
Reporter | matias-bernal | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR19Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | adrianromero | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040504: Promotion of type Discount per Total Amount are not properly applied in Live Builds | |||||||
Description | Promotion of type Discount per Total Amount are not properly applied in Live Builds, but Percentage Discount per Total Amount are properly applied instead http://wiki.openbravo.com/wiki/Retail:By_Total_Discounts [^] For our use case we should be using the automatic discounts types (not the manual ones), which are: * Discount per Total Amount (seems not to be working as it should in Live Builds PI) * Percentage Discount per Total Amount (seems to be working OK in Live Builds PI) | |||||||
Steps To Reproduce | *Create a new promotion of type "Discount per Total Amount" and amount = 10 that applies to 100% of the ticket *Create a new record in the coupon tab *Reload the POS Terminal to add this promotion *In POS add 2 products to the ticket *Click on Menu > Coupon Code and enter the coupon code *See that the distribution of the 10€ discount is not properly applied in the lines, and finally sum discount of 11.12: see video attached | |||||||
Tags | No tags attached. | |||||||
Attached Files | LIVE BUILDS - 10$ Discount - NOK.webm [^] (644,497 bytes) 2019-04-02 15:38 I40504_possibleFix_bytotal.diff [^] (2,765 bytes) 2019-04-03 10:04 [Show Content] I40504_possibleFix_posterminal.diff [^] (732 bytes) 2019-04-03 10:05 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0110963) rafaroda (developer) 2019-04-02 11:04 |
Comment after talking with Pablo Sarobe and based on Wiki info http://wiki.openbravo.com/wiki/Retail:By_Total_Discount [^] For our use case we should be using the automatic discounts types (not the manual ones), which are: * Discount per Total Amount (seems not to be working as it should in Live Builds PI) * Percentage Discount per Total Amount (seems to be working OK in Live Builds PI) |
(0111018) hgbot (developer) 2019-04-08 12:40 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 49e637120914487fbe6285efad827269d62e3a0d Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Apr 08 16:09:47 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/49e637120914487fbe6285efad827269d62e3a0d [^] Related to issue 40504 : Added additional args to OBPOS_PreApplyAutomaticDiscount hook * Added receipt and line as args to OBPOS_PreApplyAutomaticDiscount hook --- M web/org.openbravo.retail.posterminal/js/model/executor.js --- |
(0111020) hgbot (developer) 2019-04-08 12:47 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: d37c97ec169b8395dd4bc531f59cf25638e1d0fd Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Apr 08 16:16:38 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d37c97ec169b8395dd4bc531f59cf25638e1d0fd [^] Related to issue 40504 : Updated Discount calculation when applying coupon code * When apply coupon code, coupon amount should be splited among lines proportionally --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyAutomaticDiscountHook.js M web/org.openbravo.retail.discounts.bytotal/js/promotion-discounttotal.js --- |
(0111026) hgbot (developer) 2019-04-08 15:23 |
Repository: tools/automation/pi-mobile Changeset: 70bfa487774978648dd05e052bab711993c73cf7 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Apr 08 18:52:58 2019 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/70bfa487774978648dd05e052bab711993c73cf7 [^] Verifies issue 40504 : Added automated test 'I40504_VerifyCouponDistributionWithReceiptLines' --- A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/I40504_VerifyCouponDistributionWithReceiptLines.java --- |
(0111034) ranjith_qualiantech_com (developer) 2019-04-09 09:08 |
Test failing in modules suite |
(0111038) hgbot (developer) 2019-04-09 10:50 |
Repository: tools/automation/pi-mobile Changeset: 8395d3ad257a5fe93db072c180b59c5057cb7354 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Apr 09 14:19:57 2019 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8395d3ad257a5fe93db072c180b59c5057cb7354 [^] Verifies issue 40504 : Added waitFixOf for test 'Multidiscounts_RemoveMultiDiscountsByTotal' --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/multidiscounts/Multidiscounts_RemoveMultiDiscountsByTotal.java --- |
(0111052) hgbot (developer) 2019-04-10 09:44 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: 1906dc3d194e5bfa0de8ddb38fd4f7dbeb9de5e5 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Apr 10 13:14:23 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/1906dc3d194e5bfa0de8ddb38fd4f7dbeb9de5e5 [^] Related to issue 40504 : Reverted changes in preApplyAutomaticDiscountHook which removes the necessary discounts * Backed out changeset: d37c97ec169b --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyAutomaticDiscountHook.js --- |
(0111053) hgbot (developer) 2019-04-10 09:45 |
Repository: tools/automation/pi-mobile Changeset: c9cda53cf012f074ffe45907e2a822668ab89cde Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Apr 10 13:15:13 2019 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c9cda53cf012f074ffe45907e2a822668ab89cde [^] Verifies issue 40504 : Removed waitFixOf for test 'Multidiscounts_RemoveMultiDiscountsByTotal' --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/multidiscounts/Multidiscounts_RemoveMultiDiscountsByTotal.java --- |
(0111138) adrianromero (manager) 2019-04-15 14:46 |
Verified |
Issue History | |||
Date Modified | Username | Field | Change |
2019-04-01 23:49 | matias-bernal | New Issue | |
2019-04-01 23:49 | matias-bernal | Assigned To | => Retail |
2019-04-01 23:49 | matias-bernal | File Added: lb.zip | |
2019-04-01 23:49 | matias-bernal | Triggers an Emergency Pack | => No |
2019-04-02 08:18 | rafaroda | Issue Monitored: rafaroda | |
2019-04-02 11:04 | rafaroda | Note Added: 0110963 | |
2019-04-02 15:38 | rafaroda | Summary | No coupons apply for certain promotions types => Promotion of type Discount per Total Amount are not properly applied in Live Builds |
2019-04-02 15:38 | rafaroda | Description Updated | View Revisions |
2019-04-02 15:38 | rafaroda | Steps to Reproduce Updated | View Revisions |
2019-04-02 15:38 | rafaroda | File Deleted: lb.zip | |
2019-04-02 15:38 | rafaroda | File Added: LIVE BUILDS - 10$ Discount - NOK.webm | |
2019-04-02 15:40 | rafaroda | Steps to Reproduce Updated | View Revisions |
2019-04-03 10:04 | jorge-garcia | File Added: I40504_possibleFix_bytotal.diff | |
2019-04-03 10:05 | jorge-garcia | File Added: I40504_possibleFix_posterminal.diff | |
2019-04-03 15:18 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2019-04-03 15:18 | ranjith_qualiantech_com | Status | new => scheduled |
2019-04-08 12:40 | hgbot | Checkin | |
2019-04-08 12:40 | hgbot | Note Added: 0111018 | |
2019-04-08 12:47 | hgbot | Checkin | |
2019-04-08 12:47 | hgbot | Note Added: 0111020 | |
2019-04-08 15:23 | hgbot | Checkin | |
2019-04-08 15:23 | hgbot | Note Added: 0111026 | |
2019-04-09 07:29 | ranjith_qualiantech_com | Status | scheduled => resolved |
2019-04-09 07:29 | ranjith_qualiantech_com | Resolution | open => fixed |
2019-04-09 09:08 | ranjith_qualiantech_com | Note Added: 0111034 | |
2019-04-09 09:08 | ranjith_qualiantech_com | Status | resolved => new |
2019-04-09 09:08 | ranjith_qualiantech_com | Resolution | fixed => open |
2019-04-09 10:50 | hgbot | Checkin | |
2019-04-09 10:50 | hgbot | Note Added: 0111038 | |
2019-04-09 10:50 | ranjith_qualiantech_com | Status | new => scheduled |
2019-04-10 09:44 | hgbot | Checkin | |
2019-04-10 09:44 | hgbot | Note Added: 0111052 | |
2019-04-10 09:45 | hgbot | Checkin | |
2019-04-10 09:45 | hgbot | Note Added: 0111053 | |
2019-04-10 15:22 | ranjith_qualiantech_com | Status | scheduled => resolved |
2019-04-10 15:22 | ranjith_qualiantech_com | Resolution | open => fixed |
2019-04-15 14:46 | adrianromero | Review Assigned To | => adrianromero |
2019-04-15 14:46 | adrianromero | Note Added: 0111138 | |
2019-04-15 14:46 | adrianromero | Status | resolved => closed |
2019-04-15 14:46 | adrianromero | Fixed in Version | => RR19Q3 |
Copyright © 2000 - 2009 MantisBT Group |