Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0040294
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POS Hardware Managermajoralways2019-02-28 16:352023-09-13 13:55
Reporterjoniturralde93View Statuspublic 
Assigned TojavierRodriguez 
PriorityurgentResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revisioncc9c9ecf9256
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket8151
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040294: Lines with Japanese alphabet characters don't get aligned correctly

DescriptionJapanese characters are trated like normal characters when doing the calculations to align the line. This way, the line is either not correctly aligned or, in this case, more blank spaces than necessary are put, so a new line is created with those blank spaces.
This caused Japanese lines to be more separated than they should be, with an extra empty line between them.
Steps To Reproduce1. Print a receipt in preprod Japan POS Terminal: https://<redacted>/openbravo/web/org.openbravo.retail.posterminal/?terminal=702345103 [^]
2. There is space between japanese lines despite the header not being configured to do so.
Proposed SolutionWe added Hiragana and Katakana alphabets to the ones recognised as "Double sized characters" for the customer. This is [probably] a quick, temporary fix.


In class DeviceTicket.java, method isDoubleSpaceUnicodeBlock, we added both alphabets to the condition:


  public static boolean isDoubleSpaceUnicodeBlock(UnicodeBlock block) {
    return block == UnicodeBlock.CJK_UNIFIED_IDEOGRAPHS
            || block == UnicodeBlock.HANGUL_SYLLABLES
            || block == UnicodeBlock.HANGUL_COMPATIBILITY_JAMO
            || block == UnicodeBlock.HANGUL_JAMO
            || block == UnicodeBlock.HANGUL_JAMO_EXTENDED_A
            || block == UnicodeBlock.HANGUL_JAMO_EXTENDED_B
            || block == UnicodeBlock.HIRAGANA
            || block == UnicodeBlock.KATAKANA;
  }
TagsNo tags attached.
Attached Filespng file icon beforeFix.png [^] (600,705 bytes) 2019-02-28 16:37
jpg file icon afterFix.jpg [^] (1,251,028 bytes) 2019-02-28 16:38

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0110341)
hgbot (developer)
2019-03-11 11:10

 Repository: erp/pmods/org.openbravo.retail.poshwmanager.sources
Changeset: cc9c9ecf92562bd157750c1e0c3f8879b5368c66
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Mon Mar 11 11:10:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/cc9c9ecf92562bd157750c1e0c3f8879b5368c66 [^]

Fixed issue 40294: Lines with Japanese alphabet characters don't get aligned correctly

Added new UnicodesBlock lines in isDoubleSpaceUnicodeBlock to make the printer know how to center it

---
M project/src/com/openbravo/pos/printer/DeviceTicket.java
---
(0110404)
jorge-garcia (viewer)
2019-03-13 13:26

 Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-02-28 16:35 joniturralde93 New Issue
2019-02-28 16:35 joniturralde93 Assigned To => Retail
2019-02-28 16:35 joniturralde93 OBNetwork customer => Gold
2019-02-28 16:35 joniturralde93 Support ticket => 8151
2019-02-28 16:35 joniturralde93 Resolution time => 1553122800
2019-02-28 16:35 joniturralde93 Triggers an Emergency Pack => No
2019-02-28 16:37 joniturralde93 File Added: beforeFix.png
2019-02-28 16:38 joniturralde93 File Added: afterFix.jpg
2019-02-28 17:26 joniturralde93 Summary Japanese alhpabets don't get aligned correctly => Japanese alphabets don't get aligned correctly
2019-02-28 17:28 joniturralde93 Summary Japanese alphabets don't get aligned correctly => Lines with Japanese alphabet characters don't get aligned correctly
2019-03-11 10:14 javierRodriguez Assigned To Retail => javierRodriguez
2019-03-11 11:10 hgbot Checkin
2019-03-11 11:10 hgbot Note Added: 0110341
2019-03-11 11:10 hgbot Status new => resolved
2019-03-11 11:10 hgbot Resolution open => fixed
2019-03-11 11:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.poshwmanager.sources/rev/cc9c9ecf92562bd157750c1e0c3f8879b5368c66 [^]
2019-03-13 13:26 jorge-garcia Review Assigned To => jorge-garcia
2019-03-13 13:26 jorge-garcia Note Added: 0110404
2019-03-13 13:26 jorge-garcia Status resolved => closed
2019-03-13 13:26 jorge-garcia Fixed in Version => RR19Q2
2023-09-13 13:55 shuehner Steps to Reproduce Updated View Revisions

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker