Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040045 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Selfcheckout | major | always | 2019-01-28 13:27 | 2019-02-04 09:11 | |||
Reporter | malsasua | View Status | public | |||||
Assigned To | javierRodriguez | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | RR19Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | a6a9a4340385 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | marvintm | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/rev/9ed7b25e3080 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040045: Last panel is overwrite by right Footer panel | |||||||
Description | The last panel added to OB.SCO.APP.PANELRIGHT array is overwritten by right footer panel | |||||||
Steps To Reproduce | In execution, in Console Developers Tools, add a breakpoint in code: .... // Create all Panel Right components for (prop in OB.SCO.APP.PANELRIGHT) { if (OB.SCO.APP.PANELRIGHT.hasOwnProperty(prop)) { component = this.rightPanel.createComponent({ kind: OB.SCO.APP.PANELRIGHT[prop], name: prop, executeEvent: this.executeEvent.bind(this), showLoading: this.showLoading.bind(this), hideLoading: this.hideLoading.bind(this), state: this.state, receipt: this.receipt, receiptClone: this.receiptClone }).render(); component.hide(); this.rightComponents[prop] = component; } } component = this.rightPanel.createComponent({ kind: 'OB.SCO.rightFooter', name: 'rightFooter' }).render(); component.show(); this.rightComponents[prop] = component; ... The value of prop is the last panel added (in livebuilds is WeChatPanel), and it is overwritten by rightFooter component | |||||||
Tags | No tags attached. | |||||||
Attached Files | rightfooter.diff [^] (2,226 bytes) 2019-01-30 09:33 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0109281) adrianromero (manager) 2019-01-28 17:52 edited on: 2019-01-28 17:52 |
The following line is not needed https://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/file/9ed7b25e3080/web/org.openbravo.retail.selfcheckout/source/components/applicationEngine.js#l92 [^] In fact, from the project structure point of view, the creation of the component OB.SCO.rightFooter should go in the file scoView.js, in the component field definition or in the init method https://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/file/tip/web/org.openbravo.retail.selfcheckout/source/view/scoView.js [^] . But not in the applicationEngine component. |
(0109293) hgbot (developer) 2019-01-29 09:30 |
Repository: erp/pmods/org.openbravo.retail.selfcheckout Changeset: a6a9a4340385191854c0ca499d412e707a8a1338 Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com> Date: Tue Jan 29 08:53:47 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/rev/a6a9a4340385191854c0ca499d412e707a8a1338 [^] Fixed issue 40045: Last panel is overwrite by right Footer panel When rightFooter component was created an included in the right panel, it was overwriting the last component. In DKT, this las component was termsAndConditionsComponent. --- M web/org.openbravo.retail.selfcheckout/source/components/applicationEngine.js --- |
(0109318) adrianromero (manager) 2019-01-30 09:32 |
As explained in my previous comment it is not needed too add de created component to rightComponents in the applicationEngine, and it makes sense to go outside in scoView as the footer it is not part of the application engine. It is just an static component. Please consider the attached diff that contains also other improvements and removes dead code. |
(0109420) hgbot (developer) 2019-02-01 10:44 |
Repository: erp/pmods/org.openbravo.retail.selfcheckout Changeset: bf20e009b32e4adbb3550b6302ab9dd61195dede Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com> Date: Fri Feb 01 10:42:28 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/rev/bf20e009b32e4adbb3550b6302ab9dd61195dede [^] Related to issue 40045: Last panel is overwrite by right Footer panel --- M src/org/openbravo/retail/selfcheckout/SCOComponentProvider.java M web/org.openbravo.retail.selfcheckout/source/components/applicationEngine.js M web/org.openbravo.retail.selfcheckout/source/panels/rightFooterPanel.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2019-01-28 13:27 | malsasua | New Issue | |
2019-01-28 13:27 | malsasua | Assigned To | => Retail |
2019-01-28 13:27 | malsasua | Resolution time | => 1549062000 |
2019-01-28 13:27 | malsasua | Triggers an Emergency Pack | => No |
2019-01-28 17:28 | adrianromero | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/rev/9ed7b25e3080 [^] |
2019-01-28 17:52 | adrianromero | Note Added: 0109281 | |
2019-01-28 17:52 | adrianromero | Note Edited: 0109281 | View Revisions |
2019-01-28 18:30 | adrianromero | Issue Monitored: adrianromero | |
2019-01-29 09:30 | hgbot | Checkin | |
2019-01-29 09:30 | hgbot | Note Added: 0109293 | |
2019-01-29 09:30 | hgbot | Status | new => resolved |
2019-01-29 09:30 | hgbot | Resolution | open => fixed |
2019-01-29 09:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.selfcheckout/rev/a6a9a4340385191854c0ca499d412e707a8a1338 [^] |
2019-01-29 17:33 | marvintm | Assigned To | Retail => javierRodriguez |
2019-01-30 09:32 | adrianromero | Note Added: 0109318 | |
2019-01-30 09:33 | adrianromero | File Added: rightfooter.diff | |
2019-02-01 10:44 | hgbot | Checkin | |
2019-02-01 10:44 | hgbot | Note Added: 0109420 | |
2019-02-04 09:11 | marvintm | Review Assigned To | => marvintm |
2019-02-04 09:11 | marvintm | Status | resolved => closed |
2019-02-04 09:11 | marvintm | Fixed in Version | => RR19Q2 |
Copyright © 2000 - 2009 MantisBT Group |