0003973: Add the Openbravo version in the XML files exported for translation

Description

Hello,

When working with translations, like all the Openbravo ones[1], it is impossible to tell to which version an XML belongs to.

Although this has to be fixed using SVN branches at source control level, I think that including the version of Openbravo ERP that produced the output it helps a lot to identify to which version a set of XML belongs to.

Attached to have a patch that does so.

Jordi,

[1] https://dev.openbravo.com/websvn/localization/translations/ [^]

Tags

No tags attached.

Attached Files

version_number.diff [^] (1,668 bytes) 2008-06-13 19:24 [Show Content] [Hide Content]

Index: src/org/openbravo/erpCommon/ad_forms/Translation_data.xsql
===================================================================
--- src/org/openbravo/erpCommon/ad_forms/Translation_data.xsql	(revision 5038)
+++ src/org/openbravo/erpCommon/ad_forms/Translation_data.xsql	(working copy)
@@ -38,6 +38,14 @@
       </Sql>
       <Parameter name="paramLanguage"/>
   </SqlMethod>
+
+
+ <SqlMethod name="version" type="preparedStatement" return="string">
+    <SqlMethodComment></SqlMethodComment>
+    <Sql>
+        SELECT AD_SYSTEM_INFO.OB_VERSION FROM AD_SYSTEM_INFO
+     </Sql>
+   </SqlMethod>
   
   <SqlMethod name="baseLanguage" type="preparedStatement" return="string">     
       <Sql>
Index: src/org/openbravo/erpCommon/ad_forms/Translation.java
===================================================================
--- src/org/openbravo/erpCommon/ad_forms/Translation.java	(revision 5038)
+++ src/org/openbravo/erpCommon/ad_forms/Translation.java	(working copy)
@@ -49,6 +49,8 @@
 	public static final String	XML_ATTRIBUTE_TABLE = "table";
 	/** XML Attribute Language		*/
 	public static final String	XML_ATTRIBUTE_LANGUAGE = "language";
+	/** XML Attribute Version		*/
+	public static final String	XML_ATTRIBUTE_VERSION = "version";
 
 	/**	XML Row Tag					*/
 	public static final String	XML_ROW_TAG = "row";
@@ -254,6 +256,7 @@
 			Element root = document.createElement(XML_TAG);
 			root.setAttribute(XML_ATTRIBUTE_LANGUAGE, AD_Language);
 			root.setAttribute(XML_ATTRIBUTE_TABLE, Base_Table);
+			root.setAttribute(XML_ATTRIBUTE_VERSION, TranslationData.version (this));
 			document.appendChild(root);
       log4j.info("exportTrl - kk ");
 			//

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2008-06-13 19:24	jordimas	New Issue
2008-06-13 19:24	jordimas	Assigned To	=> cromero
2008-06-13 19:24	jordimas	File Added: version_number.diff
2008-06-13 19:24	jordimas	OBNetwork customer	=> N
2008-06-16 10:48	psarobe	Status	new => scheduled
2008-06-16 10:48	psarobe	Assigned To	cromero => Hennadzi
2008-06-17 16:49	jordimas	Issue Monitored: jordimas
2008-06-18 10:48	Hennadzi	Status	scheduled => resolved
2008-06-18 10:48	Hennadzi	Resolution	open => fixed
2008-06-18 10:48	Hennadzi	Fixed in Version	=> trunk
2008-06-18 10:48	Hennadzi	svn_revision	=> 5139
2008-07-01 17:56	anonymous	sf_bug_id	0 => 2007955
2008-12-08 23:34	psarobe	Regression testing	=> No
2008-12-08 23:34	psarobe	Status	resolved => closed