0039623: Actual Qty in Commission Amt is set wrongly when Commission is configured as Cascade = No

Description

When invoice's payment term has multiple lines, Actual Qty in Commission Amt is set wrong when Commission is configured as Cascade = No

Steps To Reproduce

- Login as International Group Admin.
- Create a Payment Term header:
   Overdue Payment Days Rule: 60
   Add a line to it:
      Percentage due: 50
      Overdue Payment Days Rule: 30
- Create a Commission with:
      Business Partner / Sales Rep.: Javier Martín
      Frequency Type: Monthly
      Basis Document: Invoice
      Basis Status. Fully paid docuemnts
      Basis Amount: Net amount
      Cascade = No
   Add a line to it:
      Based on Sales Rep. = Y
      Multiplier amount: 0.5
- Create a Sales Invoice and associate the previously created payment terms and the sales representative to it.
- Line 1: Product - Agua sin Gas 1L, Quantity: 100, Tax: Entregas IVA 21%, Line Net Amount = 153.00
- Line 2: Product - Cerveza Ale 0,5L, Quantity: 100, Tax: Entregas IVA 21%, Line Net Amount = 204.00
- Line 3: Product - Bebida Energética 0,5L, Quantity: 1, Tax: Entregas IVA 21%, Line Net Amount = 368.00
- Total Gross Amount 877.25, Line Gross Amount:725.00, Complete it.
- Realize that two payment plan are available for this invoice.
  Due Date 1: Today + 30 days, Amount = 438.62
  Due Date 2: Today + 60 days, Amount = 438.63
- Pay each of it in three payments with different dates.
- Generate commission for the last payment date.
- Go to the Commission Payment window:
- Realize a there is commission payment created with Total Amount = 94.25.
- In Amount Tab: Amount = 94.25, Converted Amount = 725.00, Actual Quantity = 402.

** Realize that Actual Quantity should be set as 201.

Tags

No tags attached.

Attached Files

ProposedFix.diff [^] (1,019 bytes) 2018-11-13 19:12 [Show Content] [Hide Content]

diff -r 481ac2290be5 src-db/database/model/functions/C_COMMISSION_PROCESS.xml
--- a/src-db/database/model/functions/C_COMMISSION_PROCESS.xml	Tue Nov 13 19:23:04 2018 +0530
+++ b/src-db/database/model/functions/C_COMMISSION_PROCESS.xml	Tue Nov 13 23:15:41 2018 +0530
@@ -456,6 +456,18 @@
         CLOSE v_rc;
         --
       END LOOP; -- For every Commission Line
+      IF (v_DocBasisType = 'I' AND v_IsCascade = 'N') THEN
+        SELECT sum(QtyInvoiced)
+        INTO v_Qty
+        FROM C_InvoiceLine
+        WHERE EXISTS (SELECT 1
+                      FROM C_CommissionDetail
+                      WHERE C_CommissionDetail.C_InvoiceLine_ID = C_InvoiceLine.C_InvoiceLine_ID
+                      AND C_CommissionDetail.C_CommissionAmt_ID = v_C_CommissionAmt_ID);
+        UPDATE C_CommissionAmt
+        SET ActualQty = v_Qty
+        WHERE C_CommissionAmt_ID = v_C_CommissionAmt_ID;
+      END IF;
     END;
     v_Message:='@CommissionRun@ = ' || v_DocumentNo || ' - ' || v_Name;
     --<<FINISH_PROCESS>>

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0039474

closed

AtulOpenbravo

Commission calculation error

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2018-11-13 19:12	AtulOpenbravo	New Issue
2018-11-13 19:12	AtulOpenbravo	Assigned To	=> Triage Finance
2018-11-13 19:12	AtulOpenbravo	File Added: ProposedFix.diff
2018-11-13 19:12	AtulOpenbravo	Modules	=> Core
2018-11-13 19:12	AtulOpenbravo	Triggers an Emergency Pack	=> No
2018-11-13 19:15	AtulOpenbravo	Relationship added	related to 0039474
2018-11-13 19:16	AtulOpenbravo	Steps to Reproduce Updated	View Revisions