Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0039180 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2018-08-24 09:04 | 2018-10-08 18:02 | |||
| Reporter | asiermartirena | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR19Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f075a8c98774 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0039180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should | |||||||
| Description | When an order is synchronized a scrim is used to avoid the user to do any change in the Web POS during the synchronization process. In synchronized mode, a popup is raised telling "Synchronizing Transaction" that blocks the Web POS during the synchronization process. The problem is that when the synchronization process ends, even if the Web POS haven't finished the synchronization actions, the scrim is hidden due to the popup hidden action. This allows the user to have some time to do changes in the ticket that is being synchronized. This has a higher impact in a slow terminal. | |||||||
| Steps To Reproduce | Activate the Synchronize mode preference. Create a ticket in Web POS and synchronize it. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0106789) hgbot (developer) 2018-09-17 01:34 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 81c99a1ef11a160b7db059670fcc28512c6d1995 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Sep 10 11:38:59 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/81c99a1ef11a160b7db059670fcc28512c6d1995 [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Virified if synchronizedData is empty to be sure that everything was synchronized --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0106799) marvintm (manager) 2018-09-17 12:00 |
The fix is not correct. We need to ensure that the scrim doesn't appear until the ticket disappears from the UI, and the process is completely done. |
|
(0106800) hgbot (developer) 2018-09-17 13:06 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 73679bee4ec25915a7f2fc107c9f9c918de1dcbc Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Sep 17 13:05:54 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/73679bee4ec25915a7f2fc107c9f9c918de1dcbc [^] Related to issue 39180. Backout change until the proper solution is found. --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0106836) hgbot (developer) 2018-09-18 14:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ecc7cb13bfb45820f0feb2ce34c443360df5e2ce Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Sep 17 11:30:02 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ecc7cb13bfb45820f0feb2ce34c443360df5e2ce [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Moved call to hideSynchronizingDialog function after delete ticket action --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0106914) marvintm (manager) 2018-09-21 08:33 |
Still doesn't work properly, synchronising popup is removed too soon. |
|
(0106936) hgbot (developer) 2018-09-21 12:49 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: f5ff6c1de780c75694e2e72cf9637fc65e7ba933 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Sep 17 11:10:01 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5ff6c1de780c75694e2e72cf9637fc65e7ba933 [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Moved call to hideSynchronizingDialog function after delete ticket action --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0106940) marvintm (manager) 2018-09-21 13:35 |
Now the popup is correctly hidden only after the ticket is fully processed, this part is working correctly. However, now in some flows, the popup becomes stuck, and is never hidden. For example, in this one: - Activate synchronize mode. - Log in the application. - Do a ticket. Up to this point, everything is correctly. - Then do F5. The synchronize mode popup is shown, and never hidden. This means that the terminal is now stuck and it's not possible to do anything. |
|
(0106960) hgbot (developer) 2018-09-24 13:22 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 192e1fe7a877613b3b7dd74defb4d927655718dd Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Sep 24 13:17:11 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/192e1fe7a877613b3b7dd74defb4d927655718dd [^] Related to issue 39180. Backout change until the proper solution is found. - I34285_VerifyCustomerSaveAction broken - Backed out changeset ecc7cb13bfb4 --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0106961) hgbot (developer) 2018-09-24 13:22 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 68eb5428bf777bd48870fea53714d7ccb431f478 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Sep 24 13:22:28 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/68eb5428bf777bd48870fea53714d7ccb431f478 [^] Related to issue 39180. Backout change until the proper solution is found. - I34285_VerifyCustomerSaveAction broken - Remove empty line --- M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js --- |
|
(0106962) hgbot (developer) 2018-09-24 13:22 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: b42b5c8ff72571f04fd04b1d5f797dce9f5c5c59 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Sep 24 13:07:06 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b42b5c8ff72571f04fd04b1d5f797dce9f5c5c59 [^] Related to issue 39180. Backout change until the proper solution is found. - I34285_VerifyCustomerSaveAction broken - Backed out changeset f5ff6c1de780 --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0106963) hgbot (developer) 2018-09-24 13:22 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 0e045b6ac34bcb3f24d70af180a2aba07380f21a Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Sep 24 13:07:15 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e045b6ac34bcb3f24d70af180a2aba07380f21a [^] Related to issue 39180. Backout change until the proper solution is found. - I34285_VerifyCustomerSaveAction broken - Backed out changeset 73679bee4ec2 --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0106964) hgbot (developer) 2018-09-24 13:22 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 6486b9428b31d2f100037a90cdfb14b9dccaf004 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Sep 24 13:07:25 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6486b9428b31d2f100037a90cdfb14b9dccaf004 [^] Related to issue 39180. Backout change until the proper solution is found. - I34285_VerifyCustomerSaveAction broken - Backed out changeset 81c99a1ef11a --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
|
(0107194) hgbot (developer) 2018-10-05 15:19 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: f3a2e2aa4092bf2851c9f489202fa3c4b84f6756 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Sep 24 10:13:15 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f3a2e2aa4092bf2851c9f489202fa3c4b84f6756 [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Moved call to hideSynchronizingDialog function after delete ticket action --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js M web/org.openbravo.mobile.core/source/utils/ob-synchronizationmonitor.js --- |
|
(0107195) hgbot (developer) 2018-10-05 15:19 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: cbf17956b1743d152c01b355dff8e5974e060092 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Mon Sep 24 10:37:13 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cbf17956b1743d152c01b355dff8e5974e060092 [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Moved call to hideSynchronizingDialog function after runSyncProcess action --- M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0107196) marvintm (manager) 2018-10-05 17:05 |
Still doesn't work properly. Most flows work, but the Open Till window is opening the synchronized mode popup also, and leaving it open, so the POS becomes blocked in that window. After some internal discussion, we think that maybe the approach we have tried to follow is not safe enough, and it is too prone to generate a regression. Therefore, we propose to follow a different path: instead of trying to close the synchronized mode popup later in the process, we will close it in the centralized api, but will leave the scrim in the ticket processing flow, and remove the scrim only when it is safe. |
|
(0107197) hgbot (developer) 2018-10-06 05:04 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 3d6eae5d6eb9122de6c023b9e42b1a535c7788ab Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Fri Oct 05 14:30:07 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3d6eae5d6eb9122de6c023b9e42b1a535c7788ab [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Show scrim at the beginning the close of the ticket --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js M web/org.openbravo.mobile.core/source/utils/ob-synchronizationmonitor.js --- |
|
(0107198) hgbot (developer) 2018-10-06 05:05 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f075a8c98774b2167466727968a4495ad066df31 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Fri Oct 05 15:22:12 2018 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f075a8c98774b2167466727968a4495ad066df31 [^] Fixed issue 39180: When synchronizing an order in synchronized mode, the scrim is hidden before that it should - Backed out changeset: cbf17956b174 --- M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js --- |
|
(0107206) marvintm (manager) 2018-10-08 10:02 |
Solution is now working correctly, but the code is not in the right place. Instead of being inside ob-terminal-model, which is supposed to contain generic code which should be executed for every model, it should be moved to dataordersave.js, because we only want to activate the scrim specifically in the flow for order synchronization |
|
(0107220) marvintm (manager) 2018-10-08 18:02 |
After further discussion, the final solution has been considered correct. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-08-24 09:04 | asiermartirena | New Issue | |
| 2018-08-24 09:04 | asiermartirena | Assigned To | => Retail |
| 2018-08-24 09:04 | asiermartirena | Resolution time | => 1536271200 |
| 2018-08-24 09:04 | asiermartirena | Triggers an Emergency Pack | => No |
| 2018-09-03 18:36 | rqueralta | Assigned To | Retail => rqueralta |
| 2018-09-03 20:24 | rqueralta | Status | new => scheduled |
| 2018-09-17 01:34 | hgbot | Checkin | |
| 2018-09-17 01:34 | hgbot | Note Added: 0106789 | |
| 2018-09-17 01:34 | hgbot | Status | scheduled => resolved |
| 2018-09-17 01:34 | hgbot | Resolution | open => fixed |
| 2018-09-17 01:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/81c99a1ef11a160b7db059670fcc28512c6d1995 [^] |
| 2018-09-17 12:00 | marvintm | Note Added: 0106799 | |
| 2018-09-17 12:00 | marvintm | Status | resolved => new |
| 2018-09-17 12:00 | marvintm | Resolution | fixed => open |
| 2018-09-17 13:06 | hgbot | Checkin | |
| 2018-09-17 13:06 | hgbot | Note Added: 0106800 | |
| 2018-09-17 15:38 | rqueralta | Status | new => scheduled |
| 2018-09-18 14:28 | hgbot | Checkin | |
| 2018-09-18 14:28 | hgbot | Note Added: 0106836 | |
| 2018-09-18 14:28 | hgbot | Status | scheduled => resolved |
| 2018-09-18 14:28 | hgbot | Resolution | open => fixed |
| 2018-09-18 14:28 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/81c99a1ef11a160b7db059670fcc28512c6d1995 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ecc7cb13bfb45820f0feb2ce34c443360df5e2ce [^] |
| 2018-09-21 08:33 | marvintm | Note Added: 0106914 | |
| 2018-09-21 08:33 | marvintm | Status | resolved => new |
| 2018-09-21 08:33 | marvintm | Resolution | fixed => open |
| 2018-09-21 12:49 | hgbot | Checkin | |
| 2018-09-21 12:49 | hgbot | Note Added: 0106936 | |
| 2018-09-21 12:49 | hgbot | Status | new => resolved |
| 2018-09-21 12:49 | hgbot | Resolution | open => fixed |
| 2018-09-21 12:49 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ecc7cb13bfb45820f0feb2ce34c443360df5e2ce [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5ff6c1de780c75694e2e72cf9637fc65e7ba933 [^] |
| 2018-09-21 13:25 | marvintm | Review Assigned To | => marvintm |
| 2018-09-21 13:25 | marvintm | Status | resolved => closed |
| 2018-09-21 13:25 | marvintm | Fixed in Version | => RR18Q4 |
| 2018-09-21 13:35 | marvintm | Note Added: 0106940 | |
| 2018-09-21 13:35 | marvintm | Status | closed => new |
| 2018-09-21 13:35 | marvintm | Resolution | fixed => open |
| 2018-09-21 13:35 | marvintm | Fixed in Version | RR18Q4 => |
| 2018-09-24 13:22 | hgbot | Checkin | |
| 2018-09-24 13:22 | hgbot | Note Added: 0106960 | |
| 2018-09-24 13:22 | hgbot | Checkin | |
| 2018-09-24 13:22 | hgbot | Note Added: 0106961 | |
| 2018-09-24 13:22 | hgbot | Checkin | |
| 2018-09-24 13:22 | hgbot | Note Added: 0106962 | |
| 2018-09-24 13:22 | hgbot | Checkin | |
| 2018-09-24 13:22 | hgbot | Note Added: 0106963 | |
| 2018-09-24 13:22 | hgbot | Checkin | |
| 2018-09-24 13:22 | hgbot | Note Added: 0106964 | |
| 2018-10-05 15:19 | hgbot | Checkin | |
| 2018-10-05 15:19 | hgbot | Note Added: 0107194 | |
| 2018-10-05 15:19 | hgbot | Status | new => resolved |
| 2018-10-05 15:19 | hgbot | Resolution | open => fixed |
| 2018-10-05 15:19 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f5ff6c1de780c75694e2e72cf9637fc65e7ba933 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f3a2e2aa4092bf2851c9f489202fa3c4b84f6756 [^] |
| 2018-10-05 15:19 | hgbot | Checkin | |
| 2018-10-05 15:19 | hgbot | Note Added: 0107195 | |
| 2018-10-05 15:19 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f3a2e2aa4092bf2851c9f489202fa3c4b84f6756 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cbf17956b1743d152c01b355dff8e5974e060092 [^] |
| 2018-10-05 17:05 | marvintm | Note Added: 0107196 | |
| 2018-10-05 17:05 | marvintm | Status | resolved => new |
| 2018-10-05 17:05 | marvintm | Resolution | fixed => open |
| 2018-10-06 05:04 | hgbot | Checkin | |
| 2018-10-06 05:04 | hgbot | Note Added: 0107197 | |
| 2018-10-06 05:04 | hgbot | Status | new => resolved |
| 2018-10-06 05:04 | hgbot | Resolution | open => fixed |
| 2018-10-06 05:04 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cbf17956b1743d152c01b355dff8e5974e060092 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3d6eae5d6eb9122de6c023b9e42b1a535c7788ab [^] |
| 2018-10-06 05:05 | hgbot | Checkin | |
| 2018-10-06 05:05 | hgbot | Note Added: 0107198 | |
| 2018-10-06 05:05 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3d6eae5d6eb9122de6c023b9e42b1a535c7788ab [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f075a8c98774b2167466727968a4495ad066df31 [^] |
| 2018-10-08 10:02 | marvintm | Note Added: 0107206 | |
| 2018-10-08 10:02 | marvintm | Status | resolved => new |
| 2018-10-08 10:02 | marvintm | Resolution | fixed => open |
| 2018-10-08 18:02 | marvintm | Status | new => scheduled |
| 2018-10-08 18:02 | marvintm | Status | scheduled => resolved |
| 2018-10-08 18:02 | marvintm | Fixed in Version | => RR19Q1 |
| 2018-10-08 18:02 | marvintm | Resolution | open => fixed |
| 2018-10-08 18:02 | marvintm | Note Added: 0107220 | |
| 2018-10-08 18:02 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |