Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038761
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorrandom2018-06-14 13:112018-11-07 08:22
ReportermaiteView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revisione90a66f0b903
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2018-02-23
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/2cd341c77062 [^]
Triggers an Emergency PackNo
Summary

0038761: having write access to a parent and one of its children orgs, sometimes it's not possible to read siblings of child one

DescriptionHaving an organization A, with at least 2 child nodes B and C and a role with write access to A and only one of its children (B or C):

   A
  / \
 B   C


When logging in with that role, organization C should be readable but not writable.

But randomly organization C is not visible at all.
Steps To Reproduce1. Log in as Group Admin
2. In Role window select F&B España, S.A - Admin
   -> It defines write access to organizations España (A), España Norte (B) and España Sur (C)
3. In Org Access tab, select España Sur and mark it as not active
4. In User Assignment tab, grant this role to Openbravo user
5. Log out and log in again with Openbravo user
6. Select F&B España, S.A - Admin role

7. Open Sales Order window
8. Remove filters
  -> ERROR (randomly):
         - got: orders only from Norte and España organizations are displayed
         - expected: also orders from Sur organization should be visible though not writable
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0037980 closedalostale Improve organization cache in session 
blocks backport 00387583.0PR18Q2.1 closedalostale having write access to a parent and one of its children orgs, sometimes it's not possible to read siblings of child one 
causes defect 0038787 closedalostale tests fail to compile with JDK10+ 

-  Notes
(0105153)
hgbot (developer)
2018-06-15 08:08

 Repository: erp/devel/pi
Changeset: bb3ab3249a3368679ab20190fa561eb8c546cb31
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 14 16:44:11 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bb3ab3249a3368679ab20190fa561eb8c546cb31 [^]

related to bug 38761: create TestConstants to share some common constants

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
M src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java
A src-test/src/org/openbravo/test/base/TestConstants.java
---
(0105154)
hgbot (developer)
2018-06-15 08:08

 Repository: erp/devel/pi
Changeset: 283d1bb725e7442fb1a1dd44d7cfef9c97791a3f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 14 16:49:46 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/283d1bb725e7442fb1a1dd44d7cfef9c97791a3f [^]

related to bug 38761: rename inner class to prevent collisions

---
M src-test/src/org/openbravo/test/base/TestConstants.java
M src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java
---
(0105155)
hgbot (developer)
2018-06-15 08:08

 Repository: erp/devel/pi
Changeset: 6588bbc83db4a5db005892c811519d5f9a2af1ba
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 14 16:55:26 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6588bbc83db4a5db005892c811519d5f9a2af1ba [^]

related to bug 38761: fixed OBBaseTest

---
M src-test/src/org/openbravo/test/base/OBBaseTest.java
---
(0105156)
hgbot (developer)
2018-06-15 08:08

 Repository: erp/devel/pi
Changeset: 5d06f2cf366feb9538344ba2405a00fee9b4c141
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 14 16:56:21 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5d06f2cf366feb9538344ba2405a00fee9b4c141 [^]

related to bug 38761: added test case

---
M src-test/src/org/openbravo/test/security/WritableReadableOrganizationClientTest.java
---
(0105157)
hgbot (developer)
2018-06-15 08:08

 Repository: erp/devel/pi
Changeset: e90a66f0b903e01a575530f094a851a3fab31e5c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 14 17:08:07 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e90a66f0b903e01a575530f094a851a3fab31e5c [^]

fixed bug 38761: with write access to an org and one child, can't read siblings

  Having an organization A, with at least 2 child nodes B and C and a role with
  write access to A and only one of its children B, randomly cannot read info in
  C.

  Readable organizations should be all the ones that are part of the natural tree
  of each of the writable organizations. When calculating them there was a wrong
  optimization that assumed if an organization was already calculated to be part
  of the readable orgs, its natural tree would also be so there was no need to
  recalculate it.

  This is not true if it was included becuase it is part of natural tree of one
  of its writable descendants, in this case if this org is also writable its natural
  tree needs to be calculated.

  As calculating natural tree on memory is not that expensive it is not worth to
  include more complex logic to decide whether it requires to be calculated or not:
  now it will be calculated for all writable organizations.

---
M src/org/openbravo/dal/core/OBContext.java
---
(0105163)
hgbot (developer)
2018-06-15 09:30

 Repository: erp/devel/pi
Changeset: 1062e250a41051349d62aae1dc37bc2b49af4472
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jun 15 09:30:37 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1062e250a41051349d62aae1dc37bc2b49af4472 [^]

related to bug 38761: fixed comment

---
M src-test/src/org/openbravo/test/security/WritableReadableOrganizationClientTest.java
---
(0105164)
AugustoMauch (manager)
2018-06-15 09:57

 Code reviewed and verified in pi@e90a66f0b903
(0105180)
hudsonbot (developer)
2018-06-15 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105181)
hudsonbot (developer)
2018-06-15 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105182)
hudsonbot (developer)
2018-06-15 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105183)
hudsonbot (developer)
2018-06-15 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105184)
hudsonbot (developer)
2018-06-15 12:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd9c57666e17 [^]
Maturity status: Test
(0105239)
hudsonbot (developer)
2018-06-19 13:24

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dd1f20cf33f6 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-06-14 16:36 alostale Type defect => backport
2018-06-14 16:36 alostale Target Version => 3.0PR18Q2.1
2018-06-14 17:14 alostale Steps to Reproduce Updated View Revisions
2018-06-15 08:08 hgbot Checkin
2018-06-15 08:08 hgbot Note Added: 0105153
2018-06-15 08:08 hgbot Checkin
2018-06-15 08:08 hgbot Note Added: 0105154
2018-06-15 08:08 hgbot Checkin
2018-06-15 08:08 hgbot Note Added: 0105155
2018-06-15 08:08 hgbot Checkin
2018-06-15 08:08 hgbot Note Added: 0105156
2018-06-15 08:08 hgbot Checkin
2018-06-15 08:08 hgbot Note Added: 0105157
2018-06-15 08:08 hgbot Status scheduled => resolved
2018-06-15 08:08 hgbot Resolution open => fixed
2018-06-15 08:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e90a66f0b903e01a575530f094a851a3fab31e5c [^]
2018-06-15 08:10 alostale Review Assigned To caristu => AugustoMauch
2018-06-15 08:10 alostale Type backport => defect
2018-06-15 08:10 alostale Target Version 3.0PR18Q2.1 =>
2018-06-15 08:10 alostale Relationship added related to 0037980
2018-06-15 08:57 AugustoMauch Description Updated View Revisions
2018-06-15 09:30 hgbot Checkin
2018-06-15 09:30 hgbot Note Added: 0105163
2018-06-15 09:57 AugustoMauch Note Added: 0105164
2018-06-15 09:57 AugustoMauch Status resolved => closed
2018-06-15 09:57 AugustoMauch Fixed in Version => pi
2018-06-15 09:57 AugustoMauch Fixed in Version pi => 3.0PR18Q3
2018-06-15 12:13 hudsonbot Checkin
2018-06-15 12:13 hudsonbot Note Added: 0105180
2018-06-15 12:13 hudsonbot Checkin
2018-06-15 12:13 hudsonbot Note Added: 0105181
2018-06-15 12:13 hudsonbot Checkin
2018-06-15 12:13 hudsonbot Note Added: 0105182
2018-06-15 12:13 hudsonbot Checkin
2018-06-15 12:13 hudsonbot Note Added: 0105183
2018-06-15 12:13 hudsonbot Checkin
2018-06-15 12:13 hudsonbot Note Added: 0105184
2018-06-19 09:17 alostale Relationship added causes 0038787
2018-06-19 13:24 hudsonbot Checkin
2018-06-19 13:24 hudsonbot Note Added: 0105239
2018-11-07 08:22 alostale Relationship replaced caused by 0037980

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker