0038122: Error creating Order from Sales Quotation

Description

An error (org.hibernate.StaleStateException) is shown when a user without access to Product, or similar windows like Services Related Products, tries to create an Order on the Sales Quotation window.

The error appears to be in org.openbravo.warehouse.advancedwarehouseoperations.eventobserver.OrderLineEventObserver.isProductItemStockable

Steps To Reproduce

- Login the application with a user with only access to the following windows:
- Sales Order
- Sales Quotation

- Create a Sales Quotation
- Book the Quotation
- Click on Create Order

The exception is shown

Proposed Solution

Execute this method in an Admin Mode context:
org.openbravo.warehouse.advancedwarehouseoperations.eventobserver.OrderLineEventObserver.isProductItemStockable

Proposed patch attached

Tags

No tags attached.

Attached Files

AWOCreateOrderFromQuotation.patch [^] (1,370 bytes) 2018-03-13 16:34 [Show Content] [Hide Content]

diff -r d9dd2058ab0d src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderLineEventObserver.java
--- a/src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderLineEventObserver.java	Fri Jan 05 12:38:52 2018 +0100
+++ b/src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/OrderLineEventObserver.java	Tue Mar 13 13:53:03 2018 +0530
@@ -22,6 +22,7 @@
 import org.openbravo.client.kernel.event.EntityPersistenceEvent;
 import org.openbravo.client.kernel.event.EntityPersistenceEventObserver;
 import org.openbravo.client.kernel.event.EntityUpdateEvent;
+import org.openbravo.dal.core.OBContext;
 import org.openbravo.model.common.order.Order;
 import org.openbravo.model.common.order.OrderLine;
 import org.openbravo.model.common.plm.Product;
@@ -156,8 +157,13 @@
   }
 
   private boolean isProductItemStockable(final Product product) {
-    return product != null && product.isStocked()
-        && StringUtils.equals(PRODUCTTYPE_ITEM, product.getProductType());
+    try {
+      OBContext.setAdminMode(false);
+      return product != null && product.isStocked()
+          && StringUtils.equals(PRODUCTTYPE_ITEM, product.getProductType());
+    } finally {
+      OBContext.restorePreviousMode();
+    }
   }
 
   private Order getSalesOrder(final Entity orderLineEntity, final EntityPersistenceEvent event) {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2018-03-13 16:34	martinsdan	New Issue
2018-03-13 16:34	martinsdan	Assigned To	=> Triage Finance
2018-03-13 16:34	martinsdan	File Added: AWOCreateOrderFromQuotation.patch
2018-03-13 16:34	martinsdan	OBNetwork customer	=> No
2022-09-06 17:18	caristu	Category	Advance Warehouse Operations => Advanced Warehouse Operations