0037455: Detected slow piece of code in LoginUtils

Description

In an environment with many organizations, get General Ledger of context organizations part in LoginUtils.java (specifically, the loop by organization and selectAcctSchema inside) is a bit slow and could be improved.

slow part:

        // Get General Ledger of context organizations
        if (ArrayUtils.isEmpty(attr)) {
          String[] orgList = Utility.getContext(conn, vars, "#User_Org", "LoginHandler")
              .replace("'", "").split(",");
          for (String orgId : orgList) {
            if (!StringUtils.equals(orgId, strOrg)) {
              acctSchemaId = OBLedgerUtils.getOrgLedger(orgId);
              if (StringUtils.isNotEmpty(acctSchemaId)) {
                attr = AttributeData.selectAcctSchema(conn, acctSchemaId,
                    Utility.getContext(conn, vars, "#User_Client", "LoginHandler"));
                if (ArrayUtils.isNotEmpty(attr)) {
                  break;
                }
              }
            }
          }
        }

The system searches for a valid acct schema using a dummy algorithm. If we search using a smarter way, we could improve the performance of this piece.

Steps To Reproduce

Login in the ERP
Open developer tools
Change the role to a role with access to many organizations
Verify this piece of code is slow.

Tags

Performance

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0037277

closed

AtulOpenbravo

Change the role in the ERP has performance problems

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2017-12-12 10:15	AtulOpenbravo	New Issue
2017-12-12 10:15	AtulOpenbravo	Assigned To	=> AtulOpenbravo
2017-12-12 10:15	AtulOpenbravo	Modules	=> Core
2017-12-12 10:15	AtulOpenbravo	Resolution time	=> 1512342000
2017-12-12 10:15	AtulOpenbravo	Triggers an Emergency Pack	=> No
2017-12-12 10:15	AtulOpenbravo	Issue generated from	0037277
2017-12-12 10:15	AtulOpenbravo	Relationship added	related to 0037277
2017-12-12 10:38	AtulOpenbravo	Status	new => scheduled
2017-12-12 11:39	vmromanos	Resolution time	1512342000 =>
2017-12-14 12:05	shuehner	Tag Attached: Performance
2017-12-14 12:20	vmromanos	Severity	major => minor
2017-12-14 12:20	vmromanos	Summary	Change the role in the ERP has performance problems => Detected slow piece of code in LoginUtils
2017-12-14 12:20	vmromanos	Description Updated	View Revisions
2017-12-14 12:20	vmromanos	Steps to Reproduce Updated	View Revisions