0037356: Log beautifier is not working - Openbravo Issue Tracking System

Notes
(0100947) AtulOpenbravo (developer) 2017-12-08 10:41	- Login as AWO-QA Admin - Go to Warehouse Verbosity Configuration and create a new record with emtpy User/Contact and no starting and ending date, Level = INFO - Go to Sales Order window and create a new record with: * Organization: US * BusinessPartner: Healthy Food Supermarkets * Transaction Document: Standard Order * Warehouse: US West Coast - Move to Lines tab and create a new record with: * Product: Ale Beer * Operative Quantity: 5 Book the Sales Order - Click on Pick button and launch the picking process. Realize that success message is shown as Process completed successfully 1 task(s) created successfully [Batch of Tasks document no. 1000296]. Picking list AWOPLST1000107 created successfully. - Again Click on Pick button and launch picking process. Realize that error message is shown as Error: No Picking List document was created. - Go to Warehouse Verbosity Log and select the last record created. Click on Beautify Log button and realize that a new tab is opened with content as * AWO flows are granted for Organization [US] * Detected Inventory Transaction Type [Picking Sales Order] * Calculate Task Requirements for the sales order picking [Sales Order - 1000012 - 04-12-2017 - Healthy Food Supermarkets, Co.] * Analyze sales order line [1000012 - 20 - Discount 10% - 1Ud - - ] to create a task requirement... * Skipping order line [1000012 - 20 - Discount 10% - 1Ud - - ] because Product is not defined as Item and Stockable * Finished analyze sales order line [1000012 - 20 - Discount 10% - 1Ud - - ] in order to create a task requirement. * Analyze sales order line [1000012 - 10 - Ale Beer - 5Ud - 5Ud - ] to create a task requirement... * Quantity ordered [5]; Quantity detected in previous picking tasks [5]; Quantity in standalone issue tasks [0]; Quantity pending to generate task [0] * There is no need to create a task requirement for this line * Finished analyze sales order line [1000012 - 10 - Ale Beer - 5Ud - 5Ud - ] in order to create a task requirement. * Finished calculate Task Requirements for the sales order picking [Sales Order - 1000012 - 04-12-2017 - Healthy Food Supermarkets, Co.] * No tasks were generated. * Error detected in Central Broker: No Picking List document was created. * Rollback successfully executed * Total time spent: 52 ms

(0100983) hgbot (developer) 2017-12-12 13:57	Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 6c6ee128cec00824f65f637509045dc8fec5dd56 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Fri Dec 08 14:50:40 2017 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/6c6ee128cec00824f65f637509045dc8fec5dd56 [^] Fixes Issue 0037356: Log beautifier is not working When there is exception in Central Broker instead of adding whole error stack trace to log line only error message is added so that json structure is maintained. --- M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/CentralBroker.java ---

(0100984) hgbot (developer) 2017-12-12 13:57	Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: e999d1a0d6245e144a3cbf19b0589be4eab24f92 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Dec 12 13:43:48 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/e999d1a0d6245e144a3cbf19b0589be4eab24f92 [^] Related to issue 37356: Backed out changeset 6c6ee128cec0 The solution is not right because it removes the error stacktrace (and we want it to be shown), and mainly because it doesn't fix the real problem behind: the JSON structure builder --- M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/CentralBroker.java ---

(0100985) hgbot (developer) 2017-12-12 13:57	Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 432af9552baaaad20781a70e84fad69be07c32cb Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Dec 12 13:48:35 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/432af9552baaaad20781a70e84fad69be07c32cb [^] Fixed issue 37356: Reimplemented JSONObject builder The way the JSONObject was built wasn't standard. This piece of code has been refactorized to use the Java API to build this kind of structure. Other minor improvements: * Set the product identifier in a concrete error message * Added a new line to separate error and stacktrace --- M src/org/openbravo/warehouse/advancedwarehouseoperations/task/TaskProposalsGenerator.java M src/org/openbravo/warehouse/advancedwarehouseoperations/verbosity/BeautifyLogHTMLFormatter.java M src/org/openbravo/warehouse/advancedwarehouseoperations/verbosity/JSONVerbosityLogger.java M src/org/openbravo/warehouse/advancedwarehouseoperations/verbosity/identificator/implementation/IdentificatorVerbosity_OBException.java ---

(0100987) vmromanos (manager) 2017-12-12 14:01	Code review + testing OK

Issue History
Date Modified	Username	Field	Change
2017-11-22 11:41	dmiguelez	New Issue
2017-11-22 11:41	dmiguelez	Assigned To	=> dmiguelez
2017-11-27 12:07	dmiguelez	Severity	minor => major
2017-11-30 18:42	dmiguelez	Assigned To	dmiguelez => AtulOpenbravo
2017-12-01 13:16	AtulOpenbravo	Status	new => scheduled
2017-12-08 10:41	AtulOpenbravo	Note Added: 0100947
2017-12-12 13:57	hgbot	Checkin
2017-12-12 13:57	hgbot	Note Added: 0100983
2017-12-12 13:57	hgbot	Status	scheduled => resolved
2017-12-12 13:57	hgbot	Resolution	open => fixed
2017-12-12 13:57	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/6c6ee128cec00824f65f637509045dc8fec5dd56 [^]
2017-12-12 13:57	hgbot	Checkin
2017-12-12 13:57	hgbot	Note Added: 0100984
2017-12-12 13:57	hgbot	Checkin
2017-12-12 13:57	hgbot	Note Added: 0100985
2017-12-12 13:57	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/6c6ee128cec00824f65f637509045dc8fec5dd56 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/432af9552baaaad20781a70e84fad69be07c32cb [^]
2017-12-12 14:01	vmromanos	Review Assigned To	=> vmromanos
2017-12-12 14:01	vmromanos	Note Added: 0100987
2017-12-12 14:01	vmromanos	Status	resolved => closed
2022-09-06 17:18	caristu	Category	Advance Warehouse Operations => Advanced Warehouse Operations

Relationships [ Relation Graph ] [ Dependency Graph ]